devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Gavin Shan <gshan@redhat.com>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	drjones@redhat.com, shan.gavin@gmail.com
Subject: Re: [PATCH] Documentation, dt, numa: Add note to empty NUMA node
Date: Wed, 23 Jun 2021 19:14:21 -0700	[thread overview]
Message-ID: <a6cdc518-3bd7-2b66-acd0-c4d53d360eae@infradead.org> (raw)
In-Reply-To: <20210624033740.20862-1-gshan@redhat.com>

On 6/23/21 8:37 PM, Gavin Shan wrote:
> The empty NUMA nodes, where no memory resides in, are allowed. For
> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
> empty NUMA node IDs are still valid and parsed. I finds difficulty
> to get where it's properly documented.
> 
> So lets add note to empty NUMA nodes in the NUMA binding doc.
> 
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
>  Documentation/devicetree/bindings/numa.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
> index 21b35053ca5a..c564705c0eac 100644
> --- a/Documentation/devicetree/bindings/numa.txt
> +++ b/Documentation/devicetree/bindings/numa.txt
> @@ -109,6 +109,10 @@ Example:
>  Dual socket system consists of 2 boards connected through ccn bus and
>  each board having one socket/soc of 8 cpus, memory and pci bus.
>  
> +Note that the empty NUMA nodes, which no memory resides in, are allowed

Missing period at end of the sentence above.

> +Their NUMA node IDs are still valid so that memory can be added into these
> +NUMA nodes through hotplug afterwards.
> +
>  	memory@c00000 {
>  		device_type = "memory";
>  		reg = <0x0 0xc00000 0x0 0x80000000>;


thanks.

  reply	other threads:[~2021-06-24  2:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  3:37 [PATCH] Documentation, dt, numa: Add note to empty NUMA node Gavin Shan
2021-06-24  2:14 ` Randy Dunlap [this message]
2021-06-24  4:58   ` Gavin Shan
2021-06-24  5:37     ` Randy Dunlap
2021-06-24  7:44       ` Gavin Shan
2021-06-25  2:10         ` Gavin Shan
  -- strict thread matches above, loose matches on Subject: below --
2021-09-06  4:14 Gavin Shan
2021-09-21 19:44 ` Rob Herring
2021-09-22 11:05   ` Ard Biesheuvel
2021-09-23  6:32     ` Gavin Shan
2021-09-23 15:17       ` Rob Herring
2021-09-27  1:16         ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6cdc518-3bd7-2b66-acd0-c4d53d360eae@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drjones@redhat.com \
    --cc=gshan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shan.gavin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).