devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	andersson@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, viresh.kumar@linaro.org
Subject: Re: [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: Supply clock from cpufreq node to CPUs
Date: Thu, 16 Feb 2023 11:40:23 +0100	[thread overview]
Message-ID: <a6e099d1-a201-cdb6-f037-42f94642d8c6@linaro.org> (raw)
In-Reply-To: <20230215070400.5901-13-manivannan.sadhasivam@linaro.org>



On 15.02.2023 08:04, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
> 
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm6115.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 4d6ec815b78b..f55b193139bf 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -39,6 +39,7 @@ CPU0: cpu@0 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x0>;
> +			clocks = <&cpufreq_hw 0>;
>  			capacity-dmips-mhz = <1024>;
>  			dynamic-power-coefficient = <100>;
>  			enable-method = "psci";
> @@ -54,6 +55,7 @@ CPU1: cpu@1 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x1>;
> +			clocks = <&cpufreq_hw 0>;
>  			capacity-dmips-mhz = <1024>;
>  			dynamic-power-coefficient = <100>;
>  			enable-method = "psci";
> @@ -65,6 +67,7 @@ CPU2: cpu@2 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x2>;
> +			clocks = <&cpufreq_hw 0>;
>  			capacity-dmips-mhz = <1024>;
>  			dynamic-power-coefficient = <100>;
>  			enable-method = "psci";
> @@ -76,6 +79,7 @@ CPU3: cpu@3 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x3>;
> +			clocks = <&cpufreq_hw 0>;
>  			capacity-dmips-mhz = <1024>;
>  			dynamic-power-coefficient = <100>;
>  			enable-method = "psci";
> @@ -87,6 +91,7 @@ CPU4: cpu@100 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x100>;
> +			clocks = <&cpufreq_hw 1>;
>  			enable-method = "psci";
>  			capacity-dmips-mhz = <1638>;
>  			dynamic-power-coefficient = <282>;
> @@ -102,6 +107,7 @@ CPU5: cpu@101 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x101>;
> +			clocks = <&cpufreq_hw 1>;
>  			capacity-dmips-mhz = <1638>;
>  			dynamic-power-coefficient = <282>;
>  			enable-method = "psci";
> @@ -113,6 +119,7 @@ CPU6: cpu@102 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x102>;
> +			clocks = <&cpufreq_hw 1>;
>  			capacity-dmips-mhz = <1638>;
>  			dynamic-power-coefficient = <282>;
>  			enable-method = "psci";
> @@ -124,6 +131,7 @@ CPU7: cpu@103 {
>  			device_type = "cpu";
>  			compatible = "qcom,kryo260";
>  			reg = <0x0 0x103>;
> +			clocks = <&cpufreq_hw 1>;
>  			capacity-dmips-mhz = <1638>;
>  			dynamic-power-coefficient = <282>;
>  			enable-method = "psci";
> @@ -2123,6 +2131,7 @@ cpufreq_hw: cpufreq@f521000 {
>  			clock-names = "xo", "alternate";
>  
>  			#freq-domain-cells = <1>;
> +			#clock-cells = <1>;
>  		};
>  	};
>  

  reply	other threads:[~2023-02-16 10:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
2023-02-15  7:03 ` [RESEND PATCH 01/12] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
2023-02-16 10:33   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 02/12] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
2023-02-16 10:34   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 03/12] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2023-02-16 10:35   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 04/12] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2023-02-16 10:36   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 05/12] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-02-16 10:38   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 06/12] arm64: dts: qcom: qdu1000: " Manivannan Sadhasivam
2023-02-16 10:38   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 07/12] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam
2023-02-16 10:38   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 08/12] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-02-16 10:38   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 09/12] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-02-16 10:39   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 10/12] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-02-16 10:39   ` Konrad Dybcio
2023-02-15  7:03 ` [RESEND PATCH 11/12] arm64: dts: qcom: sm6375: " Manivannan Sadhasivam
2023-02-16 10:40   ` Konrad Dybcio
2023-02-15  7:04 ` [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
2023-02-16 10:40   ` Konrad Dybcio [this message]
2023-02-16 10:32 ` [RESEND PATCH 00/12] arm64: dts: qcom: " Konrad Dybcio
2023-03-15 23:35 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6e099d1-a201-cdb6-f037-42f94642d8c6@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).