From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B244C46467 for ; Tue, 10 Jan 2023 11:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232718AbjAJLCf (ORCPT ); Tue, 10 Jan 2023 06:02:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238639AbjAJLAk (ORCPT ); Tue, 10 Jan 2023 06:00:40 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E91082039 for ; Tue, 10 Jan 2023 03:00:27 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id z5so10245133wrt.6 for ; Tue, 10 Jan 2023 03:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/sqiSzZl7tdMGMHM9Gz+tcnXK/Rd5YLz0PHqdYF7LCk=; b=ZQXKT4wkWx65R4H1mNwPG5BEVzRem0IDMqI+AVwmlowlMKW5cNVfe0PCv8FvPI+hqm xESithyiznoZHNePFVUSFjYkRtcx0p6vPtxfBoWfgc/TRCDCQJFc9TZExuX3iFT9gnG2 J1MV4C8FUc+RC3TjxKLBi40x27e2bKyZHlXOUETWSotP+owHeCjisXY4PIU9xOfmtzqd o2K9E63XyKMfKNWbXdODcXCDHscM9itobyiIwzaZKGpbwhI7Rbnrcz9h418QR+0EGLSY i3hfAYcPKkm2dNLISuf13jPzs3b0aM84S1Hf+c/GHiURJ8KnXQHTSp0gCCUSxRPZGxNw fXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/sqiSzZl7tdMGMHM9Gz+tcnXK/Rd5YLz0PHqdYF7LCk=; b=cHKW9+A49436imsXcnXC/TbY/lSwwYmaWR/lQ64hAz9RXilV3oJbsKTjZ1kTU6CIc/ 1QeEsjhqC6OsPlZLb68s5KcrEAZWi21xCgYydO0SUw9NyeE7XneBZW9J0RcdGrrGQ1UD 2r4XvNi8bT3v1xhs0tRp5740vqeujO9P4SdSypFYVTJhEU72O0wS39nwe1Ta7ealNPHd 9HdmhQ1QiNUkENSUxfRVQViMXM8bgWCyQCeeeovitGA5YUA/nmQE3uOwlB/nK4AaM5hl +zmR2FJSrUq3lQOMni6fumdOVR+AJ4c0nl0yz0Y/loDN2qPs20rQFuEgbFe5FrAezFPM 7QXA== X-Gm-Message-State: AFqh2kpBgUHKon6dNFV1SbxTpCmFvFQfkFPTLKqCF17YOi2STE8Uaj8m KTQMNvUWQvHe/3+lPY4/nanBbw== X-Google-Smtp-Source: AMrXdXsOjHmSfpTkgnzh7bn9JY2hWvnUyty612zsqrepGkZwnB14MBwUC1NHz0RvAPFuLyPtpC2hqg== X-Received: by 2002:adf:e24d:0:b0:2a7:c412:ed22 with SMTP id bl13-20020adfe24d000000b002a7c412ed22mr14332009wrb.58.1673348426433; Tue, 10 Jan 2023 03:00:26 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g1-20020a056000118100b002755e301eeasm10664865wrx.100.2023.01.10.03.00.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 03:00:25 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 12:00:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/8] arm64: dts: qcom: sc7280: audioreach: Add sound node Content-Language: en-US To: Srinivasa Rao Mandadapu , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, konrad.dybcio@linaro.org, mka@chromium.org References: <1672925875-2107-1-git-send-email-quic_srivasam@quicinc.com> <1672925875-2107-3-git-send-email-quic_srivasam@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1672925875-2107-3-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/01/2023 14:37, Srinivasa Rao Mandadapu wrote: > Add sound node for sc7280 based audioreach platforms. > > Include audioreach dtsi into crd-rev3 platform specific dts file. > Also remove phandle to sound node, as audio routing is same as > audioreach specific dtsi file. > Thank you for your patch. There is something to discuss/improve. > +#include > + > +/{ > + /* BOARD-SPECIFIC TOP LEVEL NODES */ > + sound: sound { > + compatible = "google,sc7280-herobrine"; > + model = "SC7280-AUDIOREACH"; > + adsp-mode; There is no such property. Test DTS against your schema, so make dtbs_check DT_SCHEMA_FILES=google,sc7280-herobrine > + audio-routing = > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "AMIC1", "MIC BIAS1", > + "AMIC2", "MIC BIAS2", > + "VA DMIC0", "MIC BIAS1", > + "VA DMIC1", "MIC BIAS1", > + "VA DMIC2", "MIC BIAS3", > + "VA DMIC3", "MIC BIAS3", > + "TX SWR_ADC0", "ADC1_OUTPUT", > + "TX SWR_ADC1", "ADC2_OUTPUT", > + "TX SWR_ADC2", "ADC3_OUTPUT", > + "TX SWR_DMIC0", "DMIC1_OUTPUT", > + "TX SWR_DMIC1", "DMIC2_OUTPUT", > + "TX SWR_DMIC2", "DMIC3_OUTPUT", > + "TX SWR_DMIC3", "DMIC4_OUTPUT", > + "TX SWR_DMIC4", "DMIC5_OUTPUT", > + "TX SWR_DMIC5", "DMIC6_OUTPUT", > + "TX SWR_DMIC6", "DMIC7_OUTPUT", > + "TX SWR_DMIC7", "DMIC8_OUTPUT"; > + > + qcom,msm-mbhc-hphl-swh = <1>; > + qcom,msm-mbhc-gnd-swh = <1>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <0>; > + > + dai-link@0 { > + link-name = "WCD9385 Playback"; > + reg = <0>; > + > + cpu { > + sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>; > + }; > + codec { > + sound-dai = <&wcd9385 0>, <&swr0 0>, <&lpass_rx_macro 0>; > + }; > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + > + dai-link@1 { > + link-name = "WCD9385 Capture"; > + reg = <1>; > + > + cpu { > + sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>; > + }; > + codec { > + sound-dai = <&wcd9385 1>, <&swr1 0>, <&lpass_tx_macro 0>; > + }; > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + > + dai-link@2 { > + link-name = "Amplifier Playback"; > + reg = <3>; Missing dtbs W=1 build. > + > + cpu { > + sound-dai = <&q6apmbedai SECONDARY_MI2S_RX>; > + }; > + Use consistent style. Either blank line or not between the cpu/codec/platform nodes. > + codec { > + sound-dai = <&max98360a>; > + }; > + > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + > + dai-link@3 { > + link-name = "DMIC"; > + reg = <4>; Same problem, wrong reg. > + > + cpu { > + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>; > + }; > + > + codec { > + sound-dai = <&lpass_va_macro 0>; > + }; > + > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + }; > +}; Best regards, Krzysztof