Re: [PATCH] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/07/2024 15:16, Yannick Fertre wrote:
> Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduces
> new clocks (bus, ref & lvds). Bus clock was separated from lcd clock.
> New sources are possible for lcd clock (lvds / ref).
> 
> Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com>
> ---
>  .../bindings/display/st,stm32-ltdc.yaml       | 29 +++++++++++++++++--
>  1 file changed, 27 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> index d6ea4d62a2cf..680669c44b80 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> @@ -12,7 +12,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: st,stm32-ltdc
> +    enum:
> +      - st,stm32-ltdc
> +      - st,stm32mp25-ltdc
>  
>    reg:
>      maxItems: 1
> @@ -24,7 +26,9 @@ properties:
>      minItems: 1
>  
>    clocks:
> -    maxItems: 1
> +    minItems: 1

You miss maxItems

> +    items:
> +      description: Lcd Clock

That's not correct and drop... or describe the items like:
items:
 - description:

>  
>    clock-names:

So clock-names are probably de-synced now...

>      items:
> @@ -42,6 +46,27 @@ properties:
>        - for internal dpi input of the MIPI DSI host controller.
>        Note: These 2 endpoints cannot be activated simultaneously.
>  
> +
> +allOf:

This goes after required: block, see example schema

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - st,stm32mp25-ltdc
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: bus clock
> +            - description: reference clock
> +            - description: lvds clock
> +        clock-names:
> +          items:
> +            - const: bus
> +            - const: ref
> +            - const: lvds

else:
  maxItems for both entries

> +
>  required:
>    - compatible
>    - reg

Best regards,
Krzysztof