From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>
Cc: linux-phy@lists.infradead.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
jeyaprakash.soundrapandian@oss.qualcomm.com,
Vijay Kumar Tumati <vijay.tumati@oss.qualcomm.com>,
Atiya Kailany <atiya.kailany@oss.qualcomm.com>
Subject: Re: [PATCH v20 08/13] media: qcom: camss: vfe: Add support for VFE 1080
Date: Sun, 11 Oct 2026 09:56:28 +0100 [thread overview]
Message-ID: <a6e5dc34-c2e7-4a3c-a0e4-fb0a3a28cece@linaro.org> (raw)
In-Reply-To: <20261010-kaanapali-camss-v20-8-63e98ce9ac0c@oss.qualcomm.com>
On 10/10/2026 17:01, Hangxiang Ma wrote:
> + if (!vfe->res->reg_update_after_csid_config)
> + ops->reg_update(vfe, line->id);
So I'd prefer to have a discussion about if we can move all of the
updates to one method.
i.e. why should any of the updates happen before csid ?
Sure vfe 1080's documentation makes some sort of explicit statement
about an update that has been implied for some time.
My question is why not gate all of the updates this way and make this
not a flag but a global behaviour ?
---
bod
next prev parent reply other threads:[~2026-10-11 8:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 16:01 [PATCH v20 00/13] media: qcom: camss: Add Kaanapali support Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 01/13] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Kaanapali CSI2 PHY Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 02/13] phy: qcom-mipi-csi2: Parametrise the common status register offset Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 03/13] phy: qcom-mipi-csi2: Add Kaanapali support Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 04/13] media: dt-bindings: Add CAMSS device for Kaanapali Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 05/13] media: qcom: camss: Add Kaanapali compatible Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 06/13] media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY Hangxiang Ma
2026-10-10 16:23 ` sashiko-bot
2026-10-10 16:01 ` [PATCH v20 07/13] media: qcom: camss: csid: Add support for CSID 1080 Hangxiang Ma
2026-10-10 16:22 ` sashiko-bot
2026-10-10 16:01 ` [PATCH v20 08/13] media: qcom: camss: vfe: Add support for VFE 1080 Hangxiang Ma
2026-10-10 16:25 ` sashiko-bot
2026-10-11 8:56 ` Bryan O'Donoghue [this message]
2026-10-12 1:25 ` hangxiang.ma
2026-10-10 16:01 ` [PATCH v20 09/13] media: qcom: camss: tpg: Add support for v2.4.0 TPG Hangxiang Ma
2026-10-10 16:19 ` sashiko-bot
2026-10-10 16:01 ` [PATCH v20 10/13] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 11/13] arm64: dts: qcom: kaanapali: Add CCI controller nodes Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 12/13] arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl Hangxiang Ma
2026-10-10 16:01 ` [PATCH v20 13/13] arm64: dts: qcom: kaanapali-mtp-camera-s5kjn5: Add DT overlay Hangxiang Ma
2026-10-10 16:21 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6e5dc34-c2e7-4a3c-a0e4-fb0a3a28cece@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=atiya.kailany@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hangxiang.ma@oss.qualcomm.com \
--cc=jeyaprakash.soundrapandian@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vijay.tumati@oss.qualcomm.com \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox