From: Randy Dunlap <rdunlap@infradead.org>
To: Luca Ceresoli <luca@lucaceresoli.net>, linux-pm@vger.kernel.org
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger driver
Date: Mon, 4 Oct 2021 08:28:22 -0700 [thread overview]
Message-ID: <a6ea9a21-e9df-b596-eb80-4df4b8d8115e@infradead.org> (raw)
In-Reply-To: <20211004130732.950512-2-luca@lucaceresoli.net>
On 10/4/21 6:07 AM, Luca Ceresoli wrote:
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index ad93b3550d6d..622d690c883a 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -557,6 +557,17 @@ config CHARGER_MAX77693
> help
> Say Y to enable support for the Maxim MAX77693 battery charger.
>
> +config CHARGER_MAX77976
> + tristate "Maxim MAX77976 battery charger driver"
> + depends on REGMAP_I2C
> + help
> + The Maxim MAX77976 is a 19 Vin, 5.5A 1-Cell Li+ Battery Charger
> + USB OTG support. It has an I2C interface for configuration.
> +
> + Say Y to enable support for the Maxim MAX77976 battery charger.
> + This driver can also be built as a module. If so, the module will be
> + called max77976_charger.
REGMAP_I2C is not a user-settable config option, so drivers should not
"depend on" it. This should be more like:
depends on I2C
select REGMAP_I2C
--
~Randy
next prev parent reply other threads:[~2021-10-04 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:07 [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger Luca Ceresoli
2021-10-04 13:07 ` [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger driver Luca Ceresoli
2021-10-04 15:28 ` Randy Dunlap [this message]
2021-10-05 13:15 ` Luca Ceresoli
2021-10-25 22:02 ` Sebastian Reichel
2021-10-26 11:50 ` Luca Ceresoli
2021-10-06 16:15 ` [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger Sebastian Reichel
2021-10-26 11:53 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ea9a21-e9df-b596-eb80-4df4b8d8115e@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).