From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BCF521931C for ; Mon, 21 Jul 2025 04:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753071508; cv=none; b=ZQjttV3qe1HsDVnE8CDbT2qL2YKT6IGtEyWDDhEqWPv4ex21IRdCihyDgouUCUSlH4FCo8p504sC8pzGQgVYkrfK2exNBlqN+k5mSRu6jyv3uuO/ACqaG7J7E181Me+n+lvGnJ3W9O1ghNg7cgvwODm05KfwvTmkTNTqHJTX71U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753071508; c=relaxed/simple; bh=zVvUOIlnKKCqQgJ3kE21UViYgXE0z1AIp5kpX5JAwaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N9mslsKN0YSwfyQ00tQ7FzNlWfyp+lxAt6YKrwQE9MBQowO5ru1J+meEcTvjf5mnDGN9zxKQ7mV2+eOJ8wtC7ztwMy9RS4RIx0rD5iaxbjy+ScwdVH9FlqGqEnnjEL0WFnZlkLFnOzTmywTHQPqQTa/VdNNko2NTinjuaNGY4WQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pd+gqMZN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pd+gqMZN" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56L40bkc029264 for ; Mon, 21 Jul 2025 04:18:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0HxS55+QTxxnhovCNlJMVgeCUCIs7adrQbeCrM4+8pY=; b=Pd+gqMZN6VlsReQ2 ApLJJ3KRx8yfPGzjKNebwJ80Go6FToeUYYa4O3lfQ5S2qmB4E34dhEzTL4M9KXN7 vU58SaWiWgI4OzuOYPgSrgb4RQf375zxiPkmT2RUyzmLU7FJsSnJTkBQqSIc0xQe hH68NESm3siMXM5EMpgKo76pIExrNphUcOUVqi/jQgSj23wvtEG8dmGSi6TaCuPI thk+Z/BVtHM2Lw4D3n6mBmBwz1l9IKfKnqGriP6TdGbt06GYnx+uoH91zzfPDYI6 F/Oi+QNMY1ijMZcOsntm8K2USXBvnjx669FrqrQIPQixelVh80lAKL/3UoieitQL j6WMLQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48048tba3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 21 Jul 2025 04:18:25 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-75a23a16107so188609b3a.2 for ; Sun, 20 Jul 2025 21:18:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753071504; x=1753676304; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0HxS55+QTxxnhovCNlJMVgeCUCIs7adrQbeCrM4+8pY=; b=jYj3hMRx4lni4tEhUmrQcdtyZTDyWvHpufoUoQ6sA1APwvuxhOT/Uco6n63+jCU9nh tNOoI1wO6nnT1QDpUcLC+23kdm2QcdWxfQ9dgXsp7jIoSJhUHbDlaEQlycdNzhuu95wl ikAojzKRaWephxDNP0+yLcB37Njw57qDHsAA2Ow4Ee3zrw0yTpFCNQ22vWLyEQHIBkqq +kGg8EeC9S/zUEGAz/HKhlEyE+CujNirSSvWcIsHLoonMn9JEHlD2w70KnLTG/wvvQi4 X4uJsnTjYrUH9QHfB4N4UKFA5D3OEijPfkihk091zEkVWou2wtdeExYo/kMXADsAghxE XYpg== X-Forwarded-Encrypted: i=1; AJvYcCVC8kYrB+ZinAW/z2DCQLU7Dd/BbapCkNYrnjYP/3XpAw2kGUcKypgFu8ImGmfm5p6K/Dt/NXZwLBEV@vger.kernel.org X-Gm-Message-State: AOJu0YzzduecTuRRhRIR1AJ/M6FLSL9D/PH3Uvch6JnU2gaTcSSRWdXe QjJqur43htuPvAxpk/W3jrYZYB2RC63ssHfTJ4UlKqcd1S5gzn9+ahZoTGtjpqaJGF2oqvysqIG hlObYhi4S5BhA0BQ8bxLTJmflnw3/H8zyhxmmlbeKC1SKuNzjbT+MFLJbH4zeOxZc X-Gm-Gg: ASbGncv1QUwmmKXCA9e9dPVOvBbndpoa4qwjkDGkWz3vN6DLKb9LmXfXpRSTQEMUM9H KjzcmLDEuLmMG4uXl8i/YRf9lGZVQmMndBb7xYrztPxlWOYpv0y8ZqxDvA1PNhf/oTecrYANNz5 52Zyq3zGubiVezmfdCmjwgMwGtf6mGhimks9VTq7LoVTXdfZKdhNmYezPud0Ht/odnVQnCqRB5T YuXbsYnZYsRl6TMsJSTTAw23CIGNWsk1BUa7KCRRkWKMetJAOwsU12TasDjM5BzU8H4I01VS0bA OptpljNShxMBoOtkWmH0T3Hk6BZYiphAWupgd/GrplXwiAZx5EdspvtQUabHcb1RW2kW8NpzR0s eOunGaNzZ8YNlQNSJTuYmSJazTeQr X-Received: by 2002:a05:6a20:9147:b0:1ee:d6da:b645 with SMTP id adf61e73a8af0-237d5c0df9emr13823350637.4.1753071504481; Sun, 20 Jul 2025 21:18:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9E+Jpxuf/n9mwdKcrc+ICdr6n87fGKbL6wE5SUt8XIJ2tugZsZ8TP4nLkT2kWBtaUKyMt+w== X-Received: by 2002:a05:6a20:9147:b0:1ee:d6da:b645 with SMTP id adf61e73a8af0-237d5c0df9emr13823324637.4.1753071503997; Sun, 20 Jul 2025 21:18:23 -0700 (PDT) Received: from [10.133.33.17] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b3f2fe8ea7bsm4493637a12.21.2025.07.20.21.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jul 2025 21:18:23 -0700 (PDT) Message-ID: Date: Mon, 21 Jul 2025 12:18:16 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] drm/msm/dp: Retry Link Training 2 with lower pattern To: Dmitry Baryshkov Cc: Konrad Dybcio , Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Vinod Koul , Kishon Vijay Abraham I , Linus Walleij , Bartosz Golaszewski , quic_lliu6@quicinc.com, quic_fangez@quicinc.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, quic_xiangxuy@quicinc.com References: <20241129-add-displayport-support-for-qcs615-platform-v1-0-09a4338d93ef@quicinc.com> <20241129-add-displayport-support-for-qcs615-platform-v1-7-09a4338d93ef@quicinc.com> From: Xiangxu Yin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIxMDAzNCBTYWx0ZWRfXxv4DLQbnpoy2 7hU1wruLv22/J0d6lhpjDdRJlo2J2KjaDsMFoJYwdUFosMOFiXaaLITOaWdWOq36urImPY/IpTN 563ieejmFYtO/LwnRK8nqp6j++3BNVwCRM4mDzoOkGrH3x9SYG2pYXpQeEY+XPybMaQq58Ooeg7 m/a64J5wwjoI6LTYhbuZoY9lruEJHskqaoQB/Ld5HQaYHIJiG7m9TF6E53lQ7I7ZRR9+z+f/2ha 1+5DymQ9EmJGRdYmP6aqLaLd+QMduKEWJZbn0MRD72HXA7kzjvf2/bjFjRPl6OfwEwgLHcS4FUs /XrjQgYqBu5Cny4UYc6jddlIPnMC9SruSl8Vc76LrjoEBRu4AcAINiLgmMEhFLC5yLdRiSmr2/F +ZvMWFHmXBaR36kNSBodKzc2fsRqZO068kWyCWmOhADUql79X/gRKXZv7rrLvwogr4JQmej5 X-Authority-Analysis: v=2.4 cv=Jb68rVKV c=1 sm=1 tr=0 ts=687dbf91 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=COk6AnOGAAAA:8 a=q-zp-rPcFIMxVU44S18A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 2OgOc3pbApvtviN625_nCGvpb7jNgSdy X-Proofpoint-ORIG-GUID: 2OgOc3pbApvtviN625_nCGvpb7jNgSdy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-21_02,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507210034 On 7/19/2025 5:43 PM, Dmitry Baryshkov wrote: > On Wed, Jul 09, 2025 at 05:16:02PM +0800, Xiangxu Yin wrote: >> >> On 5/28/2025 4:49 AM, Konrad Dybcio wrote: >>> On 12/3/24 3:07 PM, Dmitry Baryshkov wrote: >>>> On Tue, Dec 03, 2024 at 04:13:22PM +0800, Xiangxu Yin wrote: >>>>> >>>>> On 11/29/2024 9:53 PM, Dmitry Baryshkov wrote: >>>>>> On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >>>>>>> Add a mechanism to retry Link Training 2 by lowering the pattern level >>>>>>> when the link training #2 first attempt fails. This approach enhances >>>>>>> compatibility, particularly addressing issues caused by certain hub >>>>>>> configurations. >>>>>> Please reference corresponding part of the standard, describing this lowering. >>>>>> >>>>> Per DisplayPort 1.4a specification Section 3.5.1.2 and Table 3-10, while the standard doesn't explicitly define a TPS downgrade mechanism, it does specify: >>>> Anything in DP 2.1? >>>> >> In the DP 2.1 spec, mainly on section '3.6.7.2 8b/10b DP Link Layer LTTPR Link Training Mandates', defined 'LTTPR shall support TPS4'. >> The other parts seems similar to the 1.4 spec. >>>>> - All devices shall support TPS1 and TPS2 >>>>> - HDR2-capable devices shall support TPS3 >>>>> - HDR3-capable devices shall support TPS4 >>>>> While these capabilities are explicitly defined DPCD for sink devices, source device capabilities are less strictly defined, with the minimum requirement being support for TPS1 and TPS2. >>>>> In QCS615 DP phy is only supporting to HBR2, we observed a critical interoperability scenario with a DP->HDMI bridge. When link training at TPS4 consistently failed, downgrading to the next lower training pattern successfully established the link and display output successfully. >>>> Any other driver doing such TPS lowering? Or maybe we should be >>>> selecting TPS3 for HBR2-only devices? >> This logic is porting from qualcomm downstream, > Hopefully a downstream has some sensible commit message which describes > the issue and the configuration to reproduce it? The downstream commit log shows in 2019/08, SM8250 (kernel 4.19) type-c DP meet LT2 failures on Samsung HDR curved monitor, the pattern lowering fix was adopted. On QCS615, an mDP-to-HDMI adapter cable exhibited similar LT failure pattern, and it's works with this solution. However, It's rare compatibility case with special device and lowering seems violates protocol standards, maybe not suitable for general deployment. >> For other device, only found in some older Tx chips like i915（intel_dp_training_pattern) used the maximum hardware-supported patterns, but not lowering. >> >> According to the description in DPCD table 2-232 003h, From the DP spec perspective, it appears that all supported cases should preferably adopt TPS4, as it is more robust. > If other drivers don't perform this kind of lowering, I'd prefer if we > don't perform it too. Agree,  I'll remove this patch in an upcoming version soon. > >> 'DPRXs should support TPS4 and set this bit, regardless of whether the DPRX supports HBR3 because TPS4 is more conducive to robust link establishment than TPS2 and TPS3. >> 0 = TPS4 is not supported. >> 1 = TPS4 is supported (shall be supported for downstream devices with DPCD r1.4, except for eDPRXs).' >> >> Although maximum capability of QCS615 is HBR2, but the actual pattern supports TPS4. >> From pure design perspective, it would be cleaner to drop this lowering in next patch. >>> Bump, this patch looks interesting and I'd like to see it revisited if >>> it's correct >>> >>> Konrad >>