From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D87C7EE23 for ; Fri, 12 May 2023 06:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239783AbjELGZ7 (ORCPT ); Fri, 12 May 2023 02:25:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231518AbjELGZ6 (ORCPT ); Fri, 12 May 2023 02:25:58 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18EF53588 for ; Thu, 11 May 2023 23:25:57 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-94a342f7c4cso1708508766b.0 for ; Thu, 11 May 2023 23:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683872755; x=1686464755; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r1exhnuRm61lKc3x0rwGeHWk6dT2vR/1CPi8qpyaKMg=; b=gmGHhHCvMkCnWxGyHfkLx1KkdIIRDRMZ19JyipR8t03BPMUUSPJWuD+LjokTfnQuDr GZopQij93wYmjOIpvR1TPSAvn9WB9nXSj7Wa3bJJW+wwiB+U956R4ly9EsXVfs1FsVcc eEnKc/ZdoNrmdtDPhUEu+m+q0XVeTx1zAqw02AurxfIPHTJ0PDk7MHfxN6/wuZJuovti zhpfT1IVygAFOoivP4vDQ2CSaAXnwbRU8UzH4in0AT75MJgwJ/o9D1KX1t1qYIf5DKQH MsM+Yvcb7xi7QHBfcQyi4GJTetspTPVJYPvvPJ3bZMS8yKi7N9EHixYl4En1JJWtJnPV QPnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683872755; x=1686464755; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r1exhnuRm61lKc3x0rwGeHWk6dT2vR/1CPi8qpyaKMg=; b=bjfB5ZfCYWxtaWx5LhyNoo/QCj2AlL+8VQ2HIVYdSD4PNY9pV+pqd7FweLfy4ZBggP 0CuowiqMTbr6azwf/3SFYAxgu0hCoW9hLg1gBu9w+u+w+LivLEmDRgQP5uk+O2Iqi1/I EL4Oz06cJ/0l7oidff7D+4cWMi/vXrcogJ9pFVuZ50nkruLxFuifofsjVox32quVFsg7 8ItVhkEb9kIRc4FPahCziVHHkCei4CeE4aFaV0QufQog/j69nCjfeExwHAS67sLhYdRR 0Fz0EX46a+zbJrBMmVC9R82/IHLcNoiWDW81wgZia9KQWmSTLTprZKh5HyXfF/p7QoEb d64Q== X-Gm-Message-State: AC+VfDwNTcuLxWrknhdY4l4D8GfsnCtArRIOg/YEEVsOamkX200nsM1I gpsY/RXw8WgPcecIcYcNLDD98A== X-Google-Smtp-Source: ACHHUZ4t+Vlk49wYucsz5P/lKkrFidzVTt9kRvR9kx+8biobSZWjGortS1eMOu2JIbtwMybMIylSxA== X-Received: by 2002:a17:906:da87:b0:966:3c82:4a97 with SMTP id xh7-20020a170906da8700b009663c824a97mr17022638ejb.35.1683872755493; Thu, 11 May 2023 23:25:55 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7ede:fc7b:2328:3883? ([2a02:810d:15c0:828:7ede:fc7b:2328:3883]) by smtp.gmail.com with ESMTPSA id w21-20020a170907271500b00969dfd160aesm4650145ejk.109.2023.05.11.23.25.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 23:25:54 -0700 (PDT) Message-ID: Date: Fri, 12 May 2023 08:25:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/4] dt-bindings: touchscreen: add virtual-touchscreen and virtual-buttons properties Content-Language: en-US To: Javier Carrasco , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bastian Hecht , Michael Riesch Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org References: <20230510-feature-ts_virtobj_patch-v1-0-5ae5e81bc264@wolfvision.net> <20230510-feature-ts_virtobj_patch-v1-2-5ae5e81bc264@wolfvision.net> <280ab18d-bbfa-9920-5f1b-d069fd866e1f@linaro.org> <18526d2a-ac5f-2b26-9ed3-5a82f20cac86@wolfvision.net> From: Krzysztof Kozlowski In-Reply-To: <18526d2a-ac5f-2b26-9ed3-5a82f20cac86@wolfvision.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/05/2023 12:28, Javier Carrasco wrote: > On 11.05.23 11:45, Krzysztof Kozlowski wrote: >> On 10/05/2023 15:50, Javier Carrasco wrote: >>> The virtual-touchscreen object defines an area within the touchscreen >>> where touch events are reported and their coordinates get converted to >>> the virtual origin. This object avoids getting events from areas that >>> are physically hidden by overlay frames. >>> >>> For touchscreens where overlay buttons on the touchscreen surface are >>> provided, the virtual-buttons object contains a node for every button >>> and the key event that should be reported when pressed. >> >> Hm, I don't understand - are these separate physical buttons? If so, why >> would they be part of touchscreen? Where do the wires go? > Those buttons are actually printed on some overlays which are mounted on > top of the touchscreen and they are used to provide a predefined > functionality to that touchscreen region. Any touchscreen with such a > physical overlay with buttons printed on them or clipped touchscreen > areas might use this functionality. > > These buttons are actually physical i.e. printed and with a given > functionality, but still part of the touchscreen as the physical device > is not aware of them. Therefore they only make sense in the touchscreen > context. So basically you still have the same touchscreen under the buttons and these are not separate devices. Whether someone put a sticker on touchscreen, does not really change hardware behavior and it's up to system to handle this. What you are trying to do here is to create virtual buttons through Devicetree and DT is not for that. Best regards, Krzysztof