From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156FEC4332F for ; Mon, 28 Nov 2022 08:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbiK1Ira (ORCPT ); Mon, 28 Nov 2022 03:47:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbiK1Ir2 (ORCPT ); Mon, 28 Nov 2022 03:47:28 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED46717E07 for ; Mon, 28 Nov 2022 00:47:26 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id b3so16268965lfv.2 for ; Mon, 28 Nov 2022 00:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qXMY8f9iJDeQoKaNyCjgw4YZP5Yos8JV58NKPKjonWA=; b=INWnLSgoKorZYTLKYMFR0SCopMcQUb8vW+c8SCLMkc0NL95rTtpkyj2xYsncOheI7o JBaRFycHg/jwB3mN/13MkVibdO7w6IaJ7pnCrRdzbz3P5DOje8CZ09GGOIg6YvmLN3ws lgw87QYwpSNmpZn9/0VIBvaOYlUf8noaj/VbWjwdr1BP56VF51ns2rtj4vStbZglEqSk tYLiEMbaN6EtwozQ3W45bp28HoRV4OjIAEPGjQxTJUpgYVb0aeYuJR3/m8F05AnJiTnf bH6kE/boaq9iT4Gzqz3TJCdDvJoTm0bCFJT66I6CjWadlrhvW1NJ5FjWECNuOaCcru5b 1qDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qXMY8f9iJDeQoKaNyCjgw4YZP5Yos8JV58NKPKjonWA=; b=zjCZTzOVBrMQe3sVLHqNdALqvmOB0of3+W+oDp1qQZrMMBoD9clZl2XSMr4UgOluvE bgf7J0n0Z0qHTCgH/zSu4Nt97sWa7eSb/lmrihroij5MGXjvM7fui+bSaxTq2lvW5r0m g/8kGnGtCCV4o0tJ/rsDEM5BRzbQTjm6cidqen0ZwZ3UpzwIL3hnu/6QftSiVcW5IWP4 BW0l1+6HCoDB+r8Hz/WGxl64dKjEbO9DyRVX+9VdSppvZZ/ZpMd81Sx29d/THxVGdndm HnDS8BNorGQ0c8ruHg/kXROKbYl2vWPm4EtDO2lJShsUCQe70/INKmOeMA1f378N0gDx EZbg== X-Gm-Message-State: ANoB5plhI6vaZ5DVo/VaU+gqhhxO+2wILzbmsIP6dcbQqdqOQgVbZqZ7 LPXO2JbnzMFLvLQ8M2RLNifiww== X-Google-Smtp-Source: AA0mqf48HTjBl1q/N2bBerRjL5SpxOcN7KKcKyR6RessFHJh9U/pKAT/SphhbumIOtv4z0+d0iGbjA== X-Received: by 2002:a05:6512:158c:b0:4a2:3ba8:fae9 with SMTP id bp12-20020a056512158c00b004a23ba8fae9mr16461067lfb.440.1669625245297; Mon, 28 Nov 2022 00:47:25 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id g3-20020a056512118300b0049462af8614sm1637774lfr.145.2022.11.28.00.47.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:47:24 -0800 (PST) Message-ID: Date: Mon, 28 Nov 2022 09:47:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller Content-Language: en-US To: Icenowy Zheng , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Greg Kroah-Hartman , Matthias Kaehlcke , Andre Przywara Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20221127073140.2093897-1-uwu@icenowy.me> <20221127073140.2093897-3-uwu@icenowy.me> From: Krzysztof Kozlowski In-Reply-To: <20221127073140.2093897-3-uwu@icenowy.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/11/2022 08:31, Icenowy Zheng wrote: > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that > features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can > be bypassed) and an external reset pin. Subject: drop second, redundant "binding for". Few nits below. > > Add a device tree binding for its USB protocol part. The internal LDO is > not covered by this and can just be modelled as a fixed regulator. > > Signed-off-by: Icenowy Zheng > --- > .../bindings/usb/genesys,gl850g.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > new file mode 100644 > index 000000000000..d1fe539db399 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/realtek,rts5411.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Genesys Logic GL850G USB 2.0 hub controller > + > +maintainers: > + - Icenowy Zheng > + > +allOf: > + - $ref: usb-device.yaml# > + > +properties: > + compatible: > + items: Drop items, you have only one item. > + - enum: > + - usb5e3,608 > + > + reg: true > + > + reset-gpios: > + description: GPIO specifier for GRST# pin. Drop "GPIO specifier for", so just "GRST# pin". No need to describe DeviceTree syntax. > + > + vdd-supply: > + description: > + phandle to the regulator that provides power to the hub. Also drop "phandle to" > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + usb { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub: hub@1 { > + compatible = "usb5e3,608"; > + reg = <1>; > + reset-gpios = <&pio 7 2 GPIO_ACTIVE_LOW>; Missing header. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + }; > + }; Best regards, Krzysztof