Re: [PATCH 1/2] dt-bindings: iio: max30100: Add pulse-width property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 04/10/2025 10:56, Shrikant Raskar wrote:
> The MAX30100 sensor supports multiple LED pulse widths (200us, 400us,
> 800us, 1600us). These settings affect measurement resolution and power
> consumption. Until now, the driver always defaulted to 1600us.
> 
> Introduce a new device tree property `maxim,pulse-width` that allows
> users to select the desired pulse width in microseconds from device
> tree.
> 
> Valid values are: 200, 400, 800, 1600.

Don't describe the contents of patch. We see the contents from the diff.
Above two paragraphs are completely redundant, drop.

> 
> This prepares for driver changes that read this property and configure
> the SPO2 register accordingly.

Drop, redundant. Not really relevant.

> 
> Signed-off-by: Shrikant Raskar <raskar.shree97@gmail.com>
> ---
>  .../devicetree/bindings/iio/health/maxim,max30100.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml
> index 967778fb0ce8..55aaf2ff919b 100644
> --- a/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml
> @@ -27,6 +27,11 @@ properties:
>        LED current whilst the engine is running. First indexed value is
>        the configuration for the RED LED, and second value is for the IR LED.
>  
> +  maxim,pulse-width:

You miss unit suffix and testing, most likely.

> +    maxItems: 1
> +    description: Pulse width in microseconds
> +    enum: [200, 400, 800, 1600]x


Best regards,
Krzysztof