From: "Xu, Baojun" <baojun.xu@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Yi, Ken" <k-yi@ti.com>, "Lo, Henry" <henry.lo@ti.com>,
"Chen, Robin" <robinchen@ti.com>, "Wang, Will" <will-wang@ti.com>,
"jim.shil@goertek.com" <jim.shil@goertek.com>,
"toastcheng@google.com" <toastcheng@google.com>,
"chinkaiting@google.com" <chinkaiting@google.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support
Date: Mon, 2 Mar 2026 08:24:06 +0000 [thread overview]
Message-ID: <a7316acf9ba248f9ad1fab0313a95654@ti.com> (raw)
In-Reply-To: <63b0f42e-56e8-474f-8805-4e01bb2f189e@kernel.org>
>
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 February 2026 18:46
> To: Xu, Baojun
> Cc: broonie@kernel.org; tiwai@suse.de; andriy.shevchenko@linux.intel.com; 13916275206@139.com; Ding, Shenghao; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Yi, Ken; Lo, Henry; Chen, Robin; Wang, Will; jim.shil@goertek.com; toastcheng@google.com; chinkaiting@google.com
> Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support
>
> On 27/02/2026 11:40, Xu, Baojun wrote:
> >
> > ________________________________________
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 27 February 2026 18:34
> >> To: Xu, Baojun
> >> Cc: broonie@kernel.org; tiwai@suse.de; andriy.shevchenko@linux.intel.com; 13916275206@139.com; Ding, Shenghao; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Yi, Ken; Lo, Henry; Chen, Robin; Wang, Will; jim.shil@goertek.com; toastcheng@google.com; chinkaiting@google.com
> >> Subject: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support
> >>
> >>> MODULE_DEVICE_TABLE(i2c, tasdevice_id);
> >>> @@ -144,6 +145,7 @@ static const struct of_device_id tasdevice_of_match[] = {
> >>> { .compatible = "ti,tas5827" },
> >>> { .compatible = "ti,tas5828" },
> >>> { .compatible = "ti,tas5830" },
> >>> + { .compatible = "ti,tas5832" },
> >>
> >> So it is fully compatible with tas5830 and most of the changes here are
> >> not needed?
> >
> > Yes, it's fully compatible with tas5827/28/30.
>
> Then above hunk and many others are not needed.
Hi, because those chips have different on the voltage, so the parameters
is different, have to use different firmware binary, so we must identify
every chip in the driver.
>
> Best regards,
> Krzysztof
>
>
Best Regards
Jim
next prev parent reply other threads:[~2026-03-02 8:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 7:57 [PATCH v1 1/2] ASoC: dt-bindings: ti,tas2781: Add TAS5832 support Baojun Xu
2026-02-26 7:57 ` [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support Baojun Xu
2026-02-27 10:34 ` Krzysztof Kozlowski
2026-02-27 10:40 ` [EXTERNAL] " Xu, Baojun
2026-02-27 10:46 ` Krzysztof Kozlowski
2026-03-02 8:24 ` Xu, Baojun [this message]
2026-03-02 8:58 ` Krzysztof Kozlowski
2026-03-02 9:22 ` Xu, Baojun
2026-03-02 9:27 ` Krzysztof Kozlowski
2026-03-02 9:37 ` Xu, Baojun
2026-03-02 10:07 ` Krzysztof Kozlowski
2026-03-02 9:44 ` andriy.shevchenko
2026-03-02 10:09 ` Krzysztof Kozlowski
2026-03-06 10:08 ` Ding, Shenghao
2026-03-06 10:41 ` Krzysztof Kozlowski
2026-03-17 6:05 ` Ding, Shenghao
2026-03-17 7:06 ` Krzysztof Kozlowski
2026-03-26 2:24 ` Ding, Shenghao
2026-02-27 10:35 ` [PATCH v1 1/2] ASoC: dt-bindings: ti,tas2781: Add TAS5832 support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7316acf9ba248f9ad1fab0313a95654@ti.com \
--to=baojun.xu@ti.com \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=chinkaiting@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henry.lo@ti.com \
--cc=jim.shil@goertek.com \
--cc=k-yi@ti.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=toastcheng@google.com \
--cc=will-wang@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox