Re: [PATCH 1/2] dt-bindings: add media/cec.txt

[Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]

On 06/09/2017 07:54 PM, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
> 
> Document common HDMI CEC bindings. Add this to the MAINTAINERS file
> as well.
> 
> Signed-off-by: Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>

Acked-by: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

> ---
>   Documentation/devicetree/bindings/media/cec.txt | 8 ++++++++
>   MAINTAINERS                                     | 1 +
>   2 files changed, 9 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/cec.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/cec.txt b/Documentation/devicetree/bindings/media/cec.txt
> new file mode 100644
> index 000000000000..22d7aae3d3d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/cec.txt
> @@ -0,0 +1,8 @@
> +Common bindings for HDMI CEC adapters
> +
> +- hdmi-phandle: phandle to the HDMI controller.

For a common property I would rather make it "hdmi-controller", this
"-phandle" part feels like appending "_pointer" to variable names in C code.
But since you are just rearranging existing documentation and Rob agrees with
that I have no objections.

> +- needs-hpd: if present the CEC support is only available when the HPD
> +  is high. Some boards only let the CEC pin through if the HPD is high,
> +  for example if there is a level converter that uses the HPD to power
> +  up or down.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 053c3bdd1fe5..4ac340d189a3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3137,6 +3137,7 @@ F:	include/media/cec.h
>   F:	include/media/cec-notifier.h
>   F:	include/uapi/linux/cec.h
>   F:	include/uapi/linux/cec-funcs.h
> +F:	Documentation/devicetree/bindings/media/cec.txt
>   
>   CELL BROADBAND ENGINE ARCHITECTURE
>   M:	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html