From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v6 00/12] Unregister critical branch clocks + some RPM
Date: Mon, 15 Jan 2024 10:29:07 +0100 [thread overview]
Message-ID: <a78cf494-2a01-48d9-bc82-dfa6058f077e@linaro.org> (raw)
In-Reply-To: <CAA8EJppjxT=qri+bhfa=DbX09aCiFVp0vO3P0OD=TNiYJAd1-g@mail.gmail.com>
On 14.01.2024 05:53, Dmitry Baryshkov wrote:
> On Sat, 13 Jan 2024 at 16:51, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On Qualcomm SoCs, certain branch clocks either need to be always-on, or
>> should be if you're interested in touching some part of the hardware.
>>
>> Using CLK_IS_CRITICAL for this purpose sounds like a genius idea,
>> however that messes with the runtime pm handling - if a clock is
>> marked as such, the clock controller device will never enter the
>> "suspended" state, leaving the associated resources online, which in
>> turn breaks SoC-wide suspend.
>>
>> This series aims to solve that on a couple SoCs that I could test the
>> changes on and it sprinkles some runtime pm enablement atop these drivers.
>
> Probably it is out of scope for this
> I wonder if it makes sense to route (some) of the clocks properly.
> Should we use GCC_foo_SLEEEP_CLK as a sleep clock for the
> corresponding device?
> I'm not sure about the AHB and XO clocks.
>
> Another question is regarding the suspended state. Wouldn't leaving
> GCC_foo_XO clocks enabled keep the XO enabled as well?
Doesn't seem to be the case
Konrad
next prev parent reply other threads:[~2024-01-15 9:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 14:50 [PATCH v6 00/12] Unregister critical branch clocks + some RPM Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 01/12] clk: qcom: branch: Add a helper for setting the enable bit Konrad Dybcio
2024-01-13 21:18 ` Dmitry Baryshkov
2024-01-23 9:33 ` Imran Shaik
2024-01-24 11:20 ` Dmitry Baryshkov
2024-01-13 14:50 ` [PATCH v6 02/12] clk: qcom: Use qcom_branch_set_clk_en() Konrad Dybcio
2024-01-13 22:13 ` Dmitry Baryshkov
2024-01-13 14:50 ` [PATCH v6 03/12] clk: qcom: gcc-sm6375: Unregister critical clocks Konrad Dybcio
2024-01-16 11:09 ` Johan Hovold
2024-01-13 14:50 ` [PATCH v6 04/12] clk: qcom: gpucc-sm6375: " Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 05/12] clk: qcom: gpucc-sm6115: " Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 06/12] clk: qcom: gpucc-sm6115: Add runtime PM Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 07/12] clk: qcom: gcc-sm6115: Unregister critical clocks Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 08/12] clk: qcom: gcc-qcm2290: " Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 09/12] arm64: dts: qcom: sm6375: Add VDD_CX to GCC Konrad Dybcio
2024-01-13 14:50 ` [PATCH v6 10/12] arm64: dts: qcom: qcm2290: " Konrad Dybcio
2024-01-13 14:51 ` [PATCH v6 11/12] arm64: dts: qcom: sm6115: " Konrad Dybcio
2024-01-13 14:51 ` [PATCH v6 12/12] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CC Konrad Dybcio
2024-01-14 4:53 ` [PATCH v6 00/12] Unregister critical branch clocks + some RPM Dmitry Baryshkov
2024-01-15 9:29 ` Konrad Dybcio [this message]
2024-01-24 7:41 ` Abel Vesa
2024-01-24 12:31 ` Konrad Dybcio
2024-01-25 10:16 ` Taniya Das
2024-01-25 10:56 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78cf494-2a01-48d9-bc82-dfa6058f077e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).