From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973181.qiye.163.com (mail-m1973181.qiye.163.com [220.197.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306E31A683F; Mon, 18 May 2026 02:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779072304; cv=none; b=J05xJrZjsHlOksA3mzGmpHrzTooYnBzDPvaLlR9FpOkwV4wHOMle4O0PCMrp3hBm1PzO03+IOLgW5WgMkcXUm23ouo+Ce/WhqOZwgScCdj+xeybNTelGNbaynGqZG7WKdkUCh64SdfWkk9tS5c+u1qNerqTlx9gnPjk1xzITjCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779072304; c=relaxed/simple; bh=vcZ+4+FTq7/07QzwMX3qZnmIkZmq12mHXi3yO4rChZ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K5zAIX7LkZESRpW1iW+95szoPSgACKNdAvcr5qy08TBRZY9Ac9ytD6BxKINrk2H85BE8UghyNTuzLrooSNkEBKHItBQkaX1q8i20nR8liA8NfYhk+qo5sOp716J2g4M4sW653uTOLmwZaNHqvvlBqEFV1S3nKpSFewAY4wyXZss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=FwLaaBmh; arc=none smtp.client-ip=220.197.31.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="FwLaaBmh" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 3ec15c82d; Mon, 18 May 2026 10:44:29 +0800 (GMT+08:00) Message-ID: Date: Mon, 18 May 2026 10:44:29 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] dt-bindings: display: rockchip: analogix-dp: Expose inherited properties To: Conor Dooley Cc: Conor Dooley , hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, nicolas.frattaroli@collabora.com, cristian.ciocaltea@collabora.com, sebastian.reichel@collabora.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, dianders@chromium.org, m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260514070133.2275069-1-damon.ding@rock-chips.com> <20260514070133.2275069-2-damon.ding@rock-chips.com> <20260514-upstate-sneer-0b6e78682798@spud> <2f653664-27e9-4632-97e9-8b59cf7e585e@rock-chips.com> <20260515-confess-hungrily-4f64ce0d8de2@wendy> Content-Language: en-US From: Damon Ding In-Reply-To: <20260515-confess-hungrily-4f64ce0d8de2@wendy> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9e38f87b4603a3kunm9c63833a220204 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1kYFggdWUFKV1ktWUFJV1kPCRoVCBIfWUFZQk1DSlZISUJPHkwfS0 pMH0JWFRQJFhoXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0 tIVUpLSEpKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=FwLaaBmhRyX/1x2IvWIC8qOmg34/xaCXClSHSdAJaEUcRSf5nX3SBXOZhMb994CUmRYQeSsjZ6y0NOI6bU0UW1xVnMC9WLJxklcjrM2drB63dzkXrU7kaLlmYkFEXYIvDYF0lijlkN3eymJS+Yf77EsmSG7sshWzf/Qm15GFjng=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=mmp02j+JTh/LSA7GCH0kahZIKzpGQLcvXOXcVOAsbFw=; h=date:mime-version:subject:message-id:from; Hi Conor, On 5/15/2026 5:04 PM, Conor Dooley wrote: > On Fri, May 15, 2026 at 11:57:58AM +0800, Damon Ding wrote: >> Hi Conor, >> >> On 5/15/2026 2:16 AM, Conor Dooley wrote: >>> On Thu, May 14, 2026 at 03:01:31PM +0800, Damon Ding wrote: >>>> Expose the inherited properties from the base analogix-dp schema >>>> to satisfy unevaluatedProperties constraints. >>>> >>>> Signed-off-by: Damon Ding >>> >>> Given it's unevaluatedProperties, not addtionalProperties, this patch >>> shouldn't be needed? >>> >> >> When I remove both the top-level data-lanes property and those explicit >> "xxx: true" property entries and run the dtbs check with: >> >> make CHECK_DTBS=y CROSS_COMPILE=aarch64-linux-gnu- LT0=none LLVM=1 >> LLVM_IAS=1 ARCH=arm64 rockchip/rk3588-evb1-v10.dtb >> rockchip/rk3588s-evb1-v10.dtb rockchip/rk3399-sapphire-excavator.dtb >> rockchip/rk3576-evb1-v10.dtb -j4 >> >> It results in validation errors like these: >> >> /home/ding/drm-misc/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: >> edp@27dc0000: ports:port@1:endpoint: Unevaluated properties are not allowed >> ('data-lanes' was unexpected) >> from schema $id: >> http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# >> /home/ding/drm-misc/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: >> edp@27dc0000: Unevaluated properties are not allowed ('force-hpd', >> 'interrupts', 'phy-names', 'phys', 'ports', 'reg' were unexpected) >> from schema $id: >> http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# >> >> I suspect that the properties defined in the child binding are >> overriding/masking all the inherited properties from the parent Analogix DP >> schema. >> >> Is there a better way to fix this issue without explicitly listing all >> inherited properties as true? > > The example in this file uses most of the properties that you mention > above: > dp@ff970000 { > compatible = "rockchip,rk3288-dp"; > reg = <0xff970000 0x4000>; > interrupts = ; > clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>; > clock-names = "dp", "pclk"; > phys = <&dp_phy>; > phy-names = "dp"; > resets = <&cru 111>; > reset-names = "dp"; > rockchip,grf = <&grf>; > pinctrl-0 = <&edp_hpd>; > pinctrl-names = "default"; > > dt_binding_check reports no problems with this node, so I think the > problem might lie elsewhere? > There's no edp node in the dts you mention above, so this looks like an > interaction with something that's not yet upstream. Ah, I see. I did add extra changes to the edp node on my local rk3576-evb1 board DTS, which indeed caused this 'asymmetric information' issue and made the validation fail incorrectly. I will try adding the data-lanes property to the example in the binding document to ensure dt_binding_check passes cleanly. > > If this is required for the rk3576 edp, then you should include this > patch in the rk3576 edp support series rather than this one anyway where > it can actually be evaluated alongside the node it apparently causes > problems with. The data-lanes property is actually applicable and useful for all Rockchip eDP platforms, not just rk3576. In the next version, I will modify the series to better separate this common data-lanes change from the rk3576 specific eDP support patches. > > pw-bot: changes-requested > >> >> Best regards, >> Damon >> >>>> --- >>>> .../bindings/display/rockchip/rockchip,analogix-dp.yaml | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >>>> index bb75d898a5c5..896ded87880f 100644 >>>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >>>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >>>> @@ -50,6 +50,13 @@ properties: >>>> aux-bus: >>>> $ref: /schemas/display/dp-aux-bus.yaml# >>>> + reg: true >>>> + interrupts: true >>>> + phys: true >>>> + phy-names: true >>>> + force-hpd: true >>>> + ports: true >>>> + >>>> required: >>>> - compatible >>>> - clocks >>>> -- >>>> 2.34.1 >>>> >>>> >> Best regards, Damon