From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: renesas: add R8A779G0 V4H
Date: Thu, 26 Jan 2023 11:08:27 +0100 [thread overview]
Message-ID: <a7b9d4b9-892d-a131-a223-c286efdc9b9c@linaro.org> (raw)
In-Reply-To: <87zga6t5r4.wl-kuninori.morimoto.gx@renesas.com>
On 26/01/2023 02:59, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
There is stray blank line before your "From".
>
> Document R-Car V4H (R8A779G0), and R-Car Gen4 SoC bindings.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> .../devicetree/bindings/sound/renesas,rsnd.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 679a246dd666..5319abdda8a2 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -49,12 +49,21 @@ properties:
> - renesas,rcar_sound-r8a77995 # R-Car D3
> - enum:
> - renesas,rcar_sound-gen3
> +
> + # for Gen4 SoC
> + - items:
> + - enum:
> + - renesas,rcar_sound-r8a779g0 # R-Car V4H
> + - enum:
> + - renesas,rcar_sound-gen4
This is not enum but const. I send a fix for the rest, please rebase on
top of it.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-01-26 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 1:59 [PATCH] ASoC: dt-bindings: renesas: add R8A779G0 V4H Kuninori Morimoto
2023-01-26 10:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b9d4b9-892d-a131-a223-c286efdc9b9c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).