From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC98AC77B61 for ; Tue, 25 Apr 2023 07:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232222AbjDYH5w (ORCPT ); Tue, 25 Apr 2023 03:57:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjDYH5v (ORCPT ); Tue, 25 Apr 2023 03:57:51 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0DFD5247; Tue, 25 Apr 2023 00:57:38 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 9B8A17F8E; Tue, 25 Apr 2023 15:57:26 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 25 Apr 2023 15:57:26 +0800 Received: from [192.168.125.106] (113.72.145.137) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 25 Apr 2023 15:57:25 +0800 Message-ID: Date: Tue, 25 Apr 2023 15:57:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Conor Dooley CC: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <20230419035646.43702-1-changhuang.liang@starfivetech.com> <20230419035646.43702-2-changhuang.liang@starfivetech.com> <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> From: Changhuang Liang In-Reply-To: <20230425-unquote-eligible-09f743d81981@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.137] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org >>>>>> >>>>>> description: | >>>>>> StarFive JH7110 SoC includes support for multiple power domains which can be >>>>>> @@ -17,6 +18,7 @@ properties: >>>>>> compatible: >>>>>> enum: >>>>>> - starfive,jh7110-pmu >>>>>> + - starfive,jh7110-aon-pmu >>> >>> I was speaking to Rob about this over the weekend, he asked: >>> 'Why isn't "starfive,jh7110-aon-syscon" just the power-domain provider >>> itself?' >> >> Maybe not, this syscon only offset "0x00" configure power switch. >> other offset configure other functions, maybe not power, so this >> "starfive,jh7110-aon-syscon" not the power-domain itself. >> >>> Do we actually need to add a new binding for this at all? >>> >>> Cheers, >>> Conor. >>> >> >> Maybe this patch do that. >> https://lore.kernel.org/all/20230414024157.53203-6-xingyu.wu@starfivetech.com/ > > This makes it a child-node right? I think Rob already said no to that in > and earlier revision of this series. What he meant the other day was > making the syscon itself a power domain controller, since the child node > has no meaningful properties (reg, interrupts etc). > > Cheers, > Conor. Yes, "starfive,jh7110-aon-pmu" is a child-node of "starfive,jh7110-aon-syscon". In my opinion, "0x17010000" is "aon-syscon" on JH7110 SoC, and this "aon-pmu" is just a part of "aon-syscon" function, so I think it is inappropriate to make "aon-syscon" to a power domain controller. I think using the child-node description is closer to JH7110 SoC.