From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1231317B505 for ; Thu, 7 May 2026 04:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127160; cv=none; b=jN+5KqKvkEdrSPHf+hxqM/BCmGmeng44JTY9WKwWBPJH1egYtPP1m5pLx91yla9/VarBT0Qi9/KICDVW8Ey82wH92fqvq99WqWmwpNLrVRFR0tv3ixFoAZwtiL49PAqR4qcwJ4iiknEDAZ6UVudkROLPRdxmE7XZfH2SMbIzE9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127160; c=relaxed/simple; bh=ksNZwP1dJGNhhXlR7TirkycPIhvvbe9kAdiewChEkao=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OCYs8r7cbWj94VAT2RvfP/ldIipTLYfz/3ZG00EAK2jDKCIIRV7djbrWtE7OkxRs3qg3LmBACzKrC5Ajf21st2ZDw/vBj0kDPZEfM13gstcwoQ/5Nf9p2Sg+nAm4o+HYu8fKc+HBsLZalGsTRv0ksQil6Kpa2dIK8KQIMgS1NAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=q-lab.dev; spf=pass smtp.mailfrom=q-lab.dev; dkim=pass (2048-bit key) header.d=q-lab.dev header.i=@q-lab.dev header.b=KIUb2vCd; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b=YVWbcMRh; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=q-lab.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=q-lab.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=q-lab.dev header.i=@q-lab.dev header.b="KIUb2vCd"; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b="YVWbcMRh" DKIM-Signature: a=rsa-sha256; b=KIUb2vCd7oLJkTnwKjVpfxsqACnG5qWwCFRu8/Hdn9tcHiAzpvp4I3CzW2C6T7jj/x5v6hDN6GZ19wXtoSFuTiE41/iwIt45npDeybbGwyr6dbjX8IZtFQ4CekZFLU2HK7DC5t+7bGx4H+jC3DSIR9bUdwzESokOFrb9+sez5GEsk1SCRC9ul+WS6fL8qgH8SiWBKGf6KWCa4d34J0iJlLtYMJHdg2tX27p6LB0p7AuJOj9k9W16Go49DFIXU9nbRprJJMDPjgMzBPoY58yYKMHgGlMmZypkDHwu4JXce4R0pU1KjXOEfIFpVQMjMWVt3M/JIft1wY7sOjon7mkB4Q==; s=purelymail1; d=q-lab.dev; v=1; bh=ksNZwP1dJGNhhXlR7TirkycPIhvvbe9kAdiewChEkao=; h=Received:Date:Subject:To:From; DKIM-Signature: a=rsa-sha256; b=YVWbcMRhzyTa0/9I96YebYulkD5VwA6XjP7FDbQJ8cL1XDkqBPs3LfgFg0tIP0KZ1RjHhr9K//6cqAmS6s0J8XyDijo2IilIPDKabvfMHWC9B8QA7MaS+wFHrI7IJB9+Ew1ixinDGWcYJyMAYbzOhjb8dLs8KL0pLLndQSawN0oht9fX9tqvb0PC9lycXAaqvfVTU/jjXE706IgH52GUurc0WqJlOhhRBXfamfPu8EVq13AlUZsYxPQA1xeDEKaQjkdRBISwDDfvUfwHmaQUJ0DarRwcmATPm3m81l2V/HeEl8T0UgwIteBhX982DpipSE0hEBRuIWqLN4Lcbe+fMg==; s=purelymail1; d=purelymail.com; v=1; bh=ksNZwP1dJGNhhXlR7TirkycPIhvvbe9kAdiewChEkao=; h=Feedback-ID:Received:Date:Subject:To:From; Feedback-ID: 284201:25281:null:purelymail X-Pm-Original-To: devicetree@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -578679034; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 07 May 2026 04:12:22 +0000 (UTC) Message-ID: Date: Wed, 6 May 2026 21:12:20 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 2/2] media: i2c: Add onsemi AR0234 image sensor driver To: Alexander Shiyan , linux-media@vger.kernel.org Cc: Isaac Scott , Dave Stevenson , Dongcheng Yan , devicetree@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , Hans Verkuil , Hans de Goede , Vladimir Zapolskiy , Mehdi Djait , Laurent Pinchart , Benjamin Mugnier , Bryan O'Donoghue , Jingjing Xiong , Svyatoslav Ryhel References: <20260306103614.3208182-1-eagle.alexander923@gmail.com> <20260306103614.3208182-3-eagle.alexander923@gmail.com> Content-Language: en-US From: Quentin Freimanis In-Reply-To: <20260306103614.3208182-3-eagle.alexander923@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/26 2:36 AM, Alexander Shiyan wrote: > + > +static int ar0234_set_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct ar0234 *ar0234 = container_of(ctrl->handler, > + struct ar0234, ctrls); > + int ret = 0; > + > + if (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY) > + return 0; > + > + if (ctrl->id == V4L2_CID_VBLANK) { > + int exposure_max = ar0234->crop.height + ctrl->val - 1; > + int exposure_val = clamp(ar0234->exposure->val, > + AR0234_EXPOSURE_MIN, exposure_max); > + > + ret = __v4l2_ctrl_modify_range(ar0234->exposure, > + AR0234_EXPOSURE_MIN, > + exposure_max, > + AR0234_EXPOSURE_STEP, > + exposure_val); > + if (ret) > + return ret; > + } > + > + if (pm_runtime_get_if_in_use(ar0234->dev) == 0) > + return 0; > + > + switch (ctrl->id) { > + case V4L2_CID_HBLANK: > + cci_write(ar0234->regmap, AR0234_REG_LINE_LENGTH_PCK, > + (ar0234->crop.width / 4) + ctrl->val, &ret); should be (crop->width + ctrl->val) / 4, &ret) to keep the control in units of pixels > + break; > + case V4L2_CID_VBLANK: > + cci_write(ar0234->regmap, AR0234_REG_FRAME_LENGTH_LINES, > + ar0234->crop.height + ctrl->val, &ret); REG_FRAME_LENGTH_LINES seems to actually be total lines - 5 I had to make these 2 changes to be able to get the expected framerate when not using the default 120fps. > + if (ret) > + break; > + ctrl = ar0234->exposure; > + fallthrough; > + case V4L2_CID_EXPOSURE: > + cci_write(ar0234->regmap, AR0234_REG_COARSE_INTEGRATION_TIME, > + ctrl->val, &ret); > + break; > + case V4L2_CID_ANALOGUE_GAIN: > + ret = ar0234_set_analog_gain(ar0234, ctrl->val); > + break; > + case V4L2_CID_DIGITAL_GAIN: > + cci_write(ar0234->regmap, AR0234_REG_GLOBAL_GAIN, > + ctrl->val, &ret); > + break; - Quentin