From: Nick Chan <towinchenmi@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mark Kettenis <kettenis@openbsd.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH v3 18/20] arm64: dts: apple: Add A10X devices
Date: Mon, 16 Sep 2024 22:52:15 +0800 [thread overview]
Message-ID: <a7f2c1fd-bd50-4d04-a2da-67bda6f7d55c@gmail.com> (raw)
In-Reply-To: <ntl53bla2qwueycbffta5ytmmm7hxrthbfz2677mltldgu6roi@3f3pz6644vb5>
On 16/9/2024 22:39, Krzysztof Kozlowski wrote:
> On Sun, Sep 15, 2024 at 03:59:03PM +0800, Nick Chan wrote:
>> From: Konrad Dybcio <konradybcio@kernel.org>
>>
>> Add DTS files for the A10X SoC and the following devices based on it:
>>
>> - Apple TV 4K
>> - iPad Pro (2nd Generation) (10.5 Inch)
>> - iPad Pro (2nd Generation) (12.9 Inch)
>>
>> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org>
>> [Nick: SMP, m1n1 and Apple TV 4K support, uart interrupt and pinctrl fixes]
>> Co-developed-by: Nick Chan <towinchenmi@gmail.com>
>> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
>> ---
>> .../devicetree/bindings/arm/apple.yaml | 8 +-
>
> You need to split bindings.
Good catch. The bindings part needs to be squashed into the commit
adding the
bindings. This is a miscommited style fix up to not mention "Apple" when
we are
already in Apple ARM Machine bindings, unless it is part of the offical name
(like Apple TV).
>
> Best regards,
> Krzysztof
>
Nick Chan
next prev parent reply other threads:[~2024-09-16 14:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 7:58 [PATCH v3 00/20] Initial device trees for A7-A11 based Apple devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 01/20] dt-bindings: arm: cpus: Add Apple A7-A11 CPU cores Nick Chan
2024-09-16 14:34 ` Krzysztof Kozlowski
2024-09-16 14:47 ` Nick Chan
2024-09-16 19:49 ` Krzysztof Kozlowski
2024-09-15 7:58 ` [PATCH v3 02/20] dt-bindings: watchdog: apple,wdt: Add A7-A11 compatibles Nick Chan
2024-09-15 7:58 ` [PATCH v3 03/20] dt-bindings: pinctrl: apple,pinctrl: " Nick Chan
2024-09-15 7:58 ` [PATCH v3 04/20] dt-bindings: arm: apple: Add A7 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 05/20] dt-bindings: arm: apple: Add A8 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 06/20] dt-bindings: arm: apple: Add A8X devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 07/20] dt-bindings: arm: apple: Add A9 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 08/20] dt-bindings: arm: apple: Add A9X devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 09/20] dt-bindings: arm: apple: Add A10 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 10/20] dt-bindings: arm: apple: Add A10X devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 11/20] dt-bindings: arm: apple: Add A11 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 12/20] arm64: dts: apple: Add A7 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 13/20] arm64: dts: apple: Add A8 devices Nick Chan
2024-09-15 7:58 ` [PATCH v3 14/20] arm64: dts: apple: Add A8X devices Nick Chan
2024-09-15 7:59 ` [PATCH v3 15/20] arm64: dts: apple: Add A9 devices Nick Chan
2024-09-15 7:59 ` [PATCH v3 16/20] arm64: dts: apple: Add A9X devices Nick Chan
2024-09-15 7:59 ` [PATCH v3 17/20] arm64: dts: apple: Add A10 devices Nick Chan
2024-09-15 7:59 ` [PATCH v3 18/20] arm64: dts: apple: Add A10X devices Nick Chan
2024-09-16 14:39 ` Krzysztof Kozlowski
2024-09-16 14:52 ` Nick Chan [this message]
2024-09-15 7:59 ` [PATCH v3 19/20] arm64: dts: apple: Add A11 devices Nick Chan
2024-09-15 7:59 ` [PATCH v3 20/20] arm64: Kconfig: Update help text for CONFIG_ARCH_APPLE Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7f2c1fd-bd50-4d04-a2da-67bda6f7d55c@gmail.com \
--to=towinchenmi@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=kettenis@openbsd.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpieralisi@kernel.org \
--cc=marcan@marcan.st \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).