[PATCH v2] dt-bindings: mfd: twl: Reference converted schemas for subnodes

[PATCH v2] dt-bindings: mfd: twl: Reference converted schemas for subnodes

[Jihed Chaibi]

Now that all TWL subnode bindings (audio, keypad, twl4030-usb, gpio,
usb-comparator) have been converted and merged into mainline, update the
parent ti,twl.yaml to properly reference them via $ref.

Replace the inline compatible definitions with $ref to the appropriate
schemas and unevaluatedProperties: false, matching the pattern already
used by the madc, gpadc, and charger subnodes.

Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
Changes in v2:
- Drop "YAML" from subject and commit message
- Remove incorrect claim that subnode properties were not being validated

 .../devicetree/bindings/mfd/ti,twl.yaml       | 50 ++++---------------
 1 file changed, 10 insertions(+), 40 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
index 9cc3e4721612..a3af8e717ec7 100644
--- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
@@ -265,47 +265,23 @@ properties:

   audio:
     type: object
-    additionalProperties: true
-
-    properties:
-      compatible:
-        const: ti,twl4030-audio
-
-    required:
-      - compatible
+    $ref: /schemas/sound/ti,twl4030-audio.yaml
+    unevaluatedProperties: false

   keypad:
     type: object
-    additionalProperties: true
-
-    properties:
-      compatible:
-        const: ti,twl4030-keypad
-
-    required:
-      - compatible
+    $ref: /schemas/input/ti,twl4030-keypad.yaml
+    unevaluatedProperties: false

   twl4030-usb:
     type: object
-    additionalProperties: true
-
-    properties:
-      compatible:
-        const: ti,twl4030-usb
-
-    required:
-      - compatible
+    $ref: /schemas/usb/ti,twl4030-usb.yaml
+    unevaluatedProperties: false

   gpio:
     type: object
-    additionalProperties: true
-
-    properties:
-      compatible:
-        const: ti,twl4030-gpio
-
-    required:
-      - compatible
+    $ref: /schemas/gpio/ti,twl4030-gpio.yaml
+    unevaluatedProperties: false

   power:
     type: object
@@ -371,14 +347,8 @@ properties:

   usb-comparator:
     type: object
-    additionalProperties: true
-
-    properties:
-      compatible:
-        const: ti,twl6030-usb
-
-    required:
-      - compatible
+    $ref: /schemas/usb/ti,twl6030-usb.yaml
+    unevaluatedProperties: false

   pwm:
     type: object
--
2.47.3

Re: [PATCH v2] dt-bindings: mfd: twl: Reference converted schemas for subnodes

[Krzysztof Kozlowski]

On 27/03/2026 09:23, Jihed Chaibi wrote:
> Now that all TWL subnode bindings (audio, keypad, twl4030-usb, gpio,
> usb-comparator) have been converted and merged into mainline, update the
> parent ti,twl.yaml to properly reference them via $ref.
> 
> Replace the inline compatible definitions with $ref to the appropriate
> schemas and unevaluatedProperties: false, matching the pattern already
> used by the madc, gpadc, and charger subnodes.

I told you: no.

Why do you replace correct code?

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: mfd: twl: Reference converted schemas for subnodes

[Jihed Chaibi]

On Wed, Apr 1, 2026 at 8:03 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> > Replace the inline compatible definitions with $ref to the appropriate
> > schemas and unevaluatedProperties: false, matching the pattern already
> > used by the madc, gpadc, and charger subnodes.
>
> I told you: no.
>
> Why do you replace correct code?
>
> Best regards,
> Krzysztof

Got it. Dropping this patch.
Best regards,