From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF8C2C4320A for ; Thu, 29 Jul 2021 11:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D871860F42 for ; Thu, 29 Jul 2021 11:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236674AbhG2LOp (ORCPT ); Thu, 29 Jul 2021 07:14:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236652AbhG2LOp (ORCPT ); Thu, 29 Jul 2021 07:14:45 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8321BC0613CF for ; Thu, 29 Jul 2021 04:14:42 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id w10so3640290qtj.3 for ; Thu, 29 Jul 2021 04:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2K9Otu8LW9SDTcXYYe2i+NmHsFiLd0L5gZwCfWSKEmo=; b=ph0P5vCb0OFIqgeqV14YecFS4sAcx7v1LDkjpxvpx7VtzA6H2FeZks2PCB2rjJKhRX kLhKCbXdc5goS+AdVlhEsnetACl2h0f5owIWTAEgmg3qAoX1BPI5qKBCgRzjYY3TWEE8 ap3iJH2pOO1jZIL5BP9xn84HJ5I+j1ydD2+a6LXoDIBVhZXOQcz3MEjsEvct+h/bm6xM gnplsF4FOoT8dTcNlnMELEExf92mE7CBje0LlNJKpk7+qZ+E6tNgyvh8V8ONZmyEUTpg se0Bpo7uSiruq79wFoz3MGg70+MQQOeWPjGdYhZi9vMdfMxab/ZcGI6L01PEAkZcQUwZ /9tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2K9Otu8LW9SDTcXYYe2i+NmHsFiLd0L5gZwCfWSKEmo=; b=KoYGOS03vwAVJyd6cktPVV1dyMso9x9D/myduz5KwB9kkZYFQeRtTsV0dZOXIa8t2J U31l7ez4Ish8qDqFg0hmqxXOj9tnZvHt3AwPw7LDgq+rBvDPP3fo2BBntvdK6II7gNxX g0dofJ22xCRdQIPBXP9SUnfNcdGsPXbVngN5jrzWiEn/poSggMIeI9cUC7rsF3cyaZnr jAiGdW7zj5Uxqlok0UGfEfGmVuWCURSp0HVvEsgF6UL/RxS0AUci8IBmhujAp42ajLBn peAdrZ3Fio9xfocgRZ4mUt955aY1izjNfrJPHDpMalTKPhQUE4A5m/DoZENFHYiiHcys NbPQ== X-Gm-Message-State: AOAM532xukM1eBVDpLQT1YGnRZ+5vXJ79YhBjR2su9KroF2cbCQGBXin NkwxX7vYw7h0gR/nfcJIMnigNQ== X-Google-Smtp-Source: ABdhPJwAn3IRMTD72AerbI9G7j4vBNcMivwHurVclQz1qrLLqObsXzzh3n/4sqCOpuRq/b1tT4J2LA== X-Received: by 2002:ac8:41c2:: with SMTP id o2mr3599898qtm.237.1627557281670; Thu, 29 Jul 2021 04:14:41 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id j127sm1596873qkf.20.2021.07.29.04.14.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 04:14:41 -0700 (PDT) Subject: Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node To: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Amit Kucheria , Zhang Rui , Daniel Lezcano , Rob Herring , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210728222542.54269-1-konrad.dybcio@somainline.org> <20210728222542.54269-15-konrad.dybcio@somainline.org> <860f1120-c5a4-f531-3ea9-aa90c6b063dc@linaro.org> <2318377c-959a-a42b-81b5-44e2629570d5@somainline.org> From: Thara Gopinath Message-ID: Date: Thu, 29 Jul 2021 07:14:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/29/21 6:55 AM, Konrad Dybcio wrote: > > On 29.07.2021 12:54, Thara Gopinath wrote: >> >> >> On 7/29/21 6:52 AM, Konrad Dybcio wrote: >>> >>> On 29.07.2021 12:50, Thara Gopinath wrote: >>>> Hi Konrad, >>>> >>>> On 7/28/21 6:25 PM, Konrad Dybcio wrote: >>>>> This will enable temperature reporting for various SoC >>>>> components. >>>>> >>>>> Signed-off-by: AngeloGioacchino Del Regno >>>>> Signed-off-by: Konrad Dybcio >>>>> --- >>>>>    .../devicetree/bindings/thermal/qcom-tsens.yaml       |  1 + >>>>>    arch/arm64/boot/dts/qcom/sdm630.dtsi                  | 11 +++++++++++ >>>>>    2 files changed, 12 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> @@ -48,6 +48,7 @@ properties: >>>>>                  - qcom,sc7180-tsens >>>>>                  - qcom,sc7280-tsens >>>>>                  - qcom,sc8180x-tsens >>>>> +              - qcom,sdm630-tsens >>>>>                  - qcom,sdm845-tsens >>>>>                  - qcom,sm8150-tsens >>>>>                  - qcom,sm8250-tsens >>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>> index 1e54828817d5..7e9c80e35fba 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>>> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >>>>>                     <&mmcc AHB_CLK_SRC>; >>>>>            }; >>>>>    +        tsens: thermal-sensor@10ae000 { >>>>> +            compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >>>>> +            reg = <0x010ae000 0x1000>, /* TM */ >>>>> +                  <0x010ad000 0x1000>; /* SROT */ >>>>> +            #qcom,sensors = <12>; >>>> >>>> Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. >>> >>> Hi, >>> >>> if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( >> >> Right. In that case, why not change #qcom,sensors to 9 and add rest of the sensors if and when needed ? >> > I don't think it makes sense to describe the hardware incorrectly, even if some of it is unused. My thinking was more along the lines of don't expose unused h/w bits. > > > -- Warm Regards Thara (She/Her/Hers)