* [PATCH v1] Coresight: Narrow down the matching range of tpdm
@ 2024-10-09 8:50 Songwei Chai
2024-10-09 8:54 ` Suzuki K Poulose
0 siblings, 1 reply; 3+ messages in thread
From: Songwei Chai @ 2024-10-09 8:50 UTC (permalink / raw)
To: Suzuki K Poulose, Mike Leach, James Clark, Alexander Shishkin,
Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Songwei Chai, linux-kernel, coresight, linux-arm-kernel,
linux-arm-msm, devicetree
The format of tpdm's peripheral id is 1f0exx. To avoid potential
conflicts in the future, update the .id_table's id to 0x001f0e00.
This update will narrow down the matching range and prevent incorrect
matches. For example, another component's peripheral id might be
f0e00, which would incorrectly match the old id.
Signed-off-by: Songwei Chai <quic_songchai@quicinc.com>
---
drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
index b7d99e91ab84..8e2985d17549 100644
--- a/drivers/hwtracing/coresight/coresight-tpdm.c
+++ b/drivers/hwtracing/coresight/coresight-tpdm.c
@@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev)
*/
static struct amba_id tpdm_ids[] = {
{
- .id = 0x000f0e00,
- .mask = 0x000fff00,
+ .id = 0x001f0e00,
+ .mask = 0x00ffff00,
},
{ 0, 0, NULL },
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Coresight: Narrow down the matching range of tpdm
2024-10-09 8:50 [PATCH v1] Coresight: Narrow down the matching range of tpdm Songwei Chai
@ 2024-10-09 8:54 ` Suzuki K Poulose
2024-10-09 9:20 ` songchai
0 siblings, 1 reply; 3+ messages in thread
From: Suzuki K Poulose @ 2024-10-09 8:54 UTC (permalink / raw)
To: Songwei Chai, Mike Leach, James Clark, Alexander Shishkin,
Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-kernel, coresight, linux-arm-kernel, linux-arm-msm,
devicetree
On 09/10/2024 09:50, Songwei Chai wrote:
> The format of tpdm's peripheral id is 1f0exx. To avoid potential
> conflicts in the future, update the .id_table's id to 0x001f0e00.
> This update will narrow down the matching range and prevent incorrect
> matches. For example, another component's peripheral id might be
> f0e00, which would incorrectly match the old id.
>
> Signed-off-by: Songwei Chai <quic_songchai@quicinc.com>
> ---
> drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
> index b7d99e91ab84..8e2985d17549 100644
> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev)
> */
> static struct amba_id tpdm_ids[] = {
> {
> - .id = 0x000f0e00,
> - .mask = 0x000fff00,
> + .id = 0x001f0e00,
> + .mask = 0x00ffff00,
> },
> { 0, 0, NULL },
> };
>
Please could you add "Fixes" tag for this ? You don't want an old kernel
detect something else as TPDM, so this must go to stable kernels.
Also, while at it, please could you intend the id and mask values with
tabs, so it is easier to what exactly we are matching ? e.g,
.id = 0x001f0e00,
.mask = 0x00ffff00,
Kind regards
Suzuki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Coresight: Narrow down the matching range of tpdm
2024-10-09 8:54 ` Suzuki K Poulose
@ 2024-10-09 9:20 ` songchai
0 siblings, 0 replies; 3+ messages in thread
From: songchai @ 2024-10-09 9:20 UTC (permalink / raw)
To: Suzuki K Poulose, Mike Leach, James Clark, Alexander Shishkin,
Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-kernel, coresight, linux-arm-kernel, linux-arm-msm,
devicetree
On 10/9/2024 4:54 PM, Suzuki K Poulose wrote:
> On 09/10/2024 09:50, Songwei Chai wrote:
>> The format of tpdm's peripheral id is 1f0exx. To avoid potential
>> conflicts in the future, update the .id_table's id to 0x001f0e00.
>> This update will narrow down the matching range and prevent incorrect
>> matches. For example, another component's peripheral id might be
>> f0e00, which would incorrectly match the old id.
>>
>> Signed-off-by: Songwei Chai <quic_songchai@quicinc.com>
>> ---
>> drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c
>> b/drivers/hwtracing/coresight/coresight-tpdm.c
>> index b7d99e91ab84..8e2985d17549 100644
>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
>> @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev)
>> */
>> static struct amba_id tpdm_ids[] = {
>> {
>> - .id = 0x000f0e00,
>> - .mask = 0x000fff00,
>> + .id = 0x001f0e00,
>> + .mask = 0x00ffff00,
>> },
>> { 0, 0, NULL },
>> };
>>
>
> Please could you add "Fixes" tag for this ? You don't want an old
> kernel detect something else as TPDM, so this must go to stable kernels.
> Also, while at it, please could you intend the id and mask values with
> tabs, so it is easier to what exactly we are matching ? e.g,
Thanks for your quick response, Suzuki.
Corrected it in the new version!
>
>
> .id = 0x001f0e00,
> .mask = 0x00ffff00,
>
> Kind regards
> Suzuki
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-09 8:50 [PATCH v1] Coresight: Narrow down the matching range of tpdm Songwei Chai
2024-10-09 8:54 ` Suzuki K Poulose
2024-10-09 9:20 ` songchai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).