From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4CF4D18DF81; Wed, 9 Oct 2024 08:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728464088; cv=none; b=CVWcye0hcKCkq9+wBQWwQyPWMeBFkyLa/VMcCbHMNUNuak9E3smvVn3AxCUCgIP3lLgRAap/PP0UhW/B4r0jLcjEExpVlQ6jYK7bww3eWoczZUVXOv8T7olCyVUJfF8s/uLrCO50ZpbH8N4LKryl+bKnn1ShGYbh1gdwb7jASC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728464088; c=relaxed/simple; bh=kTx1HT+m4F9ANgXU0SkEaOvA6/R2Zm4LE6P8bmqeMUw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ij3dSbF/z/y3CwsJotyKGW0huHdcC8YpiHiYaiUhCao0/s0SubLrU4j8uncFa6MoVAuwBvf+QxicCPkNHbamPxjNHlXnZeVzLR6Tq37UkBJ1pibVI5Qlwg3NDmm0bDNXgJUJM3yZ2Jwm67yA2OaiyUMpDn3m58019NCs+4gLGEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 301B1FEC; Wed, 9 Oct 2024 01:55:15 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC6773F64C; Wed, 9 Oct 2024 01:54:43 -0700 (PDT) Message-ID: Date: Wed, 9 Oct 2024 09:54:42 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Coresight: Narrow down the matching range of tpdm To: Songwei Chai , Mike Leach , James Clark , Alexander Shishkin , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20241009085042.1098-1-quic_songchai@quicinc.com> Content-Language: en-US From: Suzuki K Poulose In-Reply-To: <20241009085042.1098-1-quic_songchai@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/10/2024 09:50, Songwei Chai wrote: > The format of tpdm's peripheral id is 1f0exx. To avoid potential > conflicts in the future, update the .id_table's id to 0x001f0e00. > This update will narrow down the matching range and prevent incorrect > matches. For example, another component's peripheral id might be > f0e00, which would incorrectly match the old id. > > Signed-off-by: Songwei Chai > --- > drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c > index b7d99e91ab84..8e2985d17549 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.c > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c > @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev) > */ > static struct amba_id tpdm_ids[] = { > { > - .id = 0x000f0e00, > - .mask = 0x000fff00, > + .id = 0x001f0e00, > + .mask = 0x00ffff00, > }, > { 0, 0, NULL }, > }; > Please could you add "Fixes" tag for this ? You don't want an old kernel detect something else as TPDM, so this must go to stable kernels. Also, while at it, please could you intend the id and mask values with tabs, so it is easier to what exactly we are matching ? e.g, .id = 0x001f0e00, .mask = 0x00ffff00, Kind regards Suzuki