From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B982DC04A68 for ; Thu, 28 Jul 2022 11:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236005AbiG1Lmx (ORCPT ); Thu, 28 Jul 2022 07:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235603AbiG1Lmv (ORCPT ); Thu, 28 Jul 2022 07:42:51 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDF29F33 for ; Thu, 28 Jul 2022 04:42:50 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id q23so2457997lfr.3 for ; Thu, 28 Jul 2022 04:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZdeLo/HEqDcBsBJZCtTsZcIieSbE3G0c5YaVE49SxhM=; b=D/2g/QjrEK8fnbPdip0C4HLBdUCVf1+o0vuESGDzjqER7MbdY0B/Po3zAuvNBt1e10 WO9vbtKX1sn1Mu/grWuVAdCAk9DappVyhyBvldWRSQNsVYhYtRdhOIM0YQEwBPmKCuff Y7cSyaTCaGporSRlv5/Sy4MK8wgwiR8GV//hfP0+8em4n8ySU+AcxdUxUEj0ZheyLkhe nV5yFu32FsGqrNXaykZNMJMwAFl1ZmYVP1mVXadkm5gLrqL4OS4uskymswtd9GIMhzLP 2FtQcW0QmnwVl8wd6enixv3vQek9QkAlT1kBOIFtDdVX35ki7EJ8FCeT19d9rWUdid4K ZA+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZdeLo/HEqDcBsBJZCtTsZcIieSbE3G0c5YaVE49SxhM=; b=i1R3mt5rhUCTdQzfG4CiQS1q8lP3TJQV7Amwla2dcbbvoHYWu/FIOYaFvKaGF0E6Mh /OlOeDuWoA8pQgPAMg4YuKL3/Yq0Nnc50ut2aTQJqlLP8eurgnQ4ofFgSc2Uy4/huuze OhNcf8JuQGFmkTL45lTTQtE/Hpg/g7paUgX4Cm0DrAjC9BLuLxNtMTwYpRsOV6yzkf3V q/NJwzFOsKSzmGPNhIPo8fkjGqYJhZwmS0mfYCAEbMfKex0PMrNMLiXM3P1NZ1scutMs 44Ute6wltDZG7HIgc36VKQ2pk2pDtNTQcudJSqdyx2JC1ZivPfEet07YIvIapWyuT1LR TwLw== X-Gm-Message-State: AJIora+0oyb6eJEpQdequSiO9cC2O1S9lsxMEy7ImehSXM6u1gSm4vap YzVdIvfJWnMrwpIEUJuWCyp42Q== X-Google-Smtp-Source: AGRyM1vj/7RBruIhGdOeZdiOwv0g82Q6nua4rpfJQIzPlJvLjQrz3CgmbPncXFOcdWxaf2eze6H8Lg== X-Received: by 2002:ac2:5b1d:0:b0:48a:718b:d21d with SMTP id v29-20020ac25b1d000000b0048a718bd21dmr10235584lfn.488.1659008569059; Thu, 28 Jul 2022 04:42:49 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id t11-20020a056512208b00b0048a78c1fc1dsm162825lfr.111.2022.07.28.04.42.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 04:42:48 -0700 (PDT) Message-ID: Date: Thu, 28 Jul 2022 13:42:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] dt-bindings: spmi: add compatible for mt8188 Content-Language: en-US To: AngeloGioacchino Del Regno , Sen Chu , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Hsin-Hsiung Wang Cc: Hui Liu , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220726103729.24525-1-sen.chu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/07/2022 13:29, AngeloGioacchino Del Regno wrote: > Il 26/07/22 12:37, Sen Chu ha scritto: >> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform. >> >> Signed-off-by: Sen Chu >> Acked-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml >> index 2445c5e0b0ef..05801e0199f9 100644 >> --- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml >> +++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml >> @@ -20,6 +20,7 @@ properties: >> compatible: >> enum: >> - mediatek,mt6873-spmi >> + - mediatek,mt8188-spmi > > I think that you'll be adding a SPMI node that will have: > > compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi"; > > Which means that this is actually wrong, so, please fix it by > adding items... I wished bindings were not coming along but with DTS so we can check if submitter understands what he/she/they are coding... I also wished bindings in schema were used for testing their own DTBS without sending. Ehh.... :( Best regards, Krzysztof