From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org,
bhupesh.linux@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v5 2/5] dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support
Date: Wed, 17 May 2023 16:55:08 +0200 [thread overview]
Message-ID: <a82e553b-c21d-0955-be77-77028806b314@linaro.org> (raw)
In-Reply-To: <20230516213308.2432018-3-bhupesh.sharma@linaro.org>
On 16/05/2023 23:33, Bhupesh Sharma wrote:
> Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
>
> On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
> needs to be set first to 'enable' the eud module.
>
> So, update the dt-bindings to accommodate the third register
> + maxItems: 3
>
> interrupts:
> description: EUD interrupt
> @@ -52,6 +56,38 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
If there is going to be new version - put it before additionalProperties
above, just like in example-schema.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-17 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 21:33 [PATCH v5 0/5] Add Qualcomm SM6115 / SM4250 EUD dt-bindings & driver support Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 1/5] usb: misc: eud: Fix eud sysfs path (use 'qcom_eud') Bhupesh Sharma
2023-05-17 5:38 ` Manivannan Sadhasivam
2023-05-17 6:28 ` Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 2/5] dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support Bhupesh Sharma
2023-05-17 14:55 ` Krzysztof Kozlowski [this message]
2023-05-16 21:33 ` [PATCH v5 3/5] usb: misc: eud: Add driver support for SM6115 / SM4250 Bhupesh Sharma
2023-05-17 4:50 ` Greg KH
2023-05-17 6:33 ` Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 4/5] arm64: dts: qcom: sm6115: Add EUD dt node and dwc3 connector Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 5/5] arm64: dts: qcom: qrb4210-rb2: Enable EUD debug peripheral Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a82e553b-c21d-0955-be77-77028806b314@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).