devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Dinh Nguyen <dinguyen@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/9] ARM: dts: zynq-7000: drop useless 'dma-channels/requests' properties
Date: Mon, 2 May 2022 09:27:18 +0200	[thread overview]
Message-ID: <a838f962-354c-9dcf-c0dc-80d1a6cd4fc3@xilinx.com> (raw)
In-Reply-To: <20220430121902.59895-2-krzysztof.kozlowski@linaro.org>



On 4/30/22 14:18, Krzysztof Kozlowski wrote:
> The pl330 DMA controller provides number of DMA channels and requests
> through its registers, so duplicating this information (with a chance of
> mistakes) in DTS is pointless.  Additionally the DTS used always wrong
> property names which causes DT schema check failures - the bindings
> documented 'dma-channels' and 'dma-requests' properties without leading
> hash sign.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Not adding acquired review tag because of significant change.
> ---
>   arch/arm/boot/dts/zynq-7000.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 47c2a4b14c06..c193264a86ff 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -343,8 +343,6 @@ dmac_s: dmac@f8003000 {
>   			             <0 40 4>, <0 41 4>,
>   			             <0 42 4>, <0 43 4>;
>   			#dma-cells = <1>;
> -			#dma-channels = <8>;
> -			#dma-requests = <4>;
>   			clocks = <&clkc 27>;
>   			clock-names = "apb_pclk";
>   		};

Acked-by: Michal Simek <michal.simek@amd.com>

If you can take it via your tree that would be great (easier for me than sending 
pull request with just one patch) but I can also take it.

Thanks,
Michal

  reply	other threads:[~2022-05-02  7:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30 12:18 [PATCH v2 0/9] ARM/arm64: dts: drop useless 'dma-channels/requests' properties Krzysztof Kozlowski
2022-04-30 12:18 ` [PATCH v2 1/9] ARM: dts: zynq-7000: " Krzysztof Kozlowski
2022-05-02  7:27   ` Michal Simek [this message]
2022-05-02  7:28     ` Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:18 ` [PATCH v2 2/9] ARM: dts: socfpga: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:18 ` [PATCH v2 3/9] arm64: dts: stratix10/agilex: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:18 ` [PATCH v2 4/9] arm64: dts: juno: " Krzysztof Kozlowski
2022-05-03  8:04   ` (subset) " Sudeep Holla
2022-04-30 12:18 ` [PATCH v2 5/9] arm64: dts: broadcom: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:18 ` [PATCH v2 6/9] ARM: dts: s5pv210: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:19 ` [PATCH v2 7/9] ARM: dts: exynos: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:19 ` [PATCH v2 8/9] arm64: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski
2022-04-30 12:19 ` [PATCH v2 9/9] arm64: dts: fsd: " Krzysztof Kozlowski
2022-05-04  8:30   ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a838f962-354c-9dcf-c0dc-80d1a6cd4fc3@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=alim.akhtar@samsung.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).