From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 068201D532 for ; Wed, 11 Oct 2023 09:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IHSQsp+X" Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EB29AF for ; Wed, 11 Oct 2023 02:35:01 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5046bf37daeso8647162e87.1 for ; Wed, 11 Oct 2023 02:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697016899; x=1697621699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GTb+BC97Rmfw2v9f1zxZNHOqcWwQx2NwvNoBl72WQbk=; b=IHSQsp+X+DVapGHCfyAPWG4945+hUcPvDiigKzOScHq1M2VRkoeSn48qS4gsdaw/ZY iVBKkpyctb02u7SN5cEiLsN38PMV/H5pw/NHvnK6xpKgWABxA2bM9xpimmTHcq4TuRrx 52w4If3jGJ+3haYqfzOk0RhWIY6bspQszEYjXY0LlatYYCowCbCs3gdLtkeOOMkwFc7y Kfn/FdLuXo2eBqJ1b6qAnrAV4zc4QOnvLhfXKPcv3jNTHX4NptQyFRq7BRC2N5A4jbX1 qCPHwyt9KTbWlCQT2v9PwNu5zyG19qK2wj8z7juEPDBkxrfkCTA+cZxDqPqncn45xR1O o81w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697016899; x=1697621699; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GTb+BC97Rmfw2v9f1zxZNHOqcWwQx2NwvNoBl72WQbk=; b=l13JVEWOIAw5o2cio3y0v7gmUhnesZAQDbTeWCh4Qm1Xnyi0IakbZ76HD8nrQRqSQd z7wH6CbK3B5btGzb3S2z1KA4V98HiY8fsgzaCUCvrTphqCLtHcL7WQUWKUqTEoGwTT/w OYc8gn6XjSL6HmIr4cJhHtOo+PF3EjBZ+8lDA7zRtbsfq2Xp3pfbEUdXYI9StYUrPZxn VKPIgJ/TllZHztL2ut663VwRHo6JtDEEFoYxuv4XNA11dJHSbgRUsn3ChLul18t8kmuY ifPY3N/RN2V23rcl6h3Sq+NTlnx+jx/KTUjhJ8tuDloYUGQYMPwHdRbJ79Rc6nE5UfX2 LJLQ== X-Gm-Message-State: AOJu0YyxbUUbvOF3PCc1/3Q11Pzftz5PQ+lt+YmPw0EkUHVHkwqRK4CJ XqQrsX0tKI1XlopfdaJ0z53qqQ== X-Google-Smtp-Source: AGHT+IFJlLI9YnlJYD1w9CjE4Ygsx3wdxgdFBI2HqW3ROvAa5SheRB6Z7Int2nygQUmbnYk7UMB+uQ== X-Received: by 2002:a19:385c:0:b0:503:6e8:1008 with SMTP id d28-20020a19385c000000b0050306e81008mr16146349lfj.36.1697016899282; Wed, 11 Oct 2023 02:34:59 -0700 (PDT) Received: from [172.30.204.44] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id v5-20020a05600c214500b003fbe791a0e8sm16376359wml.0.2023.10.11.02.34.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 02:34:58 -0700 (PDT) Message-ID: Date: Wed, 11 Oct 2023 11:34:55 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 00/10] Add multiport support for DWC3 controllers To: Krishna Kurapati PSSNV , Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , Wesley Cheng , Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_jackp@quicinc.com, ahalaney@redhat.com, quic_shazhuss@quicinc.com References: <20231007154806.605-1-quic_kriskura@quicinc.com> <537d59b3-0e40-4d4d-80ab-b99028af6ec2@linaro.org> <2c325941-0fcc-4092-9581-dd6ebb067163@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2c325941-0fcc-4092-9581-dd6ebb067163@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 10/11/23 07:11, Krishna Kurapati PSSNV wrote: > > > On 10/11/2023 2:21 AM, Konrad Dybcio wrote: >> >> >> On 10/7/23 17:47, Krishna Kurapati wrote: >>> Currently the DWC3 driver supports only single port controller which >>> requires at most two PHYs ie HS and SS PHYs. There are SoCs that has >>> DWC3 controller with multiple ports that can operate in host mode. >>> Some of the port supports both SS+HS and other port supports only HS >>> mode. >>> >>> This change primarily refactors the Phy logic in core driver to allow >>> multiport support with Generic Phy's. >>> >>> Changes have been tested on  QCOM SoC SA8295P which has 4 ports (2 >>> are HS+SS capable and 2 are HS only capable). >>> >>> Changes in v13: >>> This series is a subset of patches in v11 as the first 3 patches in v11 >>> have been mereged into usb-next. >>> Moved dr_mode property from platform specific files to common >>> sc8280xp DT. >>> Fixed function call wrapping, added comments and replaced #defines with >>> enum in dwc3-qcom for identifying IRQ index appropriately. >>> Fixed nitpicks pointed out in v11 for suspend-resume handling. >>> Added reported-by tag for phy refactoring patch as a compile error was >>> found by kernel test bot [1]. >> "If you fix the issue in a separate patch/commit (i.e. not just a new >> version of >> the same patch/commit), kindly add following tags" >> >> the issue your patch resolves is not one that was reported by the >> kernel testing robot, it just pointed out that you need to fix up the >> next revision >> > > I Agree. It sounds wrong to add a reproted-by tag making it seem like a > bug instead of a feature we have written. But if we fix the compile > error mentioned and not add the "reported-by", its like not giving > credit for the reporter. So I put in the reproted by and closes tag to > give a view of what was reported and the feature implemented. This is a normal thing in review, people spot mistakes, null ptrs, etc.. If I had a reported-by for each review where I pointed out e.g. device tree changes that don't compile i'd be topping lwn charts Konrad