From: Sjoerd Simons <sjoerd@collabora.com>
To: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>
Cc: martyn.welch@collabora.com, Nitin Yadav <n-yadav@ti.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-am62-main: Update OTAP and ITAP delay select
Date: Tue, 20 Dec 2022 14:07:14 +0100 [thread overview]
Message-ID: <a85e08c6af0fbdafaa6f3799264e92bba7607b9c.camel@collabora.com> (raw)
In-Reply-To: <b22b6349-9cec-2e86-294a-249f24de2345@ti.com>
Hey Vignesh
On Tue, 2022-12-20 at 16:49 +0530, Vignesh Raghavendra wrote:
>
>
> On 16/12/22 8:06 pm, Sjoerd Simons wrote:
> > From: Nitin Yadav <n-yadav@ti.com>
> >
> > UHS Class U1 sd-card are not getting detected due to incorrect
> > OTAP/ITAP delay select values in linux. Update OTAP and ITAP
> > delay select values for various speed modes. For sdhci0, update
> > OTAP delay values for ddr52 & HS200 and add ITAP delay for legacy
> > & mmc-hs. For sdhci1 & sdhci2, update OTAP & ITAP delay select
> > recommended as in RIOT for various speed modes.
> >
> > Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> > [cherry-pick from vendor BSP]
> > Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> > ---
> >
> > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 46 ++++++++++++--------
> > ----
> > 1 file changed, 24 insertions(+), 22 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index 03660476364f..28c250a8d1ec 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -391,8 +391,10 @@ sdhci0: mmc@fa10000 {
> > ti,clkbuf-sel = <0x7>;
> > ti,otap-del-sel-legacy = <0x0>;
> > ti,otap-del-sel-mmc-hs = <0x0>;
> > - ti,otap-del-sel-ddr52 = <0x9>;
> > - ti,otap-del-sel-hs200 = <0x6>;
> > + ti,otap-del-sel-ddr52 = <0x5>;
> > + ti,otap-del-sel-hs200 = <0x5>;
> > + ti,itap-del-sel-legacy = <0xa>;
>
> This is pretty useless without corresponding driver changes
> to pick up ti,itap-del-sel-legacy as well
Right; itap-del-sel-legacy is properly documented in the device-tree
binding and was already previously set ofcourse so i didn't pick up it
needed more driver changes. That said the dtb change itself should
still be valid even if not actually applied.
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/drivers/mmc/host/sdhci_am654.c?h=ti-linux-5.10.y&id=93d22fc56007ee13e589debf0d32c8b1d5fdc6d8
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/drivers/mmc/host/sdhci_am654.c?h=ti-linux-5.10.y&id=9c878c3dc642f7f1f3ab6ca7f812cd43fe7ed7d8
>
> Could you list that cards affected and fixed by this change?
It's a Collabora branded UHS class 1 (SDR104) card; Matching the commit
message indication given by Nitin. So that in particular i guess, will
have been fixed by the change to the ti,otap-del-sel-sdr104 value for
sdhci1.
For the two patches you highlighted above; Is TI planning to upstream
those as well?
--
Sjoerd Simons
Collabora Ltd.
next prev parent reply other threads:[~2022-12-20 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 14:36 [PATCH 0/3] Improve K3-am625-sk support (USB, MMC) Sjoerd Simons
2022-12-16 14:36 ` [PATCH 1/3] arm64: dts: ti: k3-am62-main: Update OTAP and ITAP delay select Sjoerd Simons
2022-12-20 11:19 ` Vignesh Raghavendra
2022-12-20 13:07 ` Sjoerd Simons [this message]
2022-12-21 14:50 ` Raghavendra, Vignesh
2022-12-16 14:36 ` [PATCH 2/3] arm64: dts: ti: k3-am62-main: Add support for USB Sjoerd Simons
2022-12-16 14:36 ` [PATCH 3/3] arm64: dts: ti: k3-am625-sk: " Sjoerd Simons
2022-12-19 13:09 ` [PATCH 0/3] Improve K3-am625-sk support (USB, MMC) Martyn Welch
2022-12-20 11:32 ` Vignesh Raghavendra
2022-12-20 12:41 ` Sjoerd Simons
2022-12-21 14:49 ` Raghavendra, Vignesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85e08c6af0fbdafaa6f3799264e92bba7607b9c.camel@collabora.com \
--to=sjoerd@collabora.com \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=n-yadav@ti.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).