From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB9EC2D0CD for ; Wed, 18 Dec 2019 23:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E15821D7D for ; Wed, 18 Dec 2019 23:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbfLRXaC (ORCPT ); Wed, 18 Dec 2019 18:30:02 -0500 Received: from mga09.intel.com ([134.134.136.24]:32550 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfLRXaC (ORCPT ); Wed, 18 Dec 2019 18:30:02 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 15:30:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="365890260" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by orsmga004.jf.intel.com with ESMTP; 18 Dec 2019 15:30:01 -0800 Subject: Re: [PATCH v11 07/14] dt-bindings: peci: add NPCM PECI documentation To: Rob Herring Cc: Greg Kroah-Hartman , Lee Jones , Jean Delvare , Guenter Roeck , Mark Rutland , Joel Stanley , Andrew Jeffery , Jonathan Corbet , Gustavo Pimentel , Kishon Vijay Abraham I , Lorenzo Pieralisi , "Darrick J . Wong" , Eric Sandeen , Arnd Bergmann , Wu Hao , Tomohiro Kusumi , "Bryant G . Ly" , Frederic Barrat , "David S . Miller" , Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Philippe Ombredanne , Vinod Koul , Stephen Boyd , David Kershner , Uwe Kleine-Konig , Sagar Dharia , Johan Hovold , Thomas Gleixner , Juergen Gross , Cyrille Pitchen , Tomer Maimon , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, openbmc@lists.ozlabs.org References: <20191211194624.2872-1-jae.hyun.yoo@linux.intel.com> <20191211194624.2872-8-jae.hyun.yoo@linux.intel.com> <20191218144206.GA26118@bogus> From: Jae Hyun Yoo Message-ID: Date: Wed, 18 Dec 2019 15:30:00 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191218144206.GA26118@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On 12/18/2019 6:42 AM, Rob Herring wrote: > On Wed, Dec 11, 2019 at 11:46:17AM -0800, Jae Hyun Yoo wrote: >> From: Tomer Maimon >> >> Added device tree binding documentation for Nuvoton BMC >> NPCM Platform Environment Control Interface(PECI). >> >> Signed-off-by: Tomer Maimon >> Signed-off-by: Jae Hyun Yoo >> --- >> Changes since v10: >> - Newly added in v11. >> >> .../devicetree/bindings/peci/peci-npcm.yaml | 102 ++++++++++++++++++ >> 1 file changed, 102 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/peci/peci-npcm.yaml >> >> diff --git a/Documentation/devicetree/bindings/peci/peci-npcm.yaml b/Documentation/devicetree/bindings/peci/peci-npcm.yaml >> new file mode 100644 >> index 000000000000..bcd5626e68e7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/peci/peci-npcm.yaml >> @@ -0,0 +1,102 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/peci/peci-npcm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton NPCM PECI Bus Device Tree Bindings >> + >> +maintainers: >> + - Tomer Maimon >> + >> +properties: >> + compatible: >> + const: nuvoton,npcm750-peci # for the NPCM7XX BMC. >> + >> + reg: >> + maxItems: 1 >> + >> + "#address-cells": >> + # Required to define a client address. >> + const: 1 >> + >> + "#size-cells": >> + # Required to define a client address. >> + const: 0 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + # PECI reference clock. >> + maxItems: 1 >> + >> + cmd-timeout-ms: >> + # Command timeout in units of ms. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 > > You can drop this as standard units already have a type. I'm assuming you pointed the timeout-ms as one of standard units, right? I'll drop this ref. >> + - minimum: 1 >> + maximum: 60000 >> + default: 1000 >> + >> + pull-down: >> + description: | >> + Defines the PECI I/O internal pull down operation. >> + 0: pull down always enable >> + 1: pull down only during transactions. >> + 2: pull down always disable. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + - minimum: 0 >> + maximum: 2 >> + default: 0 >> + >> + host-neg-bit-rate: >> + description: | >> + Define host negotiation bit rate divider. >> + the host negotiation bit rate calculate with formula: >> + clock frequency[Hz] / [4 x {host-neg-bit-rate + 1}] >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + - minimum: 7 >> + maximum: 31 >> + default: 15 >> + >> + high-volt-range: >> + description: | >> + Adapts PECI I/O interface to voltage range. >> + 0: PECI I/O interface voltage range of 0.8-1.06V (default) >> + 1: PECI I/O interface voltage range of 0.95-1.26V >> + type: boolean > > These last 4 properties are vendor specific or PECI common. For the > former, needs a vendor prefix. For the latter, needs to be moved to > common location. These are Nuvoton vendor specifics. I'll add prefix for them and will check Aspeed bindings too. Thanks a lot for your review! -Jae >> + >> +required: >> + - compatible >> + - reg >> + - "#address-cells" >> + - "#size-cells" >> + - interrupts >> + - clocks >> + >> +examples: >> + - | >> + #include >> + #include >> + peci: bus@100000 { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x100000 0x200>; >> + >> + peci0: peci-bus@0 { >> + compatible = "nuvoton,npcm750-peci"; >> + reg = <0x0 0x200>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + interrupts = ; >> + clocks = <&clk NPCM7XX_CLK_APB3>; >> + cmd-timeout-ms = <1000>; >> + pull-down = <0>; >> + host-neg-bit-rate = <15>; >> + }; >> + }; >> +... >> -- >> 2.17.1 >> >