From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA7813DDDB for ; Tue, 23 Apr 2024 17:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713892067; cv=none; b=oHK/elMdu2AodIZ1zccKet3FV73R3M/KePdCZvAhyD5bAxtHWq6YtLlIM+hJ2QhIxTM4KtyvJP6S74fVIEHBKppUcFfEW/ebiYvV+KthO9lPMVEtKIheKbc190NVnhhnJDqT29qdfWU387Vx9P7QJlbdhsQufGGEmCa7AyV9ryk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713892067; c=relaxed/simple; bh=OAHaHyyh2fhBZH5xqokk86R7KZUiwv6CRGGIa0SBRtw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nzoAg1vJZX4Oe8q0ieLdT/7IfquR9pCGDmaqIbIF42lFHd/vNCuCZbUhgPyAOPaE6T9mWtlfhnCY1VlC+PyJKFm3xSZXedvk74cwFRrcw3lSdHPT39WEonb3SgF9Aoq0rGcQ+9c7G3RP51/WOQxRHk0K5EmSckXZh9No9rAJbtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=fW2PF3qo; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="fW2PF3qo" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4187c47405aso40241035e9.3 for ; Tue, 23 Apr 2024 10:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1713892063; x=1714496863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4HfFEhDy7wrc1JJ4JwN66dtF2lU/7GHQL5ceh8i2rCk=; b=fW2PF3qoa74jX0ldC2Gm5OVz9ubizI4xKHnylwgv8n8oUrA6mB21P/5OBguxjXAUfv SQ8T1oymQZFkwEs+I+Gia1EMjgOBH7VArmIFq6GSVg8qis0Bh/M8zGTi7SRL8tDYsizU 4aPa7bireHxPPbKzsVqMcOqV0pK061jnU/OAbdksMm/h+S+ZtvE5MsJoXZB3V/Ty38Fi vHJalUlmFZ/IeQW2Js8nDPFsBoRLQoEoOGQCMyULZDiPzWx/+URU1OqHUmhVontQFO6L ZjrxEdtAoeUTG6C/LOtFxh6ALiqegIuS82pdMGSdE9HRtAR4BijhP2jT9TnIQZ7pT59L rCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713892063; x=1714496863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4HfFEhDy7wrc1JJ4JwN66dtF2lU/7GHQL5ceh8i2rCk=; b=fzueh03dgqNMQHSbOT6PqcmcVCjAP0WWqPEN/bKUb/RuQCwN5o+Ke8TagE7Jzsr8uw Kdq6XeqHltDja7U56fcfv66JC6owuFrdtyo5arE74HInb0sE/pidn4Q/mfzaRJ9qxCN0 XVxmPKeP240rj8yq1PubR1GR8r2+KZ9LdoPwdHE7k8JPg2MLsyWZfJtEj+SZ8M+e9rKD wuRDj+DsgkkRHQVOZBCYayahQ2kUNKPfcJvK2ZXRKsUlBi4YKDV41rmvzJtsKH1IfwBA Lw6pWsIURlVYJF4o0B0wEz1TTHFEqBkCJwVrU21GWcs+ojI5R/1yjo/XNQpokBhVRo1d 8sTg== X-Forwarded-Encrypted: i=1; AJvYcCWNWJ1ekm3OXl9dGmIOZ4XXAE7hbJtJ5G/R4xLaEJekLJjyN/qoDGeUMpJYHrS1Udj6FAznuTdpv3gPdDJH7j6mnkIQ4vY6/bw9oA== X-Gm-Message-State: AOJu0YzMXSFhYhcg8Y77Uoq59ldci1lFVdEaAOmpbMm0V/lqjoAJmBEB PcGbtnpGDnx/rnm8KWcdV+9p+Yg60SCI9MGuc73Yrjcjaij52mUawnZaW9xDiUk= X-Google-Smtp-Source: AGHT+IEeml7xlDPvKVEJlBPjkyqYO1K/a3UWyW6pbqsDEH7Dp3zHkT8MMXjVjKAP5avnRrImiMosWg== X-Received: by 2002:a05:600c:a001:b0:418:a7a7:9bd7 with SMTP id jg1-20020a05600ca00100b00418a7a79bd7mr8084322wmb.24.1713892063377; Tue, 23 Apr 2024 10:07:43 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b00414659ba8c2sm20996935wmq.37.2024.04.23.10.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 10:07:42 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 19:07:41 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/18] ASoC: dt-bindings: mt6357: Add audio codec document To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lee Jones , Flora Fu , Jaroslav Kysela , Takashi Iwai , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Catalin Marinas , Will Deacon , Rob Herring Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org References: <20240226-audio-i350-v3-0-16bb2c974c55@baylibre.com> <20240226-audio-i350-v3-3-16bb2c974c55@baylibre.com> <481abafd-33af-44a6-8460-068b4a85d764@linaro.org> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <481abafd-33af-44a6-8460-068b4a85d764@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/04/2024 17:55, Krzysztof Kozlowski wrote: >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + codec { >> + mediatek,micbias0-microvolt = <1900000>; >> + mediatek,micbias1-microvolt = <1700000>; >> + mediatek,vaud28-supply = <&mt6357_vaud28_reg>; > Sorry, this does not work. Change voltage to 1111111 and check the results. Actually it's worst ! I've removed the required property (vaud28-supply) but the dt check pass. Same behavior for some other docs like mt6359.yaml The at24.yaml doc works as expected, then I tried compare an find the issue, without success... I've replaced "codec" by "audio-codec", according to [1]. I've tried multiple manner to implement the example code, without success. I'm wondering if what I try to do is the correct way or parse-able by the dt_check. If I drop this file and implement all these new properties into the MFD PMIC documentation directly, I've the expected dt_check result (function to good or wrong parameters) +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml @@ -37,9 +37,32 @@ properties: "#interrupt-cells": const: 2 - codec: + audio-codec: type: object - $ref: /schemas/sound/mt6357.yaml + properties: + vaud28-supply: + description: 2.8 volt supply phandle for the audio codec + + mediatek,hp-pull-down: + description: + Earphone driver positive output stage short to + the audio reference ground. + type: boolean + + mediatek,micbias0-microvolt: + description: Selects MIC Bias 0 output voltage. + enum: [1700000, 1800000, 1900000, 2000000, + 2100000, 2500000, 2600000, 2700000] + default: 1700000 + + mediatek,micbias1-microvolt: + description: Selects MIC Bias 1 output voltage. + enum: [1700000, 1800000, 1900000, 2000000, + 2100000, 2500000, 2600000, 2700000] + default: 1700000 + + required: + - vaud28-supply unevaluatedProperties: false regulators: @@ -88,6 +111,12 @@ examples: interrupt-controller; #interrupt-cells = <2>; + audio-codec { + mediatek,micbias0-microvolt = <1700000>; + mediatek,micbias1-microvolt = <1700000>; + vaud28-supply = <&mt6357_vaud28_reg>; + }; + regulators { Is the implementation above looks good for you ? [1] https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation -- Regards, Alexandre