From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6372737EA for ; Tue, 1 Jul 2025 12:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751371847; cv=none; b=pLY1VbOHsHeVQkh1q0KFPPeMWfuK5Lb+y8ym5iV2mgF2uYTE3ol1d9hhG+1SjFGZZmnK37aAx2e+KSFo1uuB2nKg+rT4zi4jqX5Czf9F07iT/pgMIxLo+Z+M0fQwnk5UehnG1aC0jB8IhnYKn1wACMOpgIrMo9f4nIy50nFlpYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751371847; c=relaxed/simple; bh=+ZTcoZDBgfv9tgwSo5krlJwewXP9Gn+CvJCEwKMyp+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W5QfDTewFiaLn+FX+cWte8jTufoUDVAPkzCEfRUxb2Y/0XZmomMsP5+IhmR1QIHAnYFsqG7lzmopkc5ahJelCOTayX6f/eXj7sNhE0NB0ObBx8j12SvR/YwlQfVqORW2lIAVbTvZvWAL5Ur6ZT4KpKC6qBev9zwDJtJJTygFUSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pqFrBlPi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pqFrBlPi" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5619t0HD029524 for ; Tue, 1 Jul 2025 12:10:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W7b4c8FAEbR26sZIDd9GjlRjW8NmHWg/e6iguo0YBys=; b=pqFrBlPioOJlzMoi 41hkI6RiQkIUPd+reYNaF+2l4dMszIj9gs2Gt8pJgqPc+zi5y91fr5yPE+9mBe91 eAXgI3Qu1pfXhhAG4agIrHGP5lgECx1KNf+6ehkvp2unibXmJuy0TlZH+VA+vDk3 FgyobEtGYdnPfj/lB6GnQ63SVyxkpn7GFZvlTSYsUCHkWk+M2nZOA+5JbaVjjhVc A+OZwhYMpIlketjKir7i+ys7L7+g3rjiFckVN7JG5AtOyE9YbFXYL5hCCgptF1QS l5X0ApCTpCSjh1SI1DAiEppqP6McnlghdXrP6QCm+InEwFY1yRzbGSLIP4BjV5Rg un0uDQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j95j0me5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Jul 2025 12:10:45 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4a6f59d5ac6so9311461cf.0 for ; Tue, 01 Jul 2025 05:10:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751371844; x=1751976644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W7b4c8FAEbR26sZIDd9GjlRjW8NmHWg/e6iguo0YBys=; b=v8I+bG5NTYo+V1Ui4ApLAe1JVnlmWq2NOb/VKonDoHL6bGnE2Dc2wZyARLWirsz4gQ H0pY1oE8LNUwJ2GZpBgc9Pv5GZqJL8YYWIvdh07xzgNWT8fPmDhjOwfxsk6Z+vV7gGjl ZZVxEOIy8HGTCBHsfvbLKce2uVhjbFYqyhefSqG6u2AVY18VCHMUuP8xMz8w1axX/efy 3U+5toWz5qpwjitlYokXPki0W7F6lObCLcON8yh5v0+EvYqheA5fehzgozhdRlIBRSk3 Tqn13+4N/P/sT65eGMWMzy9PzbSTt/6U6JbFVTEsZBANR167loCtvBz9WjNSSG5lrS6U oMmg== X-Forwarded-Encrypted: i=1; AJvYcCXA2BAcV34wSXA8Cdzn9BlMP/Dyf7YLsobjnn2sKQ6n3fGxvNntryeoW2j8P9g2XA/2PngQI8NQggvN@vger.kernel.org X-Gm-Message-State: AOJu0YwBxOdf7zLL56AspXRggsNPMsqQ1tMZxNhjMbndwHJRXPdQqkv3 PBsskfqkB5c9JW2uM/Cni0iyQs3qUfoYG04PUPpCl8GP+EFEZ/vBzm2dNmawItAJPIPwndc4jzR PMCI358OgfsvuLVKC8Gz9wClx45ImfXBgJ4I3ZH3hCZ+U/Q1Iu6lCmNQUVbRLovTQ X-Gm-Gg: ASbGncvpgjbsBoflGO3xqgYQbl+iWZfocdETWMhuqIlgrOa5k5OJUqAKYSxolODBsJ1 4pVF8tMdOMNhymAiEBqCXT1RfZw5pV3A7FhO8f6aajIPzJNetpRiH0iKdF8NHRrvi/xxN1mKEzF Ato23KM3CvzDNYLM6/iyWuR5Iuo2nEUnjIHvOG3cIH71rSg6Qg375CSBKoSSSPWCQHF/Yjl8VTW SiTqTSCZWuywIn1CFirHllRQPsYyRQydX9OEwq8CWb1uUofsX03EuD2HqgqIeRIl8hYYbgQVDT3 v7VG4DYc2st5TQMfNWoiQdqJie3DxdcM+ln/gNi1j/VSXrlb3a7xpB2EVR8dnzjEAWtkN61SnVz RNclc/1zr X-Received: by 2002:a05:620a:3710:b0:7c0:bc63:7b73 with SMTP id af79cd13be357-7d46774f6eamr146985185a.13.1751371844340; Tue, 01 Jul 2025 05:10:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTxzbx67vZnwclq62QSQMEsaHBiUQUi2s3v5N3dbE7nNpEwja0y/5s43uax9D/Bfc+SnBykA== X-Received: by 2002:a05:620a:3710:b0:7c0:bc63:7b73 with SMTP id af79cd13be357-7d46774f6eamr146979885a.13.1751371843303; Tue, 01 Jul 2025 05:10:43 -0700 (PDT) Received: from [192.168.1.114] (83.9.29.190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353ca1619sm854280966b.149.2025.07.01.05.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:10:42 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 14:10:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/8] arm64: dts: qcom: ipq5424: Add NSS clock controller node To: Luo Jie , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Georgi Djakov , Philipp Zabel , Richard Cochran , Konrad Dybcio , Catalin Marinas , Will Deacon , Anusha Rao Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com References: <20250627-qcom_ipq5424_nsscc-v2-0-8d392f65102a@quicinc.com> <20250627-qcom_ipq5424_nsscc-v2-7-8d392f65102a@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAxMDA3NiBTYWx0ZWRfX5XjOaHosCg/7 yRcMZZ2MzZei5zwuP+geyw2Pbe54U+PAzRJ6WCnHAT5Lil1AGc6MogrelHHzvwd+ejy1Bsts5Ki mwH47w2kevCAUMCuUfmp/2mt0je4pfjMr5NdcjdBkGSDETQQRmUrKJHXtSV4vDIbyl70Mvh/qax 94eKMqtkO0+iWadj7LV14j8Wp3UTdilSYqcNJ2sAe3+2QjAemDTzx8dH4DZA3Lo7lawJP8jb81w AJUZmghjnLD8x6573Kbp1ZNFwbkYx0/OX3fgh0Dp/7/r3FBQbISPfJPLKoIpLyHMlSO9cOOdoDR 72OamJEJMeI83kAujxAjnjHynKZrFNXGj9sudonmud5veuFgzrx+UqIs8F11qbQ3h4rXlHSzvGJ ZVlbadrPf45vX6CHlgzlPwCazZ6lMPLjGlo9olTmr6lDyQc/JbtwB8ACDf1NYEg0cQSGJIwM X-Proofpoint-ORIG-GUID: fTzg7QugVbBvThoZQ0uA6e1PXpnTola8 X-Authority-Analysis: v=2.4 cv=EuHSrTcA c=1 sm=1 tr=0 ts=6863d045 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=fKQzr7EGRj+VoE0XNsDNvQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=ovtazKSSlfofSAFZHdsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: fTzg7QugVbBvThoZQ0uA6e1PXpnTola8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-01_02,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=966 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507010076 On 01-Jul-25 14:08, Luo Jie wrote: > > > On 6/28/2025 12:27 AM, Konrad Dybcio wrote: >> On 6/27/25 2:09 PM, Luo Jie wrote: >>> NSS clock controller provides the clocks and resets to the networking >>> hardware blocks on the IPQ5424, such as PPE (Packet Process Engine) and >>> UNIPHY (PCS) blocks. >>> >>> Signed-off-by: Luo Jie >>> --- >>>   arch/arm64/boot/dts/qcom/ipq5424.dtsi | 30 ++++++++++++++++++++++++++++++ >>>   1 file changed, 30 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> index 2eea8a078595..eb4aa778269c 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> @@ -730,6 +730,36 @@ frame@f42d000 { >>>               }; >>>           }; >>>   +        clock-controller@39b00000 { >>> +            compatible = "qcom,ipq5424-nsscc"; >>> +            reg = <0 0x39b00000 0 0x800>; >> >> size = 0x100_000 >> >> with that: >> >> Reviewed-by: Konrad Dybcio >> >> Konrad > > I initially thought that a block size of 0x800 would be sufficient, as > it covers the maximum address range needed for the clock configurations. > However, the NSS clock controller block actually occupies an address > range of 0x80000. I will update this to 0x80000 in the next version. > Thank you for your feedback. 0x80_000 excludes the wrapper region. Please mark it as the entire 0x100_000 that it occupies, no matter if there's anything in there Konrad