From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FB2C433E0 for ; Fri, 19 Jun 2020 05:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B17920890 for ; Fri, 19 Jun 2020 05:02:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q+p8djyO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbgFSFCD (ORCPT ); Fri, 19 Jun 2020 01:02:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbgFSFCD (ORCPT ); Fri, 19 Jun 2020 01:02:03 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86720C06174E; Thu, 18 Jun 2020 22:02:02 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id k2so3585329pjs.2; Thu, 18 Jun 2020 22:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SiDB1J01wn7pLbZQ7NN544CR9V1CL0STkwNstWzaeL0=; b=Q+p8djyOFrojiC/CZXUfS2ozp4zwZo8x4pCbOFnDoDovi3kHP3dyPWsIZ8H7cf1cBM X8NZycMVklwlkXQ1DPTKMhKcaAo7+GIb2XPh36gbjYSLX8GE5wxKV6GxuTAKLUsqLqia 6A2sz7QFWkjFescqu915j41GpLDPr0JfGAa0OArqggX4OcHp0q9HT9Gm7lMlSaCKfvCe 3CpJFenzu8paxoAomHeGIZgJByHJVKtfNCBIrTjZyketYTEa7RguWc3mXhyBdwJDAXGW Wv0wVANE4WTiJN+HWgvQMp3rPKCNhO1gT1LqGMxhe1O5G+y1Uhkp26jhYdz75Y3ipGtp D9/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SiDB1J01wn7pLbZQ7NN544CR9V1CL0STkwNstWzaeL0=; b=TdAUg/Mse5srkZX8FAfnS+RS8osM9pKIAYMYvtWe6P+ymqZRuhE62weGyF1dDky6Gb cKI2uvQVfvRfZr6Hr37qgrjf3C9S/+mVeH+WOXfqLrN8yUugmYuF5mxno7lTAeboZY7f 4wttvrqUFnq9rN7UXAbGso4J3n+KcuWpLLVMJYbBpIBRlO6KtBZ3S6KsHVqO7zFkqPnv T6SJUKVMdDZqHLOfJxp9azi0G9PxbVbzDnbOsna5Y4yQAKPliYxW6q0i1lC1GDakr3en 47ys1x848oBsiR5kg8UB7Oi+Z82LKe6xNBMlEuavNCg6kUIL04CGdwAWa7JktiGA1kjF IFfQ== X-Gm-Message-State: AOAM530nFw7vRYW2JMRoDHrWEY/PDnFJVB+9H2YDttU215vK9ZCRDHzk FZrYR1YMMB/NuPBUP4RCYGU= X-Google-Smtp-Source: ABdhPJzzw16q71O4BfPkHNLVa5OmqTfgAuceKUIEfpvaV41w5KPGLKxCaBtIOZhpdXHXEx6EQJD3wQ== X-Received: by 2002:a17:902:e901:: with SMTP id k1mr6599989pld.92.1592542921858; Thu, 18 Jun 2020 22:02:01 -0700 (PDT) Received: from [10.230.188.43] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id i63sm3992094pje.34.2020.06.18.22.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 22:02:00 -0700 (PDT) Subject: Re: [PATCH v5 2/3] dt-bindings: net: mscc-vsc8531: add optional clock properties To: Heiko Stuebner , davem@davemloft.net, kuba@kernel.org Cc: robh+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, christoph.muellner@theobroma-systems.com, Heiko Stuebner References: <20200618121139.1703762-1-heiko@sntech.de> <20200618121139.1703762-3-heiko@sntech.de> From: Florian Fainelli Message-ID: Date: Thu, 18 Jun 2020 22:01:58 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200618121139.1703762-3-heiko@sntech.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 6/18/2020 5:11 AM, Heiko Stuebner wrote: > From: Heiko Stuebner > > Some mscc ethernet phys have a configurable clock output, so describe the > generic properties to access them in devicetrees. > > Signed-off-by: Heiko Stuebner > --- > Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > index 5ff37c68c941..67625ba27f53 100644 > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -1,6 +1,8 @@ > * Microsemi - vsc8531 Giga bit ethernet phy > > Optional properties: > +- clock-output-names : Name for the exposed clock output > +- #clock-cells : should be 0 > - vsc8531,vddmac : The vddmac in mV. Allowed values is listed > in the first row of Table 1 (below). > This property is only used in combination > With that approach, you also need to be careful as a driver writer to ensure that you have at least probed the MDIO bus to ensure that the PHY device has been created (and therefore it is available as a clock provider) if that same Ethernet MAC is a consumer of that clock (which it appears to be). Otherwise you may just never probe and be trapped in a circular dependency. -- Florian