From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B22C433E0 for ; Tue, 5 Jan 2021 13:54:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FCF622AAB for ; Tue, 5 Jan 2021 13:54:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729000AbhAENyp (ORCPT ); Tue, 5 Jan 2021 08:54:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729003AbhAENyo (ORCPT ); Tue, 5 Jan 2021 08:54:44 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EC83C061798 for ; Tue, 5 Jan 2021 05:54:04 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id q18so36313752wrn.1 for ; Tue, 05 Jan 2021 05:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=WeMaF7TAVDOEIygomZnq05mZMvBNk5xAGXnGkwP4VxM=; b=ye5X2VuG3ou5wXNFk5tCMRRCWTPYTJ0gR4UGwUrMrOUE9rOMVq1fn7BEQ7Qv9ZUe0f T52GJNGyEMCs4wOPnymnhwaZita24pCfV2GaE7K76S5eLmBdmPeZI9XHx5xmXsxKp3Kd p9uVsXsss0OXMxuo0BC/GGdWySBMsv5SEQGte5AK5UFq7oREC1oS4GO6Q1yG1KFQwRnq LEDpFxRk5r5JCTI20JAIPALpeI2upYM+47VQVhMKoBNj/nUY8Sgdo353APdpf3WtF9sU A56HDIiyET1lXVEKGyaEQRD+R8KKgfEwuFA3tZZD88P19IWECm1EovZhOlHJ8IXlg/mo K6Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WeMaF7TAVDOEIygomZnq05mZMvBNk5xAGXnGkwP4VxM=; b=HFmcM8R/gc9bskBrvALykUQZPwrMWpPMfiyc/Yyj9hX8aXBDCeaA6loDWZiOwz+yM9 QyjkVvnFcCRXE6BPZopekUPV1zLVIXbQ0yeyVQ8+AkkgArFEPDiJK2io7AowRx8w6ed8 RLNkBi+3nst0WOMzicLfE/nBfTs3qepGzJqnYJkOX7Mf1e85drslA8yfFzhisjylf16E 8uTz+md9YJfwhRKrU/KZLrvx96PxN1ptYn1pPqzsbpgzxhZT4pdADwN7JNytGqbunSl1 AOnSy/yK2bg6uJSD01X+5v+vZ5MaLV/JSXkcwuAAWv7gtawFluJzsIacxWsgkpYNoWMA WL+w== X-Gm-Message-State: AOAM533ol6uVRuPz9oJ+M0BhqI4to3yTVGuWkyYS7KCslshKdyhsDUZc PpENQt0JH9vPaEqC/KOA1kZqRQ== X-Google-Smtp-Source: ABdhPJyD5a1x18fxXMG+4Mcx13Pev1iFYLAfK9YgIqd+kZ7o7mQ6A/yXNqdPNWouLSe9UlACDrP1xQ== X-Received: by 2002:adf:dd09:: with SMTP id a9mr84076235wrm.90.1609854843150; Tue, 05 Jan 2021 05:54:03 -0800 (PST) Received: from [10.44.66.8] ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id i11sm4154410wmd.47.2021.01.05.05.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 05:54:02 -0800 (PST) To: Vincent Knecht , Jun Nie , devicetree@vger.kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org Cc: shawn.guo@linaro.org References: <20201204075345.5161-1-jun.nie@linaro.org> <20201204075345.5161-6-jun.nie@linaro.org> From: Georgi Djakov Subject: Re: [PATCH v2 5/5] interconnect: qcom: Add MSM8939 interconnect provider driver Message-ID: Date: Tue, 5 Jan 2021 15:54:04 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1/2/21 13:08, Vincent Knecht wrote: > Le vendredi 04 décembre 2020 à 15:53 +0800, Jun Nie a écrit : >> Add driver for the Qualcomm interconnect buses found in MSM8939 based >> platforms. The topology consists of four NoCs that are controlled by >> a remote processor that collects the aggregated bandwidth for each >> master-slave pairs. >> >> Signed-off-by: Jun Nie > > Shouldn't some rpm ids be changed like they were for msm8916 in the following patch ? > c497f9322af9 ("interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes") > https://patchwork.kernel.org/project/linux-arm-msm/patch/20201112105140.10092-1-georgi.djakov@linaro.org/ Maybe they should. I don't have the hardware to try it, but the test will be to just add the NoC DT nodes, enable the driver and inspect the boot log for messages like: [ 2.926647] qcom_icc_rpm_smd_send mas X error -6 Thanks, Georgi