From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE25C7619A for ; Thu, 23 Mar 2023 06:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbjCWGmq (ORCPT ); Thu, 23 Mar 2023 02:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbjCWGmm (ORCPT ); Thu, 23 Mar 2023 02:42:42 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D2DB2B9FA for ; Wed, 22 Mar 2023 23:42:40 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id o12so82239319edb.9 for ; Wed, 22 Mar 2023 23:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679553759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8N/XaeLLwIkdvDZKm8o78DXnGxcOUGR0NMOEEQz35z0=; b=lDxcvr5ATCpedu3VGnpb8banpvgsvL4WHvd3fdqEdDJDsZqHDcg7SCHK7jD3qBRH0Z 3HZQvHnKMh+aweQcSYtBE7N/T+2qRPPNQ2KoND9LUsWyY+UL9e7xS+Ts0rZUocfTpOwA FkBt8c5WRvUCArdZpRQ7hePy/qmHZARcvgqEsZpUJZFTprDnMS316yoqY1gVWx0j4jY2 ciR/wP0ABBT71+u6PwJsujNBXS2VUfFL9IWABhqrMsWho6sUaXQv7bAHM36a9+YF7+Bq N6uE4wU5DM9P22SquidRpNNCkjRIG86OMQQfhkL8xvSSjOGWHnxSkMehQWLNTgXvZVpG 8meA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679553759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8N/XaeLLwIkdvDZKm8o78DXnGxcOUGR0NMOEEQz35z0=; b=uRUWYPdatK9a3ZhnpvN7PubGdI8d+mo9v3wzjWgKloiouUZuvLXuJQqqwXnh32Kf5A 7x1/oTTqoqeC8wisH8DWYWdkFNhN7nhb7eqZwFjUI4pLen/ziiiX6+agLmtj4aPnWSOR MQI5AWuH0QXKEHD7GvLUKxLYIvvF7dLaFspwrP5BA/v7zXLS1g7AMkOH+HGcyGOgbI+l Y38GdBDJzbuXODXzQVcI/UXGKWsxtliu3H49zYAXqYTwZMDHMziHUVVLSu0ldiqmO5u2 mp1iWO7NnPxGeNHw06HA+Iqx9aEVeJZpyvBHxrC8Kc3kIC3YSS0+hhzYkIP94x837z66 9a9Q== X-Gm-Message-State: AO0yUKWRhV23Mi42DU54GsoBjqNS0xsePd0gE/YqZfkmAL7+9GQmJCEQ bUvvX7bIvMe2x2KTbLF0FpExdg== X-Google-Smtp-Source: AK7set+yg1lsxvSZGJlZeaAPDUcWbsIyd9m6BF2xr2YnwB6qRVho+nRzalX5J6ERkOZevu0PVgHs2A== X-Received: by 2002:a17:906:804e:b0:8af:4120:63a8 with SMTP id x14-20020a170906804e00b008af412063a8mr9388515ejw.68.1679553759082; Wed, 22 Mar 2023 23:42:39 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a665:ed1e:3966:c991? ([2a02:810d:15c0:828:a665:ed1e:3966:c991]) by smtp.gmail.com with ESMTPSA id z1-20020a1709064e0100b00931baabe36csm8146329eju.63.2023.03.22.23.42.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 23:42:38 -0700 (PDT) Message-ID: Date: Thu, 23 Mar 2023 07:42:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 2/8] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY Content-Language: en-US To: Varadarajan Narayanan Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-clk@vger.kernel.org References: <20230323063705.GA19800@varda-linux.qualcomm.com> From: Krzysztof Kozlowski In-Reply-To: <20230323063705.GA19800@varda-linux.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/03/2023 07:37, Varadarajan Narayanan wrote: > On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: >> On 22/03/2023 11:44, Varadarajan Narayanan wrote: >>> Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 >>> >>> Signed-off-by: Varadarajan Narayanan >>> >>> --- >>> Changes in v2: >>> - Updated sections missed in previous patch >>> --- >>> .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> index e81a382..beae44c 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> @@ -21,6 +21,7 @@ properties: >>> enum: >>> - qcom,ipq6018-qmp-usb3-phy >>> - qcom,ipq8074-qmp-usb3-phy >>> + - qcom,ipq9574-qmp-usb3-phy >>> - qcom,msm8996-qmp-usb3-phy >>> - qcom,msm8998-qmp-usb3-phy >>> - qcom,qcm2290-qmp-usb3-phy >>> @@ -204,6 +205,27 @@ allOf: >>> compatible: >>> contains: >>> enum: >>> + - qcom,ipq9574-qmp-usb3-phy >>> + then: >>> + properties: >>> + clocks: >>> + maxItems: 2 >> >> toplevel defines minItems as 3, so are you sure this works? Did you test it? > > Yes, this is tested. Able to do I/O. Bindings do not impact on whether you can or can not do IO, so I meant tested as DTS is compliant with bindings. I assume it was not, so please test bindings and DTS before sending new version. see Documentation/devicetree/bindings/writing-schema.rst for instructions > We only have 2 items. Is it ok change the minItems to 2? Yes, because you must update top level (and maybe other) constraints to correct ones. Just test the code... Best regards, Krzysztof