From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 237391F61C; Tue, 15 Oct 2024 14:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729003637; cv=none; b=lnrvSNKFvIgrjGX3+tKfIdO5CGhdxsC55Qgf1ks7086R0bekMb/6tAY+fb5YH8mk8TfhFPo+/B50E0wDieQwlKUrMGDqrF35JhyLaTyAjRpeCei03PwfsRlh5Kx/cNG4v1KyE81EpaK/LXKd+dNTQpxR9DfiId1jNC7KBv1u5/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729003637; c=relaxed/simple; bh=MP9cwT7tF4h/zPcm+gSYgwsGGRaT2JCrT66NUZwYfFo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Es9X1u7sNlYbwxsh5ikq0ZXpnmAPzzm9dbkq2Cds41eI74aIoRtipMkCAlotkHq6SZ0P+DfQzMa4lRessas5lP2CHYPxqXkd7NKzZ+APhZexx3HMm6lFVgFNh+TjFn8lcUi+BPg4Oe+UWU6uCIQvd7KvJHgawo/cQ9/7EkUp2gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37591FEC; Tue, 15 Oct 2024 07:47:43 -0700 (PDT) Received: from [10.57.87.12] (unknown [10.57.87.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 731B63F71E; Tue, 15 Oct 2024 07:47:11 -0700 (PDT) Message-ID: Date: Tue, 15 Oct 2024 15:47:05 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/2] iommu/arm-smmu-v3: bypass streamid zero on i.MX95 To: "Peng Fan (OSS)" , Will Deacon , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Joy Zou , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan , Jason Gunthorpe References: <20241015-smmuv3-v1-0-e4b9ed1b5501@nxp.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: <20241015-smmuv3-v1-0-e4b9ed1b5501@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-10-15 4:14 am, Peng Fan (OSS) wrote: > i.MX95 eDMA3 connects to DSU ACP, supporting dma coherent memory to > memory operations. However TBU is in the path between eDMA3 and ACP, > need to bypass the default SID 0 to make eDMA3 work properly. I'm confused, why not just describe that the device owns this StreamID in the DT the normal way, i.e, "iommus = <&smmu 0>;"? Thanks, Robin. > I was also thinking to introduce "bypass-sids = <0xA 0xB 0xC ...>" to > make this reusable for others, but not sure. I could switch to > "bypass-sids" if you prefer. > > Signed-off-by: Peng Fan > --- > Peng Fan (2): > dt-bindings: iommu: arm,smmu-v3: introduce nxp,imx95-bypass-sid-zero > iommu/arm-smmu-v3: Bypass SID0 for NXP i.MX95 > > .../devicetree/bindings/iommu/arm,smmu-v3.yaml | 4 ++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 19 ++++++++++++++++--- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 + > 3 files changed, 21 insertions(+), 3 deletions(-) > --- > base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 > change-id: 20241014-smmuv3-120b24bc4659 > > Best regards,