From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2021C433DB for ; Tue, 16 Mar 2021 08:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85FBC64F96 for ; Tue, 16 Mar 2021 08:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233162AbhCPIDV convert rfc822-to-8bit (ORCPT ); Tue, 16 Mar 2021 04:03:21 -0400 Received: from mga09.intel.com ([134.134.136.24]:40127 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232577AbhCPIDF (ORCPT ); Tue, 16 Mar 2021 04:03:05 -0400 IronPort-SDR: baPMBGcSlhUp+sNUWayTAZs6xnV2B4bTwrIepqye1q4pnbEPn2bYJz4Fc22REYeB2FWHRomBHb 5mgeJXvSv8Ew== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="189310814" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="189310814" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 01:03:04 -0700 IronPort-SDR: 4Mlf+xJkj70RZ08Adl2iC52T/Xk6/ENFhy59/2Pj5tyn0kcKwhlsNQJ8+GIkjBJu+nLCvAGJVR VpXWdqS3Y8HQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="590576542" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 16 Mar 2021 01:03:04 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 16 Mar 2021 01:03:03 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 16 Mar 2021 16:03:01 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 16 Mar 2021 16:03:01 +0800 From: "Li, Philip" To: =?iso-8859-1?Q?J=E9r=F4me_Pouiller?= , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , lkp CC: "kbuild-all@lists.01.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Greg Kroah-Hartman" , Kalle Valo , "David S . Miller" , "devicetree@vger.kernel.org" , Rob Herring , "linux-mmc@vger.kernel.org" Subject: RE: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings Thread-Topic: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings Thread-Index: AQHXGjluGKy1l/wG8EupGMY1Pavj+qqGQOCw Date: Tue, 16 Mar 2021 08:03:00 +0000 Message-ID: References: <20210315132501.441681-25-Jerome.Pouiller@silabs.com> <20210315210920.GA43634@d108da9836c5> <3096745.nmkoU2l6Xm@pc-42> In-Reply-To: <3096745.nmkoU2l6Xm@pc-42> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > Subject: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings > > Hello, > > On Monday 15 March 2021 22:09:20 CET kernel test robot wrote: > > > > From: kernel test robot > > > > drivers/net/wireless/silabs/wfx/bus_sdio.c:134:8-33: ERROR: Threaded IRQ with no primary handler requested without > IRQF_ONESHOT > > > > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > > threaded IRQs without a primary handler need to be requested with > > IRQF_ONESHOT, otherwise the request will fail. > > > > So pass the IRQF_ONESHOT flag in this case. > > > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > > > CC: Jérôme Pouiller > > Reported-by: kernel test robot > > Signed-off-by: kernel test robot > > --- > > > > url: https://github.com/0day-ci/linux/commits/Jerome-Pouiller/wfx-get-out-from-the-staging-area/20210315-212855 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git b828324bba8f575fde487a91fec07303789dda8a > > > > bus_sdio.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- a/drivers/net/wireless/silabs/wfx/bus_sdio.c > > +++ b/drivers/net/wireless/silabs/wfx/bus_sdio.c > > @@ -132,7 +132,8 @@ static int wfx_sdio_irq_subscribe(void * > > flags = IRQF_TRIGGER_HIGH; > > flags |= IRQF_ONESHOT; > > return devm_request_threaded_irq(&bus->func->dev, bus->of_irq, NULL, > > - wfx_sdio_irq_handler_ext, flags, > > + wfx_sdio_irq_handler_ext, > > + flags | IRQF_ONESHOT, > > "wfx", bus); > > } > > > > > > Obviously, "flags" always contains IRQF_ONESHOT. So, it is a false positive. Thanks for the feedback. Sorry about this false positive, this had been disabled for auto report now. > > > -- > Jérôme Pouiller > > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org