From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>, linux-bluetooth@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
alistair@alistair23.me, anarsoul@gmail.com, luiz.dentz@gmail.com,
johan.hedberg@gmail.com, marcel@holtmann.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/3 V3] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
Date: Mon, 27 Feb 2023 17:39:35 +0100 [thread overview]
Message-ID: <a90451df-0191-a2fb-060d-66ce5afb55d2@linaro.org> (raw)
In-Reply-To: <20230227163027.130292-2-macroalpha82@gmail.com>
On 27/02/2023 17:30, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add compatible string for RTL8821CS for existing Realtek Bluetooth
> driver.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> .../bindings/net/realtek-bluetooth.yaml | 25 ++++++++++++-------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> index 143b5667abad..198c5dd1f257 100644
> --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> @@ -4,24 +4,31 @@
> $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth
> +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth
>
> maintainers:
> - Vasily Khoruzhick <anarsoul@gmail.com>
> - Alistair Francis <alistair@alistair23.me>
>
> description:
> - RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over
> - SDIO, while BT is connected over serial. It speaks H5 protocol with few
> - extra commands to upload firmware and change module speed.
> + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part
> + is connected over SDIO, while BT is connected over serial. It speaks
> + H5 protocol with few extra commands to upload firmware and change
> + module speed.
>
> properties:
> compatible:
> - enum:
> - - realtek,rtl8723bs-bt
> - - realtek,rtl8723cs-bt
> - - realtek,rtl8723ds-bt
> - - realtek,rtl8822cs-bt
> + oneOf:
> + - items:
Now you added items which were never here... You have only one item, so
no need for items.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-27 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 16:30 [PATCH 0/3 V3] Bluetooth: Add support for RTL8821CS Chris Morgan
2023-02-27 16:30 ` [PATCH 1/3 V3] dt-bindings: net: realtek-bluetooth: Add RTL8821CS Chris Morgan
2023-02-27 16:39 ` Krzysztof Kozlowski [this message]
2023-02-27 16:30 ` [PATCH 2/3 V3] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS Chris Morgan
2023-02-27 16:30 ` [PATCH 3/3 V3] arm64: dts: rockchip: Update compatible for bluetooth Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90451df-0191-a2fb-060d-66ce5afb55d2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alistair@alistair23.me \
--cc=anarsoul@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=marcel@holtmann.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).