From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, quic_wcheng@quicinc.com,
johan+linaro@kernel.org, quic_kriskura@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info
Date: Thu, 11 Jul 2024 11:03:22 +0200 [thread overview]
Message-ID: <a908a3fb-22f0-4ee5-9550-bc716debd4aa@kernel.org> (raw)
In-Reply-To: <Zo+cDxiog/IXdt9S@hu-varada-blr.qualcomm.com>
On 11/07/2024 10:47, Varadarajan Narayanan wrote:
> On Thu, Jul 11, 2024 at 09:47:23AM +0200, Krzysztof Kozlowski wrote:
>> On 11/07/2024 08:56, Varadarajan Narayanan wrote:
>>> IPQ5332 has only three interrupts. Update min items
>>> accordingly for interrupt names to fix the following
>>> dt_binding_check errors.
>>>
>>> interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
>>>
>>> Fixes: a5c7592366af ("dt-bindings: usb: qcom,dwc3: add SC8280XP binding")
>>
>> There is no ipq5332 at this commit, so I do not understand which bug are
>> you fixing.
>
> a5c7592366af introduced this interrupt and interrupt-names block. Later, 53c6d854be4e9 added ipq5332 to this section. Since a5c7592366af introduced the maxItems and I wanted to include minItems also (to accomodate ipq5332) I used a5c7592366af in the fixes tag. Will 53c6d854be4e9 be a more appropriate choice?
At least a5c7592366af cannot be, because there is no bug in
a5c7592366af. Otherwise please explain what bug is present at time of
a5c7592366af?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-11 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 6:56 [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info Varadarajan Narayanan
2024-07-11 6:56 ` [PATCH v0 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb Varadarajan Narayanan
2024-07-11 7:47 ` [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info Krzysztof Kozlowski
2024-07-11 8:47 ` Varadarajan Narayanan
2024-07-11 9:03 ` Krzysztof Kozlowski [this message]
2024-07-11 9:03 ` Krzysztof Kozlowski
2024-07-11 9:28 ` Varadarajan Narayanan
2024-07-11 8:31 ` Rob Herring (Arm)
2024-07-11 14:22 ` Rob Herring
2024-07-17 9:51 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a908a3fb-22f0-4ee5-9550-bc716debd4aa@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).