From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51BD4358BB for ; Wed, 25 Oct 2023 21:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jwAbudX9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB8DC433C7; Wed, 25 Oct 2023 21:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698270359; bh=D7K9D5FkQxgI+SxQC2ZWcKW+hmigiiDTP+3F/4Ccoos=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=jwAbudX9bC9v0VbbXMfuHgmVqzQuXUqOLU4dWO87PvFwb66c9JF6EgyOGqeih7bFH q2p1WxFlZKTO+rZjt6AbBHWETd6deW6TIHCCwSAmXK1kRu8Z8d9vKc57NVM1RFD0nI L5uSZMNQyxs4/aZBM+y7/J0HixEBFgODVTU8C9b72h5GFif1AK+AMT9KfNvldB9eWr e2PgGWY/WL9bdWHOfmbOlzzGxTQoo1V3sLhkU9fnF/uwSjHIkx6ewHc4Y3znTDQcrB yEbKCuKGrzhc17pwd0MoFyzRx/LpCBR5+iWCJNqlZsbJBPSTo3mscgBR/vRo6YVXA6 z0PblSkximmiw== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231025-topic-sm8650-upstream-clocks-v1-8-c89b59594caf@linaro.org> References: <20231025-topic-sm8650-upstream-clocks-v1-0-c89b59594caf@linaro.org> <20231025-topic-sm8650-upstream-clocks-v1-8-c89b59594caf@linaro.org> Subject: Re: [PATCH 08/10] clk: qcom: add the SM8650 Display Clock Controller driver From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong To: Andy Gross , Bjorn Andersson , Conor Dooley , Konrad Dybcio , Krzysztof Kozlowski , Michael Turquette , Neil Armstrong , Philipp Zabel , Rob Herring , Taniya Das Date: Wed, 25 Oct 2023 14:45:57 -0700 User-Agent: alot/0.10 Quoting Neil Armstrong (2023-10-25 00:32:45) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index c04b6526f4f3..5bf25e8d033c 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -842,6 +842,15 @@ config SM_DISPCC_8550 > Say Y if you want to support display devices and functionality = such as > splash screen. > =20 > +config SM_DISPCC_8650 > + tristate "SM8650 Display Clock Controller" > + depends on SM_GCC_8650 selects? We use selects instead of depends so that the driver can be built-in or modular regardless of parent clks that provide clks to this device. Orphan clk handling resolves issues with the driver registering clks before parents. And with fw_devlink the driver isn't even attempted to probe before the GCC driver is probed so there's no build dependency between these drivers. > + help > + Support for the display clock controller on Qualcomm Technologi= es, Inc > + SM8650 devices. > + Say Y if you want to support display devices and functionality = such as > + splash screen. > + > config SM_GCC_4450 > tristate "SM4450 Global Clock Controller" > depends on ARM64 || COMPILE_TEST > diff --git a/drivers/clk/qcom/dispcc-sm8650.c b/drivers/clk/qcom/dispcc-s= m8650.c > new file mode 100644 > index 000000000000..7cb91306e895 > --- /dev/null > +++ b/drivers/clk/qcom/dispcc-sm8650.c > @@ -0,0 +1,1806 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2023, Linaro Ltd. > + */ > + > +#include Is this include used? > +#include > +#include > +#include > +#include > +#include Is this mod_devicetable.h? > +#include Is this include used? > +#include > +#include > + > +#include > + > +#include "common.h" > +#include "clk-alpha-pll.h" > +#include "clk-branch.h" > +#include "clk-pll.h" > +#include "clk-rcg.h" > +#include "clk-regmap.h" > +#include "clk-regmap-divider.h" > +#include "clk-regmap-mux.h" Is this include used? > +#include "reset.h" > +#include "gdsc.h" > +