From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Simek, Michal" <michal.simek@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"Buddhabhatti, Jay" <jay.buddhabhatti@amd.com>,
"Kundanala, Praveen Teja" <praveen.teja.kundanala@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"saikrishna12468@gmail.com" <saikrishna12468@gmail.com>,
"git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform
Date: Tue, 13 Aug 2024 12:14:39 +0200 [thread overview]
Message-ID: <a93b8d25-1bec-4a6f-9cb2-e8c59b923180@linaro.org> (raw)
In-Reply-To: <BY5PR12MB4258AE889108439ECAA4B1C2DB862@BY5PR12MB4258.namprd12.prod.outlook.com>
On 13/08/2024 07:40, Potthuri, Sai Krishna wrote:
>> sd1_wp_0_grp, sd1_wp_1_grp,
>>> + ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,
>> qspi0_fbclk_0_grp, qspi0_ss_0_grp,
>>> + test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
>>> + maxItems: 78
>>
>> You miss minItems... I have doubts this was really tested.
> groups/pins are mentioned as required property.
> Do we still need to define minItems?
These are two unrelated concepts. How many items can be listed at once
in each property?
>
> ....
>
>>> +
>>> + drive-strength:
>>
>> drive-strength-microamp
> In this case, values are in mA.
Ah, no, if it is mA, then existing property is correct.
> Do we still need to use drive-strength-microamp?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-13 10:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:00 [PATCH v3 0/3] pinctrl: pinctrl-zynqmp: Add Versal platform support Sai Krishna Potthuri
2024-08-01 12:00 ` [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform Sai Krishna Potthuri
2024-08-05 10:07 ` Krzysztof Kozlowski
2024-08-07 5:48 ` Potthuri, Sai Krishna
2024-08-08 5:53 ` Potthuri, Sai Krishna
2024-08-10 13:35 ` Krzysztof Kozlowski
2024-08-13 5:40 ` Potthuri, Sai Krishna
2024-08-13 10:14 ` Krzysztof Kozlowski [this message]
2024-08-13 16:01 ` Potthuri, Sai Krishna
2024-08-01 12:00 ` [PATCH v3 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID Sai Krishna Potthuri
2024-08-01 12:00 ` [PATCH v3 3/3] pinctrl: pinctrl-zynqmp: Add support for Versal platform Sai Krishna Potthuri
2024-08-04 14:49 ` [PATCH v3 0/3] pinctrl: pinctrl-zynqmp: Add Versal platform support Krzysztof Kozlowski
2024-08-05 8:58 ` Potthuri, Sai Krishna
2024-08-05 10:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a93b8d25-1bec-4a6f-9cb2-e8c59b923180@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jay.buddhabhatti@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=praveen.teja.kundanala@amd.com \
--cc=robh+dt@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).