From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30282BEFE8 for ; Sat, 11 Jul 2026 14:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783780837; cv=none; b=SGdiEeA+zJehdmTODf5zUQocv1EsVK3V73leewJdOJVs5EaMY6Uzt/suS8wkAQENUmRsTVFAGdPwpzAE5ZcFkN1cAQRIIXSAPbDKK91OkmV8H1VCemx+I6prFrwZ5nr+Z9nts8xySasM6FCUQxBaoUal/dzUOf+XNi18aFfuGR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783780837; c=relaxed/simple; bh=9tEQngaiXFQ6p90XQLZu9+Hlb+ftUsJNMXOIDlcHt1Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k6/bxiyZIGsupzLex/5p+pOXQFabNFpd3q9gHD5uLTplZTqTkgIWx2LPeVG+gmTViWzJ94/K5Nbs3vkORZA+TbQYFdII/XILNToc2AKz6hoXfVi7HHcExgdoYxZ1tvrOsrhw3CJ9+tPtoaeax13z41LCTdS3Ktjrsyd3tej0Fg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=MPtg9XWD; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="MPtg9XWD" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-495c63c41ceso999531b6e.2 for ; Sat, 11 Jul 2026 07:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783780835; x=1784385635; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1w9ieWr9XroIO1XxDfVO0TVOPppCJVnMpU4FYzzgrNE=; b=MPtg9XWDV0VpnvaPqQpCt8aW3ICQydJvTC5FuGx3Myn7HWv9DC8F4C0Vdfq85mRkiW CNmQCWqI6xw0x+8VvmJbCJcvwxu8DhPb5tj76Me3y2u/GCR23e1Nd9fAlwhbz/moMz/I H+h1mfk0KTieAQl+TSLOoZjajaDMoIhy0kLZsEaRp1Fi8AQoHXHcvFG8kAoCgWFaAPu5 F3AFt81ANdpY6p5T5FP2QpTD6h5j+BbkwNMOvYYvf5/GN5Rjukk1XXJu0yxPo7WR1a4z a2q+HS74apXBF+mohkocSRmtgmCAeBDOcBMKKaCtNsVdg88TXEVxL+4prGYcDVQM7+Ul o4Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783780835; x=1784385635; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1w9ieWr9XroIO1XxDfVO0TVOPppCJVnMpU4FYzzgrNE=; b=Cia+qqz0awlBEJtKxZeUUJ/7RykoCBCSEaUrTkDIGECgV7ISsHFaQgpSWnrAmYnJIK u1Xoghs/C7+QgN60tfwDLcxpG/uWoP63De7cC7XHhfnxrOtICvL4p2pvA9PXWlvMzKHg vW7uXo0m9YwZO4Mw5+PV4AN9Xsj2j9EzQ34l9BLjXsj11Bc0opIhPpuDsJE66PPtBmW8 cikRRR3wCkNFAXW5WheU0DAEMYNFyZrNB0PKJzzosuqNEC1Gb9CCy1S6fBAHYXE+LDgZ 3cV0+GzCNIttBNECgOt3/cr2DAWA81/SAWNKK2SFowzwC7SdnrOLJFRzKIfAfz9/PZ4X Nrrg== X-Forwarded-Encrypted: i=1; AFNElJ8mps9i1IzmZwwWIbC3YivqYTIRm5tN470pTmBdP/10depv7ywmZsuULJHOLBvbiXueRcjS23cxEWib@vger.kernel.org X-Gm-Message-State: AOJu0YwIHDete1iQRFUgZ/V+yYbAMh/TYHCdp1kwqpUvhuN5DNO9bDbf lRVcZSE94hmzSlZ8edIKf3pgSKrpOnJuoFpO/XaOqOaH95jVBF93Y3lJ6NbMnYsjZP0= X-Gm-Gg: AfdE7clWLKEoX4Z8VuexPel6f/UE6vP7RorT+Bil6Ic242c6jsJBjPYHixITXrcHupZ 2v5eS7B8NmMzqJDo5ZZnYOvjN1PVe8Gxnr9rWCLy0Hw99SyEi/Q2E6NzjisRwPNUyJsDu8wQrcw j3xh/bvHcjfjIMrYjGPZSi5oa++AZld2kT2Fzt7lSZg1tS5F7RQ1ufIZ/cWeOqjT2oyyYgJ8BMR wUX14GfH6J/yFxPmGpEOLUQjsOMmKjiIdeQZp8XzKS/4F4Yf8D94gLyhgcmRfAGB1u9iD+Db/et PqfiNvEkCCN4Y25xnU8UJLHpWEV+aRfAzFGI46AEwnaFS9SXXh543m+26W97tZUoa2DctgH1HRo Ngg4eh4CftEolAWyMCHQKF5s1ymXGhOWVlBObxam+OQ0QDNwurWqv00kdvidqWib+ro/RJE4/jJ GZMOQO0wfZ8f3360FQJsNvKhUd8TQr/BtnNSGkpfx+X8IdchWSQ/VT75dWTEvA4lE= X-Received: by 2002:a05:6808:178f:b0:495:da89:c578 with SMTP id 5614622812f47-4a42ace7138mr2433350b6e.9.1783780834868; Sat, 11 Jul 2026 07:40:34 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:a950:74e5:81f2:8c89? ([2600:8803:e7e4:500:a950:74e5:81f2:8c89]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1afbf92b1sm7672879b6e.10.2026.07.11.07.40.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 07:40:33 -0700 (PDT) Message-ID: Date: Sat, 11 Jul 2026 09:40:32 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 To: Jonathan Cameron Cc: Janani Sunil , =?UTF-8?Q?Nuno_S=C3=A1?= , Michael Hennerich , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Philipp Zabel , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Shuah Khan , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, jananisunil.dev@gmail.com References: <20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com> <20260709-ad7768-driver-v1-1-44e1194fd96a@analog.com> <36df7c4f-82ea-4ed5-a4f9-3a29c75dc99a@baylibre.com> <20260710013322.595f8ee4@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260710013322.595f8ee4@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/9/26 7:33 PM, Jonathan Cameron wrote: >>> + adi,common-mode-output: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + enum: >>> + - avdd-avss-half >>> + - 1.65V >>> + - 2.5V >>> + - 2.14V >>> + description: >>> + Common mode voltage output selection. >> >> Why not using standard regulator provider bindings for this? > > Interesting question. If that was done there would need to be > a consumer which means explicit modelling of any analog circuit. > We do that in a few cases but so far (and yup this is a driver thing > in a dt-binding) I don't think we have any way to consumer data when > a backend is involved. There is also the regulator-always-on property, so strictly speaking, a consumer is not required. > >> >>> + >>> + adi,vcm-power-down: >>> + type: boolean >>> + description: Power down the common mode output buffer >> >> Is the buffer separate from the output? In that case I would expect >> buffer to be in the property name, otherwise this should just be >> part of the enum options above (and the default one at that). >>