* [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM
2023-09-04 17:25 [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Vignesh Viswanathan
@ 2023-09-04 17:25 ` Vignesh Viswanathan
2023-09-06 9:52 ` Konrad Dybcio
2023-09-04 17:25 ` [PATCH v2 2/4] arm64: dts: qcom: ipq6018: " Vignesh Viswanathan
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Vignesh Viswanathan @ 2023-09-04 17:25 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, Vignesh Viswanathan, stable
SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
in SMEM region shared by the Host and FW.
Fix the SMEM hwlock index to 3 for IPQ5332.
Cc: stable@vger.kernel.org
Fixes: d56dd7f935e1 ("arm64: dts: qcom: ipq5332: add SMEM support")
Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 1abc992ede31..a47c79c3d5f0 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -135,7 +135,7 @@ smem@4a800000 {
reg = <0x0 0x4a800000 0x0 0x100000>;
no-map;
- hwlocks = <&tcsr_mutex 0>;
+ hwlocks = <&tcsr_mutex 3>;
};
q6_region: wcnss@4a900000 {
--
2.41.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM
2023-09-04 17:25 ` [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM Vignesh Viswanathan
@ 2023-09-06 9:52 ` Konrad Dybcio
2023-09-06 11:23 ` Vignesh Viswanathan
0 siblings, 1 reply; 12+ messages in thread
From: Konrad Dybcio @ 2023-09-06 9:52 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 4.09.2023 19:25, Vignesh Viswanathan wrote:
> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
> in SMEM region shared by the Host and FW.
>
> Fix the SMEM hwlock index to 3 for IPQ5332.
>
> Cc: stable@vger.kernel.org
> Fixes: d56dd7f935e1 ("arm64: dts: qcom: ipq5332: add SMEM support")
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> ---
Your downstream says otherwise [1]. Perhaps you need to fix it there
as well?
Konrad
[1] https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.4.r1/arch/arm64/boot/dts/qcom/ipq5332.dtsi
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM
2023-09-06 9:52 ` Konrad Dybcio
@ 2023-09-06 11:23 ` Vignesh Viswanathan
2023-09-06 11:26 ` Konrad Dybcio
0 siblings, 1 reply; 12+ messages in thread
From: Vignesh Viswanathan @ 2023-09-06 11:23 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 9/6/2023 3:22 PM, Konrad Dybcio wrote:
> On 4.09.2023 19:25, Vignesh Viswanathan wrote:
>> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
>> in SMEM region shared by the Host and FW.
>>
>> Fix the SMEM hwlock index to 3 for IPQ5332.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: d56dd7f935e1 ("arm64: dts: qcom: ipq5332: add SMEM support")
>> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>> ---
> Your downstream says otherwise [1]. Perhaps you need to fix it there
> as well?
>
Yes, the fix is already merged in the downstream branch but CLO is not
updated date yet.
Thanks,
Vignesh
> Konrad
>
> [1] https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.4.r1/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM
2023-09-06 11:23 ` Vignesh Viswanathan
@ 2023-09-06 11:26 ` Konrad Dybcio
0 siblings, 0 replies; 12+ messages in thread
From: Konrad Dybcio @ 2023-09-06 11:26 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 6.09.2023 13:23, Vignesh Viswanathan wrote:
>
>
> On 9/6/2023 3:22 PM, Konrad Dybcio wrote:
>> On 4.09.2023 19:25, Vignesh Viswanathan wrote:
>>> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
>>> in SMEM region shared by the Host and FW.
>>>
>>> Fix the SMEM hwlock index to 3 for IPQ5332.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: d56dd7f935e1 ("arm64: dts: qcom: ipq5332: add SMEM support")
>>> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>> ---
>> Your downstream says otherwise [1]. Perhaps you need to fix it there
>> as well?
>>
>
> Yes, the fix is already merged in the downstream branch but CLO is not
> updated date yet.
Ok
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 2/4] arm64: dts: qcom: ipq6018: Fix hwlock index for SMEM
2023-09-04 17:25 [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Vignesh Viswanathan
2023-09-04 17:25 ` [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM Vignesh Viswanathan
@ 2023-09-04 17:25 ` Vignesh Viswanathan
2023-09-06 11:26 ` Konrad Dybcio
2023-09-04 17:25 ` [PATCH v3 3/4] arm64: dts: qcom: ipq8074: " Vignesh Viswanathan
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Vignesh Viswanathan @ 2023-09-04 17:25 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, Vignesh Viswanathan, stable
SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
in SMEM region shared by the Host and FW.
Fix the SMEM hwlock index to 3 for IPQ6018.
Cc: stable@vger.kernel.org
Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 9793279e2ced..264845cecf92 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -211,7 +211,7 @@ q6_region: memory@4ab00000 {
smem {
compatible = "qcom,smem";
memory-region = <&smem_region>;
- hwlocks = <&tcsr_mutex 0>;
+ hwlocks = <&tcsr_mutex 3>;
};
soc: soc@0 {
--
2.41.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: qcom: ipq6018: Fix hwlock index for SMEM
2023-09-04 17:25 ` [PATCH v2 2/4] arm64: dts: qcom: ipq6018: " Vignesh Viswanathan
@ 2023-09-06 11:26 ` Konrad Dybcio
0 siblings, 0 replies; 12+ messages in thread
From: Konrad Dybcio @ 2023-09-06 11:26 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 4.09.2023 19:25, Vignesh Viswanathan wrote:
> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
> in SMEM region shared by the Host and FW.
>
> Fix the SMEM hwlock index to 3 for IPQ6018.
>
> Cc: stable@vger.kernel.org
> Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 3/4] arm64: dts: qcom: ipq8074: Fix hwlock index for SMEM
2023-09-04 17:25 [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Vignesh Viswanathan
2023-09-04 17:25 ` [PATCH v2 1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM Vignesh Viswanathan
2023-09-04 17:25 ` [PATCH v2 2/4] arm64: dts: qcom: ipq6018: " Vignesh Viswanathan
@ 2023-09-04 17:25 ` Vignesh Viswanathan
2023-09-06 11:27 ` Konrad Dybcio
2023-09-04 17:25 ` [PATCH v2 4/4] arm64: dts: qcom: ipq9574: " Vignesh Viswanathan
2023-09-20 3:58 ` (subset) [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Bjorn Andersson
4 siblings, 1 reply; 12+ messages in thread
From: Vignesh Viswanathan @ 2023-09-04 17:25 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, Vignesh Viswanathan, stable
SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
in SMEM region shared by the Host and FW.
Fix the SMEM hwlock index to 3 for IPQ8074.
Cc: stable@vger.kernel.org
Fixes: 42124b947e8e ("arm64: dts: qcom: ipq8074: add SMEM support")
Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 00ed71936b47..92fd924bbdbe 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -101,7 +101,7 @@ smem@4ab00000 {
reg = <0x0 0x4ab00000 0x0 0x100000>;
no-map;
- hwlocks = <&tcsr_mutex 0>;
+ hwlocks = <&tcsr_mutex 3>;
};
memory@4ac00000 {
--
2.41.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 3/4] arm64: dts: qcom: ipq8074: Fix hwlock index for SMEM
2023-09-04 17:25 ` [PATCH v3 3/4] arm64: dts: qcom: ipq8074: " Vignesh Viswanathan
@ 2023-09-06 11:27 ` Konrad Dybcio
0 siblings, 0 replies; 12+ messages in thread
From: Konrad Dybcio @ 2023-09-06 11:27 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 4.09.2023 19:25, Vignesh Viswanathan wrote:
> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
> in SMEM region shared by the Host and FW.
>
> Fix the SMEM hwlock index to 3 for IPQ8074.
>
> Cc: stable@vger.kernel.org
> Fixes: 42124b947e8e ("arm64: dts: qcom: ipq8074: add SMEM support")
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: ipq9574: Fix hwlock index for SMEM
2023-09-04 17:25 [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Vignesh Viswanathan
` (2 preceding siblings ...)
2023-09-04 17:25 ` [PATCH v3 3/4] arm64: dts: qcom: ipq8074: " Vignesh Viswanathan
@ 2023-09-04 17:25 ` Vignesh Viswanathan
2023-09-06 11:27 ` Konrad Dybcio
2023-09-20 3:58 ` (subset) [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Bjorn Andersson
4 siblings, 1 reply; 12+ messages in thread
From: Vignesh Viswanathan @ 2023-09-04 17:25 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, Vignesh Viswanathan, stable
SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
in SMEM region shared by the Host and FW.
Fix the SMEM hwlock index to 3 for IPQ9574.
Cc: stable@vger.kernel.org
Fixes: 46384ac7a618 ("arm64: dts: qcom: ipq9574: Add SMEM support")
Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index f22f7e78850d..cc0e4a2b67d2 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -195,7 +195,7 @@ tz_region: tz@4a600000 {
smem@4aa00000 {
compatible = "qcom,smem";
reg = <0x0 0x4aa00000 0x0 0x100000>;
- hwlocks = <&tcsr_mutex 0>;
+ hwlocks = <&tcsr_mutex 3>;
no-map;
};
--
2.41.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: ipq9574: Fix hwlock index for SMEM
2023-09-04 17:25 ` [PATCH v2 4/4] arm64: dts: qcom: ipq9574: " Vignesh Viswanathan
@ 2023-09-06 11:27 ` Konrad Dybcio
0 siblings, 0 replies; 12+ messages in thread
From: Konrad Dybcio @ 2023-09-06 11:27 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 4.09.2023 19:25, Vignesh Viswanathan wrote:
> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
> in SMEM region shared by the Host and FW.
>
> Fix the SMEM hwlock index to 3 for IPQ9574.
>
> Cc: stable@vger.kernel.org
> Fixes: 46384ac7a618 ("arm64: dts: qcom: ipq9574: Add SMEM support")
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: (subset) [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms
2023-09-04 17:25 [PATCH v2 0/4] Fix SMEM hwlock index for IPQ platforms Vignesh Viswanathan
` (3 preceding siblings ...)
2023-09-04 17:25 ` [PATCH v2 4/4] arm64: dts: qcom: ipq9574: " Vignesh Viswanathan
@ 2023-09-20 3:58 ` Bjorn Andersson
4 siblings, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2023-09-20 3:58 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, Vignesh Viswanathan
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada
On Mon, 04 Sep 2023 22:55:11 +0530, Vignesh Viswanathan wrote:
> SMEM uses lock index 3 of the TCSR Mutex hwlock for allocations
> in SMEM region shared by the Host and FW.
>
> Fix the SMEM hwlock index to 3 for IPQ5332, IPQ6018, IPQ8074 and IPQ9574.
>
> Vignesh Viswanathan (4):
> arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM
> arm64: dts: qcom: ipq6018: Fix hwlock index for SMEM
> arm64: dts: qcom: ipq8074: Fix hwlock index for SMEM
> arm64: dts: qcom: ipq9574: Fix hwlock index for SMEM
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: ipq5332: Fix hwlock index for SMEM
commit: d08afd80158399a081b478a19902364e3dd0f84c
[2/4] arm64: dts: qcom: ipq6018: Fix hwlock index for SMEM
commit: 95d97b111e1e184b0c8656137033ed64f2cf21e4
[4/4] arm64: dts: qcom: ipq9574: Fix hwlock index for SMEM
commit: 5fe8508e2bc8eb4208b0434b6c1ca306c1519ade
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread