devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq8064: pad addresses to 8 digit
Date: Fri, 22 Jul 2022 00:58:40 +0300	[thread overview]
Message-ID: <a975956c-edbb-861c-e352-8a168e7cb536@linaro.org> (raw)
In-Reply-To: <20220718153815.29414-2-ansuelsmth@gmail.com>

On 18/07/2022 18:38, Christian Marangi wrote:
> Pad reg addresses to 8 digit to make sorting easier.

Please put this patch before the patch 1/2. It makes reviewing easier.
Otherwise:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>   arch/arm/boot/dts/qcom-ipq8064.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index cf41d330c920..9405d6167b20 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -348,7 +348,7 @@ vsdcc_fixed: vsdcc-regulator {
>   
>   		rpm: rpm@108000 {
>   			compatible = "qcom,rpm-ipq8064";
> -			reg = <0x108000 0x1000>;
> +			reg = <0x00108000 0x1000>;
>   			qcom,ipc = <&l2cc 0x8 2>;
>   
>   			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
> @@ -389,7 +389,7 @@ tsens_calib_backup: calib_backup@410 {
>   
>   		qcom_pinmux: pinmux@800000 {
>   			compatible = "qcom,ipq8064-pinctrl";
> -			reg = <0x800000 0x4000>;
> +			reg = <0x00800000 0x4000>;
>   
>   			gpio-controller;
>   			gpio-ranges = <&qcom_pinmux 0 0 69>;
> @@ -571,7 +571,7 @@ IRQ_TYPE_EDGE_RISING)>,
>   
>   		l2cc: clock-controller@2011000 {
>   			compatible = "qcom,kpss-gcc", "syscon";
> -			reg = <0x2011000 0x1000>;
> +			reg = <0x02011000 0x1000>;
>   			clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
>   			clock-names = "pll8_vote", "pxo";
>   			clock-output-names = "acpu_l2_aux";


-- 
With best wishes
Dmitry

  reply	other threads:[~2022-07-21 21:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 15:38 [PATCH 1/2] ARM: dts: qcom: ipq8064: reorganize node order and sort them Christian Marangi
2022-07-18 15:38 ` [PATCH 2/2] ARM: dts: qcom: ipq8064: pad addresses to 8 digit Christian Marangi
2022-07-21 21:58   ` Dmitry Baryshkov [this message]
2022-07-19  9:56 ` [PATCH 1/2] ARM: dts: qcom: ipq8064: reorganize node order and sort them Krzysztof Kozlowski
2022-07-19  7:55   ` Christian Marangi
2022-07-19  9:59   ` Dmitry Baryshkov
2022-07-19 10:16     ` Krzysztof Kozlowski
2022-07-19 10:22       ` Konrad Dybcio
2022-07-19  8:19         ` Christian Marangi
2022-07-19 10:27           ` Konrad Dybcio
2022-07-19 10:56           ` Krzysztof Kozlowski
2022-07-19  8:57             ` Christian Marangi
2022-07-19 11:14               ` Krzysztof Kozlowski
2022-07-19  9:12                 ` Christian Marangi
2022-07-19 11:15             ` Konrad Dybcio
2022-07-19 11:52               ` Krzysztof Kozlowski
2022-07-21 21:57 ` Dmitry Baryshkov
2022-08-08 14:07 ` Christian Marangi
2022-09-14  3:37   ` Bjorn Andersson
2022-09-15  3:36 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a975956c-edbb-861c-e352-8a168e7cb536@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).