From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03595C43331 for ; Fri, 3 Apr 2020 16:33:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8578207FF for ; Fri, 3 Apr 2020 16:33:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vF6AKxYe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404511AbgDCQd3 (ORCPT ); Fri, 3 Apr 2020 12:33:29 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38321 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403834AbgDCQd3 (ORCPT ); Fri, 3 Apr 2020 12:33:29 -0400 Received: by mail-lj1-f194.google.com with SMTP id v16so7599103ljg.5; Fri, 03 Apr 2020 09:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4fDqTfkx4s/hoWco9IqQyOBi9hVMRkMxaYHCSQZz32M=; b=vF6AKxYepfMhz5KpdLRqBl8CgNcVtORl6kJUjZJayifDV6bxqGps7ImjAQKwJbOlrS k9ciAI3kr7UIjYuY9SqAtT5xDq1BodDkf7WV3d21RDhw/vUSDU/R/+vfp28LJOUGiVvf 9jM0Rkjyv77OPDhsRQnGiiF//0durL6UxULWWmZ01e8nrXST2Ey/59OLk1nLbuBDZzRB h/8JsxtPQlyMjNEOlpHkSSmmC1zOvWMk5wpQgn9FbYxYHosCmve8tpWc094QOW40l03j ks9QMZz8Y2CNsMaaJl7qgKmpmXaCDxzqYOSG4C61U2rX64kF6mfmrw/cx8DxobcthKhA nBfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4fDqTfkx4s/hoWco9IqQyOBi9hVMRkMxaYHCSQZz32M=; b=ZCDvz9iRGIiYhia6IVQjuq9YWFgs/dzpyjK5qSAqype3Xi68tEqHrkumOlvHcanBEK S/QfsYQEsXiqzxp9WZXkEKvnOZLT8Eo0jfeazAfw1pBUxQoIgna14FEJ3FzdifiExUTO m8VRcqHBuYOLxaJnXewupCSyZoBg9zcbrAgJkFVbaumrYgdLvt2p+hzxPhLw2kU/AyDW sw/QiauUFG6vGg3W4S7Cp3JizdmVj3mTWvmjs5X0h04RxbGkbImgGdGFvEqcabTExLu5 s4odCrm8htOaM/5bZKBC/SGcruFolafZ0vz67ZR4di45hwyp3XwYtDkvH5Jlatir72Sg 7hDA== X-Gm-Message-State: AGi0PuYrUhLd0mMxGRSgpe0kfjhXY/lWxKC85uVP3Tc2pP0iryp+zQw6 Lj1suLB69Ad7GAkAbCJFDR72hAv5 X-Google-Smtp-Source: APiQypLnWZ1KmknHBadkRmdgO5AzNTC3XSpWvhGXSGcwm9CpVCHEEsqOzJu59kBa5vQS7OIIbP/ZEA== X-Received: by 2002:a2e:8015:: with SMTP id j21mr5128664ljg.165.1585931606195; Fri, 03 Apr 2020 09:33:26 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id d12sm6007971lfi.86.2020.04.03.09.33.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 09:33:25 -0700 (PDT) Subject: Re: [PATCH v2 2/7] clocksource: Add Tegra186 timers support To: Thierry Reding , Daniel Lezcano , Thomas Gleixner Cc: Rob Herring , Jon Hunter , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200331221914.2966407-1-thierry.reding@gmail.com> <20200331221914.2966407-3-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 3 Apr 2020 19:33:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200331221914.2966407-3-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 01.04.2020 01:19, Thierry Reding пишет: ... > +static int tegra186_timer_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct tegra186_timer *tegra; > + int err; > + > + tegra = devm_kzalloc(dev, sizeof(*tegra), GFP_KERNEL); > + if (!tegra) > + return -ENOMEM; > + > + tegra->soc = of_device_get_match_data(dev); > + dev_set_drvdata(dev, tegra); > + tegra->dev = dev; > + > + tegra->regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(tegra->regs)) > + return PTR_ERR(tegra->regs); > + > + err = platform_get_irq(pdev, 0); > + if (err < 0) { > + dev_err(dev, "failed to get interrupt #0: %d\n", err); > + return err; > + } > + > + tegra->irq = err; > + > + err = devm_request_irq(dev, tegra->irq, tegra186_timer_irq, > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > + "tegra186-timer", tegra); Looks like there is no need to store tegra->irq in the struct tegra186_timer.