From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F64C4321E for ; Wed, 9 Nov 2022 11:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbiKILUv (ORCPT ); Wed, 9 Nov 2022 06:20:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbiKILUn (ORCPT ); Wed, 9 Nov 2022 06:20:43 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C9A329803 for ; Wed, 9 Nov 2022 03:20:41 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id d20so25230535ljc.12 for ; Wed, 09 Nov 2022 03:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=88yTM1uJKEU4nUryrFzcHBneq7U0QfCFix/2TI4Onpk=; b=DfkZOEZylfFUnSWpURoh/sz7HSBi78Kh0RQ7SssObIac18QqVqnmtclaK6tpj9/Czv JBWGdhgT+SmtmlSSh92nInbwROaBgh3JSgt7eTSJ3jxcKHn5yrKoqvmWar3FimbjYLwQ F/tFC4zzeXf4IKywa7ksSp2XWOHlyVcSU6Ytd7CWzdcfGWDzlr5X6oBCnZZFcdo4yKcm SH617uPem+06DdgPb0Vl7tv7YF/FY7A4OkmnNPUblYpuSijCVUdOrMUgYwohWfqAQciM P4fgTN0iJypSm6BI6nmFPhOQjUf37bzOiz5SxHWS9NozP+K7ucNmD4TX4Id5KQU5N7eT ysOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=88yTM1uJKEU4nUryrFzcHBneq7U0QfCFix/2TI4Onpk=; b=rjd73VHdq9svWZ8q7+3X0bqjJwrF113m7sE2WaXWbNOxI4/FoO46H3Sb5HVJSxeZf5 pKwZIwFSnkRCx0mk2gd3oY9OxclG33oLMS5E0QGQpMjYfXZ7r0V/6YtfybcnWjRgUvvJ JLRyI5r9WMJmUFitV3AB4BEuk2sZkuIxHyEl4Iy6DmVUwdz5is7MfjGNC/6WCs7DqtDE 6aly7m76HtUkfbtUBjDqrMJWQyX/kCWeq6/PAWrdUtIV0+/pgd4TEhOQRLhNZvH24HOf jiKfCIpxOs/uAHokRccLILJtr7sdIJXRR9qImsJ2ksd/78e74X/OIHaBuJKah50o7ezg /R2w== X-Gm-Message-State: ACrzQf3UaPL15pgmliK5RQ12TvSDzBlUixEj/60JPZtu8UJYjNeNtod7 fdUJWSLa1zEZiQTLp/XiWYSJUg== X-Google-Smtp-Source: AMsMyM7gOlyu5kF/XFyAzve3EYtqXVo+h9qSupfEhKOd0KIj7d1NxKjvrTEy/mIcW1/4AID0bhfUSA== X-Received: by 2002:a2e:6e13:0:b0:26d:f70e:3415 with SMTP id j19-20020a2e6e13000000b0026df70e3415mr7962169ljc.216.1667992839869; Wed, 09 Nov 2022 03:20:39 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id bd22-20020a05651c169600b0027703e09b71sm2066440ljb.64.2022.11.09.03.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 03:20:39 -0800 (PST) Message-ID: Date: Wed, 9 Nov 2022 12:20:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 5/6] can: m_can: Add ECC functionality for message RAM Content-Language: en-US To: Vivek Yadav , rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org, wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pankaj.dubey@samsung.com, ravi.patel@samsung.com, alim.akhtar@samsung.com, linux-fsd@tesla.com, robh+dt@kernel.org Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, aswani.reddy@samsung.com, sriranjani.p@samsung.com References: <20221109100928.109478-1-vivek.2311@samsung.com> <20221109100928.109478-6-vivek.2311@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221109100928.109478-6-vivek.2311@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2022 11:09, Vivek Yadav wrote: > Whenever MCAN Buffers and FIFOs are stored on message ram, there are > inherent risks of corruption known as single-bit errors. > > Enable error correction code (ECC) data integrity check for Message RAM > to create valid ECC checksums. > > ECC uses a respective number of bits, which are added to each word as a > parity and that will raise the error signal on the corruption in the > Interrupt Register(IR). > > This indicates either bit error detected and Corrected(BEC) or No bit > error detected when reading from Message RAM. > > Signed-off-by: Chandrasekar R > Signed-off-by: Vivek Yadav (...) > > +static int m_can_plat_init(struct m_can_classdev *cdev) > +{ > + struct m_can_ecc_regmap *ecc_cfg = &cdev->ecc_cfg_sys; > + struct device_node *np = cdev->dev->of_node; > + int ret = 0; > + > + if (cdev->mram_cfg_flag != ECC_ENABLE) { > + /* Initialize mcan message ram */ > + ret = m_can_init_ram(cdev); > + > + if (ret) > + return ret; > + > + cdev->mram_cfg_flag = ECC_ENABLE; > + } > + > + if (ecc_cfg->ecc_cfg_flag != ECC_ENABLE) { > + /* configure error code check for mram */ > + if (!ecc_cfg->syscon) { > + ecc_cfg->syscon = > + syscon_regmap_lookup_by_phandle_args(np, > + "tesla,mram-ecc-cfg" > + , 1, , goes to previous line > + &ecc_cfg->reg); > + } > + > + if (IS_ERR(ecc_cfg->syscon)) { > + dev_err(cdev->dev, "couldn't get the syscon reg!\n"); Didn't you just break all platforms using ECC? Best regards, Krzysztof