From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1C6C7EE23 for ; Thu, 8 Jun 2023 11:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234262AbjFHLqD (ORCPT ); Thu, 8 Jun 2023 07:46:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbjFHLqC (ORCPT ); Thu, 8 Jun 2023 07:46:02 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBE7D2726 for ; Thu, 8 Jun 2023 04:45:35 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5151934a4e3so748671a12.1 for ; Thu, 08 Jun 2023 04:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686224731; x=1688816731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AbhAghjawLzBEcXZUXbPe6opYRFvtRyYlpt+uKgziIg=; b=TvZwH3IlT2VEyjrc9IouFpTmIIY5a7r2X4e+92fqyZgenAl5p7XwVzkxHF/OR0wDy3 1F0GXmqcEr/CLJWaNMfCbbh7y8yUnRSpBUQ4KGKvG4++N86bFyNxcq0GfCcK2iBk4Z45 cMkEDfnGtCfDtvS39y5T9u47ixRq2cq3YI+x5jNxwLHuPHRjHDVq/doOs6VI2UntzJZ/ CpzrA+2wlyDPPu3xGg6GtOqYhPqzYfjG+yk5b0UnoQUFzExos/zTiJDhMj6ugJ2/UZY+ ZbOHdM6XRoXMJ4xs3r3iKCtFy8wGge58Cuu2ARJ+8oQN5SgEomnCSW0F3K+NtyxAb9CE 5m6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686224731; x=1688816731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AbhAghjawLzBEcXZUXbPe6opYRFvtRyYlpt+uKgziIg=; b=dfJegLeUDZ1HunMDZxRccXytTjbQQQMzCfNVgU+drTkmFkeVyzRmELdoKVah9/MVlm C3h+7ZHoQeu5m9tZDeFqq9rbIrLe1xIckm0INrUtcQw1qgdWwZ9YMvhiJjT5PIKHA6Jp 3I8Zqhddf7aWKgybOdh3/Jrb91JdNdEjY0o1N8Pa9eCAYopqx5W7Ni9JBUhIflRbe/RT fMrHpb0WY1NCU0MxqMzWz22BkFO8hXEYpvg0UJQkQ6ixEqvcSPYekAVjhWEDLxw1xymS Z4QZSDAJvsGopZrET4zCA3+dEeyXRFudtD0DrQHw/FEqwbE+Rr4xUovEA3XxxK/HvpQG BIPg== X-Gm-Message-State: AC+VfDxOwdg+1gBFMwndDbU95C316nMS91MPs62Cap+xHdxb4yfEgUvn bkydbwdC84PEwdbJMo9R19WX+w== X-Google-Smtp-Source: ACHHUZ5HmtzT2HmzwjEKYaHiDYcKIMmjjNdcI7Au+tLjgnldEAp2UvNxsmqjrhD4TDXuZihM4yzoNQ== X-Received: by 2002:aa7:c9d0:0:b0:50d:9e7c:264d with SMTP id i16-20020aa7c9d0000000b0050d9e7c264dmr7855652edt.8.1686224731465; Thu, 08 Jun 2023 04:45:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m8-20020a056402050800b005149cb5ee2dsm449662edv.82.2023.06.08.04.45.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 04:45:30 -0700 (PDT) Message-ID: Date: Thu, 8 Jun 2023 13:45:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings Content-Language: en-US To: zhuyinbo , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230608072819.25930-1-zhuyinbo@loongson.cn> <20230608072819.25930-2-zhuyinbo@loongson.cn> <6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org> <4bf747c4-b767-b20c-e00f-724b50f44edb@loongson.cn> <6bfc2a22-6901-0858-7b90-bc4c52c66810@linaro.org> <11ca2b90-544d-18c2-fb15-7909ca60507f@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/06/2023 13:42, zhuyinbo wrote: >> >>> It can work was for ls2k1000 and ls2k0500 and it specifically refers to >>> spi driver. but 2k0500 doesn't implementing a clock driver and doesn't >> >> We do not discuss here drivers, but bindings. Whatever your drivers are >> not supporting, matters less. >> >>> use CCF to gain clock but can use "clock-frequency". Is it necessary to >>> obtain a clock based on CCF? If it's necessary, then it seems that it >>> can only added 2k1000 spi first. >> >> Not related to bindings... > > > I may understand that what you said, and the dt-bindings only cover > hardware and not involve the drivers. if so, I will add following: > > > --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml > @@ -16,6 +16,7 @@ properties: > compatible: > enum: > - loongson,ls2k1000-spi > + - loongson,ls2k0500-spi Aren't they compatible? Best regards, Krzysztof