From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0727C433F5 for ; Fri, 25 Feb 2022 14:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241320AbiBYOqb (ORCPT ); Fri, 25 Feb 2022 09:46:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236325AbiBYOqb (ORCPT ); Fri, 25 Feb 2022 09:46:31 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 740201FED91 for ; Fri, 25 Feb 2022 06:45:58 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id d28so4888452wra.4 for ; Fri, 25 Feb 2022 06:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=E2KBLCt5EUZGzk+Usn3XihfCPrZhBOOrY51X7LrK7+k=; b=qXPQ22tV8hTTCcl41nRsOM+yEDKLu6F+sX7eggV8btG+ttAyeag+/smAXDaccEVwh8 8hT97NeqhDOWyoFlu3uYrZERJBPLT5mfw/W2aPC62sHsW62KPXNicC2N7MhFRZE+VvTX yerCV8iNh55UQdYNyhuHtlxQG+d+wMJ2nQO/YuwiZ8ZGKyo7quLIRg7PPlzbGY/54Uvh P+IwHPuV2qDk3qP0cFtbRh2o2BGi0fLk8f6TxSfOpGp2d8ocxOgpeAZPYafyGEbQrVio dUiuVYI9u1jFxVhbjRl4VgbP9X2ZrP9wx4nBiTpfuLj4olahE8BDssliio3nHDuPM2lX 3VRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=E2KBLCt5EUZGzk+Usn3XihfCPrZhBOOrY51X7LrK7+k=; b=24pWa8JRjEV8A2nGZsLwx0Na/Y0ZftCiLkHc7Ipd83TMAssitI42f75VE4o9sSdn++ X/Zgurq/gS4bt64TzCK5LLAfQDN9PwgEiphjNSWoWUKZ3pMcPWnfHdo5LcBXULjgOwAA pzpbw4tsl/dkEAdy3KyseHWo1q/nmK6n0+GAZ9gGN5GYSOyRLTVM4JuxzXy3sN5NVZhE w6NYJRoe/TwOEEJsEesZAfSKuaZKYi/ESZOizvDQ+PqAbxy3V/1hNiqRHOtINMSeSHsX 9+kCNd1H/JCTc69kfyXgrFHeC62SVsujgn0HPn56qvKgAtGyOeTJooJqKA9In6GtRDQb l7mQ== X-Gm-Message-State: AOAM530pGRG3QwHg9+O/yTncGw8Kd+oI3iV9CEWnAD04qE+IBXXrlFvt uEN/ikJXE70xNFQ6qt6/AipJUw== X-Google-Smtp-Source: ABdhPJz6RLrpiBO57HR1D1S2AAhegwgXjnxzEBfq7K1HVtDG/eVLOECUsNy/0VUn13MGyph69unF6Q== X-Received: by 2002:a5d:59af:0:b0:1e4:a027:ce3b with SMTP id p15-20020a5d59af000000b001e4a027ce3bmr6171844wrr.318.1645800356946; Fri, 25 Feb 2022 06:45:56 -0800 (PST) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id z5-20020a05600c0a0500b0037fa93193a8sm3002294wmp.44.2022.02.25.06.45.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 06:45:56 -0800 (PST) Message-ID: Date: Fri, 25 Feb 2022 14:45:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] soundwire: qcom: remove redundant wait for completion Content-Language: en-US To: Srinivasa Rao Mandadapu , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com Cc: Venkata Prasad Potturu References: <1645800257-27025-1-git-send-email-quic_srivasam@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <1645800257-27025-1-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/02/2022 14:44, Srinivasa Rao Mandadapu wrote: > Remove wait_for_completion_timeout from soundwire probe as it seems > unnecessary and device enumeration is anyway not happening here, > hence this api is blocking till it completes max wait time. > Also, as device enumeration event is dependent on wcd938x probe to be > completed, its of no use waiting here. > Waiting here increasing the boot time almost 4 seconds and impacting > other modules like touch screen. > > Fixes: 06dd96738d618 ("soundwire: qcom: wait for enumeration to be complete in probe") > > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu LGTM, Reviewed-by: Srinivas Kandagatla > --- > drivers/soundwire/qcom.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index 5481341..9a32a24 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) > } > > qcom_swrm_init(ctrl); > - wait_for_completion_timeout(&ctrl->enumeration, > - msecs_to_jiffies(TIMEOUT_MS)); > ret = qcom_swrm_register_dais(ctrl); > if (ret) > goto err_master_add;