From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A68C05027 for ; Fri, 20 Jan 2023 10:19:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbjATKTD (ORCPT ); Fri, 20 Jan 2023 05:19:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjATKTD (ORCPT ); Fri, 20 Jan 2023 05:19:03 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2398D881E9 for ; Fri, 20 Jan 2023 02:19:01 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id t5so4420121wrq.1 for ; Fri, 20 Jan 2023 02:19:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d8BcJzXSs607af8t7kqUBgjRke129BH5lCDD+YUTH7w=; b=LpfSiNltaoV7bWfi3yQR6wIwTKqlLH7Cjtwa/XneNU61Ua5EWCgWLAmqQW4ko0k8hT 7nuNnorRsj8t9/48i19w6P2TUdPkm4CyGE2Yz2+MfpMRt0T7BdOQ55DOkkwsEVlOCXzE hS5JDPHJU3BA2gZU16GZAw37kzK3q/u9bQQ0UtRPyu/TLBIhpD6usPD828f08UdUSxXS YySKUR3JB5bmEdzRIKnZps+lJwVscq4/xFDjvBmGNpVL0ybJO9d2/TfrNZYppcH6tnfS GxiR3AYWsyaulrms7NLKr3R/Ms8Bs/W4errDUbskI+8/qTbdpiSCp4oZIPL+CCIB5nEp T9WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d8BcJzXSs607af8t7kqUBgjRke129BH5lCDD+YUTH7w=; b=umtjewCWUmsKlPIpZquSyYZCYKlER1VaeCn9fBOFqWvjLAVc0Q+VfD3QSi3mQ0GYjU jTyBzg+z8E29thrppsXsoNBzG+PZZ8VwQ+KtNU/woq6UZVEyUGbUaJ6JRR9E/Uq0DupX +2wDojM/7atutOQwhhXifKpiLuB0cCSJYHaXG0JTWhUr9sut1r6AoCK8Sd5SP+5Jp7KK vMpPny/TLV64C93iUqWVNTdbS7SSa9CYw6Fy5xWnKvbA9qVQh1jIJCO5kIXw+8Hoz+mf VFtQNoF2P6aVKHoGVHAjllWU40oM9W7FDpDRH5nOGnCKJzFbL2eCyPj4743qYs4qk343 78Cg== X-Gm-Message-State: AFqh2kpPUA9tSuRYxOxZ95+8axqCbuvFT97kiPa0FZ8eSzwi5Im3Lk4/ C0ibAmNUTcZXqRy27P+5Y5as1w== X-Google-Smtp-Source: AMrXdXuKdhKIqJEou6IJmM5yvUMjMnUD67NRnsbGkBHfaQP6Ex2vg3VDK1+5I1ULAcU+W6HSfx0aeA== X-Received: by 2002:adf:f0cd:0:b0:2bd:d783:377 with SMTP id x13-20020adff0cd000000b002bdd7830377mr12934188wro.22.1674209939686; Fri, 20 Jan 2023 02:18:59 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r9-20020adff709000000b00291f1a5ced6sm14862170wrp.53.2023.01.20.02.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 02:18:59 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 11:18:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight Content-Language: en-US To: Jianhua Lu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org References: <20230120094728.19967-1-lujianhua000@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230120094728.19967-1-lujianhua000@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/01/2023 10:47, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu > --- > Changes in v2: > - Remove "items" between "compatible" and "const: kinetic,ktz8866". > - Change "additionalProperties" to "unevaluatedProperties". > > Changes in v3: > - Add Krzysztof's R-b. > > Changes in v4: > - Drop Krzysztof's R-b. > - Add some new properties. > > Changes in v5: > - Add missing enum under property description. > - Rename uncorrect properties. > > Changes in v6: > - Correct wrong property suffix and description. > > Changes in v7: > - Add vddpos and vddeg supply. > - Use enable-gpios instead of defining enable pin. > > .../leds/backlight/kinetic,ktz8866.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > new file mode 100644 > index 000000000000..b1d0ade0dfb6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kinetic Technologies KTZ8866 backlight > + > +maintainers: > + - Jianhua Lu > + > +description: | > + The Kinetic Technologies KTZ8866 is a high efficiency 6-channels-current-sinks > + led backlight with dual lcd bias power. > + https://www.kinet-ic.com/ktz8866/ > + > +allOf: > + - $ref: common.yaml# > + > +properties: > + compatible: > + const: kinetic,ktz8866 > + > + vddpos-supply: > + description: positive boost supply regulator. > + > + vddneg-supply: > + description: negative boost supply regulator. > + > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > + current-num-sinks: > + description: number of the LED current sinks' channels. > + enum: [1, 2, 3, 4, 5, 6] > + > + current-ramping-time-ms: > + description: LED current ramping time in milliseconds. > + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640] kinetic,current-ramp-delay-ms > + > + led-ramping-time-ms: kinetic,led-enable-ramp-delay-ms So both are similar to existing regulator properties. Best regards, Krzysztof