From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F27C352A4 for ; Mon, 10 Feb 2020 08:15:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD20A2080C for ; Mon, 10 Feb 2020 08:15:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="dvR38sGt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbgBJIPn (ORCPT ); Mon, 10 Feb 2020 03:15:43 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:34024 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbgBJIPn (ORCPT ); Mon, 10 Feb 2020 03:15:43 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 01A8FbMv088886; Mon, 10 Feb 2020 02:15:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1581322537; bh=PAMhLJEVoKez77kRy1+G5NQ28X0Xb9Qsg/juioCbCKg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=dvR38sGtb2humWVFIHpjic3lU47EjZyFbMq7WpnXv6FuvqPfLQhd0zhyzpbJLT4z4 jzzi+3prN73y4X/n0+W6IK2DI0rlb1c128LZ1ZEXkBCYj0CztfYIw8P0kF4k6lcZh/ LXUYl0uZHYu9pvJ6KUCj4Xxss6gXdRWYAVautIMw= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 01A8FbPB105360 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 10 Feb 2020 02:15:37 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Mon, 10 Feb 2020 02:15:36 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Mon, 10 Feb 2020 02:15:36 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 01A8FYi7062145; Mon, 10 Feb 2020 02:15:34 -0600 Subject: Re: [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge To: Thierry Reding CC: Laurent Pinchart , , , Tony Lindgren , Jyri Sarha , Peter Ujfalusi References: <20191114093950.4101-1-tomi.valkeinen@ti.com> <20191114093950.4101-4-tomi.valkeinen@ti.com> <20191202130717.GI4929@pendragon.ideasonboard.com> From: Tomi Valkeinen Message-ID: Date: Mon, 10 Feb 2020 10:15:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20191202130717.GI4929@pendragon.ideasonboard.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Thierry, On 02/12/2019 15:07, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote: >> The panel datasheet says that the panel samples at falling edge, but >> does not say anything about h/v sync signals. Testing shows that if the >> sync signals are driven on falling edge, the picture on the panel will >> be slightly shifted right. >> >> Setting sync drive edge to the same as data drive edge fixes this issue. >> >> Signed-off-by: Tomi Valkeinen > > I don't have access to the documentation, but this makes sense, so > > Acked-by: Laurent Pinchart > >> --- >> drivers/gpu/drm/panel/panel-simple.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 5d487686d25c..0784536ae6af 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = { >> .height = 91, >> }, >> .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >> - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | >> + DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE, >> .connector_type = DRM_MODE_CONNECTOR_DPI, >> }; Can this be merged? Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki