From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v4 16/20] iommu/tegra: gart: Don't use managed resources Date: Mon, 24 Sep 2018 21:57:10 +0300 Message-ID: References: <20180924004153.8232-1-digetx@gmail.com> <20180924004153.8232-17-digetx@gmail.com> <20180924105246.GM21032@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180924105246.GM21032@ulmo> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Thierry Reding Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Hunter , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rob Herring , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robin Murphy List-Id: devicetree@vger.kernel.org On 9/24/18 1:52 PM, Thierry Reding wrote: > On Mon, Sep 24, 2018 at 03:41:49AM +0300, Dmitry Osipenko wrote: >> GART is a part of the Memory Controller driver that is always built-in, >> hence there is no benefit from the use of managed resources. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/iommu/tegra-gart.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) > > One benefit would be cleanup on probe error. Also, we may eventually > want to make even the memory controller driver buildable as a module. Please, let's keep that patch as is and re-introduce devm once it will become really relevant.