devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip
@ 2024-08-21 21:53 Ilya Orazov
  2024-08-21 21:53 ` [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
       [not found] ` <thpryn4unrebkvx4a7jhqmxt5ntmog2gcw3ekh6h72jews4een@b43tsg7poegn>
  0 siblings, 2 replies; 5+ messages in thread
From: Ilya Orazov @ 2024-08-21 21:53 UTC (permalink / raw)
  To: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aswath Govindraju
  Cc: linux-can, linux-phy, devicetree, Ilya Orazov

Hi all,

As suggested in the previous email conversation on this patch, I am
sending this new version as a standalone email. I hope this approach
makes it easier to review and keeps the conversation history clearer.

Thank you for your feedback!

Ilya Orazov (1):
  dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

 .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)


base-commit: b311c1b497e51a628aa89e7cb954481e5f9dced2
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
  2024-08-21 21:53 [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
@ 2024-08-21 21:53 ` Ilya Orazov
  2024-08-22  7:10   ` Krzysztof Kozlowski
       [not found] ` <thpryn4unrebkvx4a7jhqmxt5ntmog2gcw3ekh6h72jews4een@b43tsg7poegn>
  1 sibling, 1 reply; 5+ messages in thread
From: Ilya Orazov @ 2024-08-21 21:53 UTC (permalink / raw)
  To: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aswath Govindraju
  Cc: linux-can, linux-phy, devicetree, Ilya Orazov

Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
It is pin-compatible with TI TCAN1042 and has a compatible programming
model, therefore use ti,tcan1042 as fallback compatible.

Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
---
 .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
index 79dad3e89aa6..4a8c3829d85d 100644
--- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -14,10 +14,15 @@ properties:
     pattern: "^can-phy"
 
   compatible:
-    enum:
-      - nxp,tjr1443
-      - ti,tcan1042
-      - ti,tcan1043
+    oneOf:
+      - items:
+          - enum:
+              - microchip,ata6561
+          - const: ti,tcan1042
+      - enum:
+          - ti,tcan1042
+          - ti,tcan1043
+          - nxp,tjr1443
 
   '#phy-cells':
     const: 0
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
  2024-08-21 21:53 ` [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
@ 2024-08-22  7:10   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-22  7:10 UTC (permalink / raw)
  To: Ilya Orazov
  Cc: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aswath Govindraju, linux-can, linux-phy, devicetree

On Thu, Aug 22, 2024 at 12:53:57AM +0300, Ilya Orazov wrote:
> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> It is pin-compatible with TI TCAN1042 and has a compatible programming
> model, therefore use ti,tcan1042 as fallback compatible.
> 
> Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
> ---

Where is the changelog?

Where is the tag you received?

Why sending it again without any of the above?

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation: Please add
Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
or above your Signed-off-by tag. Tag is "received", when provided
in a message replied to you on the mailing list. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for tags received on the version
they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip
       [not found] ` <thpryn4unrebkvx4a7jhqmxt5ntmog2gcw3ekh6h72jews4een@b43tsg7poegn>
@ 2024-08-22 10:35   ` Ilya Orazov
  2024-08-22 11:02     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Ilya Orazov @ 2024-08-22 10:35 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aswath Govindraju, linux-can, linux-phy, devicetree

On Thu, 22 Aug 2024 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Aug 22, 2024 at 12:53:56AM +0300, Ilya Orazov wrote:
> > Hi all,
> >
> > As suggested in the previous email conversation on this patch, I am
> > sending this new version as a standalone email. I hope this approach
> > makes it easier to review and keeps the conversation history clearer.
>
> Where was it suggested?
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,

Conor suggested that I should not send new versions of the patch as
replies in his mail [0]. So, I sent the new one as a separate email.

0- https://lore.kernel.org/all/20240809-guru-tassel-84a14486a596@spud/

-- 
Best regards,
Ilya Orazov

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip
  2024-08-22 10:35   ` [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
@ 2024-08-22 11:02     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-22 11:02 UTC (permalink / raw)
  To: Ilya Orazov
  Cc: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aswath Govindraju, linux-can, linux-phy, devicetree

On 22/08/2024 12:35, Ilya Orazov wrote:
> On Thu, 22 Aug 2024 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Aug 22, 2024 at 12:53:56AM +0300, Ilya Orazov wrote:
>>> Hi all,
>>>
>>> As suggested in the previous email conversation on this patch, I am
>>> sending this new version as a standalone email. I hope this approach
>>> makes it easier to review and keeps the conversation history clearer.
>>
>> Where was it suggested?
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hi Krzysztof,
> 
> Conor suggested that I should not send new versions of the patch as
> replies in his mail [0]. So, I sent the new one as a separate email.
> 
> 0- https://lore.kernel.org/all/20240809-guru-tassel-84a14486a596@spud/

OK, I misunderstood what you mean by "standalone email". So this was
just resend? Then patch should be marked as RESEND.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-22 11:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 21:53 [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
2024-08-21 21:53 ` [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
2024-08-22  7:10   ` Krzysztof Kozlowski
     [not found] ` <thpryn4unrebkvx4a7jhqmxt5ntmog2gcw3ekh6h72jews4een@b43tsg7poegn>
2024-08-22 10:35   ` [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
2024-08-22 11:02     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).